All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [patch-v2.6.33-rc2+ 06/12] arm: omap: kill compile warning in irq.c
Date: Tue, 5 Jan 2010 12:20:53 -0800	[thread overview]
Message-ID: <20100105202053.GB14533@atomide.com> (raw)
In-Reply-To: <1262127092-14878-7-git-send-email-felipe.balbi@nokia.com>

* Felipe Balbi <felipe.balbi@nokia.com> [091229 14:54]:
> intc_context is only used when omap3 is to be built,
> so also put it under ifdef CONFIG_ARM_OMAP3 to avoid
> the compile warning.
> 
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  arch/arm/mach-omap2/irq.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index e9bc782..d370052 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -62,7 +62,9 @@ struct omap3_intc_regs {
>  	u32 mir[INTCPS_NR_MIR_REGS];
>  };
>  
> +#ifdef CONFIG_ARCH_OMAP3
>  static struct omap3_intc_regs intc_context[ARRAY_SIZE(irq_banks)];
> +#endif
>  
>  /* INTC bank register get/set */

Can you please move the struct omap3_intc_regs intc_context into
to right above save_context function where we have the a block
already for ifdef CONFIG_ARCH_OMAP3?

That avoids adding a new ifdef block.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch-v2.6.33-rc2+ 06/12] arm: omap: kill compile warning in irq.c
Date: Tue, 5 Jan 2010 12:20:53 -0800	[thread overview]
Message-ID: <20100105202053.GB14533@atomide.com> (raw)
In-Reply-To: <1262127092-14878-7-git-send-email-felipe.balbi@nokia.com>

* Felipe Balbi <felipe.balbi@nokia.com> [091229 14:54]:
> intc_context is only used when omap3 is to be built,
> so also put it under ifdef CONFIG_ARM_OMAP3 to avoid
> the compile warning.
> 
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  arch/arm/mach-omap2/irq.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index e9bc782..d370052 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -62,7 +62,9 @@ struct omap3_intc_regs {
>  	u32 mir[INTCPS_NR_MIR_REGS];
>  };
>  
> +#ifdef CONFIG_ARCH_OMAP3
>  static struct omap3_intc_regs intc_context[ARRAY_SIZE(irq_banks)];
> +#endif
>  
>  /* INTC bank register get/set */

Can you please move the struct omap3_intc_regs intc_context into
to right above save_context function where we have the a block
already for ifdef CONFIG_ARCH_OMAP3?

That avoids adding a new ifdef block.

Regards,

Tony

  reply	other threads:[~2010-01-05 20:20 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29 22:51 [patch-v2.6.33-rc2+ 00/12] arm omap patches for next -rc Felipe Balbi
2009-12-29 22:51 ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 01/12] arm: omap: musb: ioremap only what's ours Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 23:51   ` Felipe Balbi
2009-12-29 23:51     ` Felipe Balbi
     [not found] ` <1262127092-14878-1-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-29 22:51   ` [patch-v2.6.33-rc2+ 02/12] arm: omap: musb: fix board power budget by passing it to usb_musb_init Felipe Balbi
2009-12-29 22:51     ` Felipe Balbi
2009-12-30 11:13     ` Sergei Shtylyov
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 03/12] arm: omap: musb: fix board mode " Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 04/12] arm: omap1: mailbox: kill compile warning Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 05/12] arm: omap: gpmc: " Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 06/12] arm: omap: kill compile warning in irq.c Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2010-01-05 20:20   ` Tony Lindgren [this message]
2010-01-05 20:20     ` Tony Lindgren
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 07/12] arm: omap: remove unused variables Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 08/12] arm: omap: io: kill compile warning Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 09/12] arm: omap: kill compile warning on board-4430-sdp.c Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 10/12] arm: omap: gpio: kill compile warning in gpio.c Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2010-01-05 20:20   ` Tony Lindgren
2010-01-05 20:20     ` Tony Lindgren
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 11/12] arm: omap: mailbox: kill compile warning in mailbox.c Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi
2009-12-29 22:51 ` [patch-v2.6.33-rc2+ 12/12] arm: omap: perseus: kill compile warning on board-perseus2.c Felipe Balbi
2009-12-29 22:51   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100105202053.GB14533@atomide.com \
    --to=tony@atomide.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.