From: "John W. Linville" <linville@tuxdriver.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: wireless, fix lock imbalance
Date: Wed, 6 Jan 2010 14:55:03 -0500 [thread overview]
Message-ID: <20100106195503.GB2870@tuxdriver.com> (raw)
In-Reply-To: <1262795743-15009-1-git-send-email-jslaby@suse.cz>
On Wed, Jan 06, 2010 at 05:35:42PM +0100, Jiri Slaby wrote:
> One fail path in cfg80211_wext_siwscan omits to unlock rdev->mtx.
> Fix that.
>
> Trigerrable by "Scan for SSID" with long enough SSID (> 32).
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Both this and the next one are already fixed in wireless-2.6...
commit 65486c8b30498dd274eea2c542696f22b63fe5b8
Author: Johannes Berg <johannes@sipsolutions.net>
Date: Wed Dec 23 15:33:35 2009 +0100
cfg80211: fix error path in cfg80211_wext_siwscan
If there's an invalid channel or SSID, the code leaks
the scan request. Always free the scan request, unless
it was successfully given to the driver.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-01-06 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 16:35 [PATCH 1/2] net: wireless, fix lock imbalance Jiri Slaby
2010-01-06 16:35 ` [PATCH 2/2] NET: wireless, fix memory leak Jiri Slaby
2010-01-06 17:43 ` Luis R. Rodriguez
2010-01-06 19:07 ` Gertjan van Wingerde
2010-01-06 19:14 ` Jiri Slaby
2010-01-06 17:44 ` [PATCH 1/2] net: wireless, fix lock imbalance Luis R. Rodriguez
2010-01-06 19:55 ` John W. Linville [this message]
2010-01-06 20:30 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106195503.GB2870@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.