From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Emese Revfy <re.emese@gmail.com>,
linux-omap@vger.kernel.org,
Richard Purdie <rpurdie@linux.intel.com>
Subject: [PATCH 06/12] omap1: Fix compile for omap1_bl.c
Date: Wed, 06 Jan 2010 16:19:46 -0800 [thread overview]
Message-ID: <20100107001946.21352.78046.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100107001728.21352.38471.stgit@baageli.muru.com>
Commit 9905a43b made struct backlight_ops const. Omap was
setting check_fb dynamically, which caused the following
compile error:
drivers/video/backlight/omap1_bl.c: In function 'omapbl_probe':
drivers/video/backlight/omap1_bl.c:142: error: assignment of read-only variable 'omapbl_ops'
Turns out pdata->check_fb is not being used, so just remove
it to fix the compile.
Cc: Emese Revfy <re.emese@gmail.com>
Cc: Richard Purdie <rpurdie@linux.intel.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/include/plat/board.h | 1 -
drivers/video/backlight/omap1_bl.c | 2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/board.h b/arch/arm/plat-omap/include/plat/board.h
index 376ce18..5cd6220 100644
--- a/arch/arm/plat-omap/include/plat/board.h
+++ b/arch/arm/plat-omap/include/plat/board.h
@@ -99,7 +99,6 @@ struct fb_info;
struct omap_backlight_config {
int default_intensity;
int (*set_power)(struct device *dev, int state);
- int (*check_fb)(struct fb_info *fb);
};
struct omap_fbmem_config {
diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c
index 409ca96..a3a7f89 100644
--- a/drivers/video/backlight/omap1_bl.c
+++ b/drivers/video/backlight/omap1_bl.c
@@ -139,8 +139,6 @@ static int omapbl_probe(struct platform_device *pdev)
if (!pdata)
return -ENXIO;
- omapbl_ops.check_fb = pdata->check_fb;
-
bl = kzalloc(sizeof(struct omap_backlight), GFP_KERNEL);
if (unlikely(!bl))
return -ENOMEM;
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/12] omap1: Fix compile for omap1_bl.c
Date: Wed, 06 Jan 2010 16:19:46 -0800 [thread overview]
Message-ID: <20100107001946.21352.78046.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100107001728.21352.38471.stgit@baageli.muru.com>
Commit 9905a43b made struct backlight_ops const. Omap was
setting check_fb dynamically, which caused the following
compile error:
drivers/video/backlight/omap1_bl.c: In function 'omapbl_probe':
drivers/video/backlight/omap1_bl.c:142: error: assignment of read-only variable 'omapbl_ops'
Turns out pdata->check_fb is not being used, so just remove
it to fix the compile.
Cc: Emese Revfy <re.emese@gmail.com>
Cc: Richard Purdie <rpurdie@linux.intel.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/include/plat/board.h | 1 -
drivers/video/backlight/omap1_bl.c | 2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/board.h b/arch/arm/plat-omap/include/plat/board.h
index 376ce18..5cd6220 100644
--- a/arch/arm/plat-omap/include/plat/board.h
+++ b/arch/arm/plat-omap/include/plat/board.h
@@ -99,7 +99,6 @@ struct fb_info;
struct omap_backlight_config {
int default_intensity;
int (*set_power)(struct device *dev, int state);
- int (*check_fb)(struct fb_info *fb);
};
struct omap_fbmem_config {
diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c
index 409ca96..a3a7f89 100644
--- a/drivers/video/backlight/omap1_bl.c
+++ b/drivers/video/backlight/omap1_bl.c
@@ -139,8 +139,6 @@ static int omapbl_probe(struct platform_device *pdev)
if (!pdata)
return -ENXIO;
- omapbl_ops.check_fb = pdata->check_fb;
-
bl = kzalloc(sizeof(struct omap_backlight), GFP_KERNEL);
if (unlikely(!bl))
return -ENOMEM;
next prev parent reply other threads:[~2010-01-07 0:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 0:18 [PATCH 00/12] Omap fixes for 2.6.33-rc3 Tony Lindgren
2010-01-07 0:18 ` Tony Lindgren
2010-01-07 0:18 ` [PATCH 01/12] omap: McBSP: Fix possible port lockout Tony Lindgren
2010-01-07 0:18 ` Tony Lindgren
2010-01-08 17:14 ` Sergei Shtylyov
2010-01-10 19:55 ` Janusz Krzysztofik
2010-01-10 19:55 ` Janusz Krzysztofik
2010-01-07 0:18 ` [PATCH 02/12] omap: gpio: Simultaneously requested rising and falling edge Tony Lindgren
2010-01-07 0:18 ` Tony Lindgren
2010-01-07 0:19 ` [PATCH 03/12] omap: &&/|| confusion in iommu_put() Tony Lindgren
2010-01-07 0:19 ` Tony Lindgren
2010-01-07 0:19 ` [PATCH 04/12] omap: Remove uninitialized warning for gpio.c Tony Lindgren
2010-01-07 0:19 ` Tony Lindgren
2010-01-07 0:19 ` [PATCH 05/12] omap1: Add 7xx clocks and pin muxes for SPI Tony Lindgren
2010-01-07 0:19 ` Tony Lindgren
2010-01-07 9:46 ` Grazvydas Ignotas
2010-01-07 9:46 ` Grazvydas Ignotas
2010-01-07 19:15 ` Tony Lindgren
2010-01-07 19:15 ` Tony Lindgren
2010-01-09 18:02 ` Cory Maccarrone
2010-01-09 18:02 ` Cory Maccarrone
2010-01-07 0:19 ` Tony Lindgren [this message]
2010-01-07 0:19 ` [PATCH 06/12] omap1: Fix compile for omap1_bl.c Tony Lindgren
2010-01-07 0:19 ` [PATCH 07/12] omap2/3: make serial_in_override() address the right uart port Tony Lindgren
2010-01-07 0:19 ` Tony Lindgren
2010-01-07 0:20 ` [PATCH 08/12] omap2/3: ZOOM: Correcting key mapping for few keys Tony Lindgren
2010-01-07 0:20 ` Tony Lindgren
2010-01-07 0:20 ` [PATCH 09/12] omap3: add missing parentheses Tony Lindgren
2010-01-07 0:20 ` Tony Lindgren
2010-01-07 0:20 ` [PATCH 10/12] " Tony Lindgren
2010-01-07 0:20 ` Tony Lindgren
2010-01-07 0:20 ` [PATCH 11/12] omap3: Fix booting if package is uninitialized Tony Lindgren
2010-01-07 0:20 ` Tony Lindgren
2010-01-07 0:20 ` [PATCH 12/12] omap3: EVM: Choose OMAP_PACKAGE_CBB Tony Lindgren
2010-01-07 0:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107001946.21352.78046.stgit@baageli.muru.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=re.emese@gmail.com \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.