From: Robert Millan <rmh@aybabtu.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "grub-devel@gnu.org" <grub-devel@gnu.org>,
Zhu Yi <chuyee@octavia.sh.intel.com>
Subject: Re: [PATCH 2/2] Add grub-install --restore option
Date: Thu, 7 Jan 2010 02:36:53 +0100 [thread overview]
Message-ID: <20100107013653.GA22169@thorin> (raw)
In-Reply-To: <1262826605.15653.157.camel@debian>
On Thu, Jan 07, 2010 at 09:10:05AM +0800, Zhu Yi wrote:
> >
> > Please don't add this to grub-install. This kind of highly BIOS-specific
> > logic would suit much better in grub-setup.
>
> Do you prefer to implement above in C code and add a "--restore" option
> to grub-setup or create a separate script for doing this?
I think a --restore option to grub-setup would be more appropiate, since the
save routine is also there (also, C suits better for this kind of byte
mangling IMO).
What do others think?
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi
prev parent reply other threads:[~2010-01-07 1:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 9:10 [PATCH 1/2] Backup old boot sectors before installation Zhu Yi
2010-01-06 9:10 ` [PATCH 2/2] Add grub-install --restore option Zhu Yi
2010-01-06 13:50 ` Robert Millan
2010-01-07 1:10 ` Zhu Yi
2010-01-07 1:36 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107013653.GA22169@thorin \
--to=rmh@aybabtu.com \
--cc=chuyee@octavia.sh.intel.com \
--cc=grub-devel@gnu.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.