From: Rusty Russell <rusty@rustcorp.com.au>
To: David Rientjes <rientjes@google.com>
Cc: Anton Blanchard <anton@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 6/6] x86: cpumask_of_node() should handle -1 as a node
Date: Thu, 7 Jan 2010 11:09:10 +1030 [thread overview]
Message-ID: <201001071109.10362.rusty@rustcorp.com.au> (raw)
In-Reply-To: <alpine.DEB.2.00.1001061545210.19882@chino.kir.corp.google.com>
On Thu, 7 Jan 2010 10:21:06 am David Rientjes wrote:
> On Thu, 7 Jan 2010, Anton Blanchard wrote:
>
> > I don't like the use of -1 as a node, but it's much more widespread than
> > x86; including sh, powerpc, sparc and the generic topology code. eg:
> >
> >
> > #fdef CONFIG_PCI
> > extern int pcibus_to_node(struct pci_bus *pbus);
> > #else
> > static inline int pcibus_to_node(struct pci_bus *pbus)
> > {
> > return -1;
> > }
>
> This seems to be the same semantics that NUMA_NO_NODE was defined for,
> it's not necessarily a special case.
It's widespread, and we've just had another bug due to pcibus_to_node handling
-1 and cpumask_of_node not. (Search lkml for subject "[Regression] 2.6.33-rc2
- pci: Commit e0cd516 causes OOPS").
So I think the evidence is in favor of just handling -1.
Cheers,
Rusty.
next prev parent reply other threads:[~2010-01-07 0:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 4:55 [patch 0/6] cpumask_of_node() should handle -1 as a node Anton Blanchard
2010-01-06 4:55 ` [patch 1/6] powerpc: " Anton Blanchard
2010-01-06 4:55 ` Anton Blanchard
2010-01-06 4:55 ` [patch 2/6] alpha: " Anton Blanchard
2010-01-14 18:24 ` Matt Turner
2010-01-14 18:24 ` Matt Turner
2010-01-06 4:55 ` [patch 3/6] ia64: " Anton Blanchard
2010-01-06 4:55 ` Anton Blanchard
2010-01-06 4:55 ` [patch 4/6] mips: " Anton Blanchard
2010-01-06 4:55 ` Anton Blanchard
2010-01-11 10:42 ` Ralf Baechle
2010-01-06 4:55 ` [patch 5/6] sparc: " Anton Blanchard
2010-01-06 4:55 ` Anton Blanchard
2010-01-07 4:22 ` David Miller
2010-01-07 4:22 ` David Miller
2010-01-06 4:55 ` [patch 6/6] x86: " Anton Blanchard
2010-01-06 6:36 ` Rusty Russell
2010-01-06 23:00 ` David Rientjes
2010-01-06 23:31 ` Anton Blanchard
2010-01-06 23:51 ` David Rientjes
2010-01-07 0:01 ` Anton Blanchard
2010-01-07 0:25 ` David Rientjes
2010-01-07 0:39 ` Rusty Russell [this message]
2010-01-07 8:04 ` David Rientjes
2010-01-06 23:20 ` Anton Blanchard
2010-01-11 22:11 ` [patch 0/6] " Andrew Morton
2010-01-12 1:07 ` Anton Blanchard
2010-01-12 2:04 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001071109.10362.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anton@samba.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.