All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Németh Márton" <nm127@freemail.hu>
Cc: lm-sensors@lm-sensors.org, Julia Lawall <julia@diku.dk>,
	LKML <linux-kernel@vger.kernel.org>,
	cocci@diku.dk
Subject: Re: [lm-sensors] [PATCH 1/5] via686a: make PCI device id constant
Date: Thu, 07 Jan 2010 15:06:43 +0000	[thread overview]
Message-ID: <20100107160643.35af80a5@hyperion.delvare> (raw)
In-Reply-To: <4B427D3B.6080709@freemail.hu>

On Tue, 05 Jan 2010 00:43:55 +0100, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
> 
> The id_table field of the struct pci_driver is constant in <linux/pci.h>
> so it is worth to make pci_device_id also constant.
> 
> The semantic match that finds this kind of pattern is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> identifier I1, I2, x;
> @@
> 	struct I1 {
> 	  ...
> 	  const struct I2 *x;
> 	  ...
> 	};
> @s@
> identifier r.I1, y;
> identifier r.x, E;
> @@
> 	struct I1 y = {
> 	  .x = E,
> 	};
> @c@
> identifier r.I2;
> identifier s.E;
> @@
> 	const struct I2 E[] = ... ;
> @depends on !c@
> identifier r.I2;
> identifier s.E;
> @@
> +	const
> 	struct I2 E[] = ...;
> // </smpl>
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> Cc: Julia Lawall <julia@diku.dk>
> Cc: cocci@diku.dk
> ---
> diff -u -p a/drivers/hwmon/via686a.c b/drivers/hwmon/via686a.c
> --- a/drivers/hwmon/via686a.c 2009-12-03 04:51:21.000000000 +0100
> +++ b/drivers/hwmon/via686a.c 2010-01-03 20:55:10.000000000 +0100
> @@ -767,7 +767,7 @@ static struct via686a_data *via686a_upda
>  	return data;
>  }
> 
> -static struct pci_device_id via686a_pci_ids[] = {
> +static const struct pci_device_id via686a_pci_ids[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4) },
>  	{ 0, }
>  };

I've merged all 5 patches are they are doing the exact same thing to 5
drivers. The resulting patch is applied, thanks.


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: "Németh Márton" <nm127@freemail.hu>
Cc: lm-sensors@lm-sensors.org, Julia Lawall <julia@diku.dk>,
	LKML <linux-kernel@vger.kernel.org>,
	cocci@diku.dk
Subject: Re: [lm-sensors] [PATCH 1/5] via686a: make PCI device id constant
Date: Thu, 7 Jan 2010 16:06:43 +0100	[thread overview]
Message-ID: <20100107160643.35af80a5@hyperion.delvare> (raw)
In-Reply-To: <4B427D3B.6080709@freemail.hu>

On Tue, 05 Jan 2010 00:43:55 +0100, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
> 
> The id_table field of the struct pci_driver is constant in <linux/pci.h>
> so it is worth to make pci_device_id also constant.
> 
> The semantic match that finds this kind of pattern is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> identifier I1, I2, x;
> @@
> 	struct I1 {
> 	  ...
> 	  const struct I2 *x;
> 	  ...
> 	};
> @s@
> identifier r.I1, y;
> identifier r.x, E;
> @@
> 	struct I1 y = {
> 	  .x = E,
> 	};
> @c@
> identifier r.I2;
> identifier s.E;
> @@
> 	const struct I2 E[] = ... ;
> @depends on !c@
> identifier r.I2;
> identifier s.E;
> @@
> +	const
> 	struct I2 E[] = ...;
> // </smpl>
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> Cc: Julia Lawall <julia@diku.dk>
> Cc: cocci@diku.dk
> ---
> diff -u -p a/drivers/hwmon/via686a.c b/drivers/hwmon/via686a.c
> --- a/drivers/hwmon/via686a.c 2009-12-03 04:51:21.000000000 +0100
> +++ b/drivers/hwmon/via686a.c 2010-01-03 20:55:10.000000000 +0100
> @@ -767,7 +767,7 @@ static struct via686a_data *via686a_upda
>  	return data;
>  }
> 
> -static struct pci_device_id via686a_pci_ids[] = {
> +static const struct pci_device_id via686a_pci_ids[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4) },
>  	{ 0, }
>  };

I've merged all 5 patches are they are doing the exact same thing to 5
drivers. The resulting patch is applied, thanks.


-- 
Jean Delvare

  reply	other threads:[~2010-01-07 15:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04 23:43 [lm-sensors] [PATCH 1/5] via686a: make PCI device id constant Németh Márton
2010-01-04 23:43 ` Németh Márton
2010-01-07 15:06 ` Jean Delvare [this message]
2010-01-07 15:06   ` [lm-sensors] " Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100107160643.35af80a5@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=cocci@diku.dk \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=nm127@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.