From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Pavel Machek <pavel@ucw.cz>,
"Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>,
linux-kernel@vger.kernel.org, felipe.balbi@nokia.com,
jayakumar.lkml@gmail.com, linux-fbdev@vger.kernel.org,
krzysztof.h1@wp.pl, akpm@linux-foundation.org,
linux-usb@vger.kernel.org, oliver@neukum.org,
linux-input@vger.kernel.org, jkosina@suse.cz
Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.3
Date: Fri, 08 Jan 2010 17:20:51 +0000 [thread overview]
Message-ID: <201001080920.51979.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20100108171329.GA4711@kroah.com>
On Friday 08 January 2010 09:13:29 am Greg KH wrote:
> On Fri, Jan 08, 2010 at 06:04:50PM +0100, Pavel Machek wrote:
> > On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote:
> > > Pavel Machek wrote:
> > > > Hi!
> > > >
> > > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store);
> > > >>
> > > >> What this attribute is for?
> > > >
> > > > Actually, all the new files this added need to be documented.
> > >
> > > Which is better? A hid-g13.txt file added to Documentation/ or comments
> > > in the driver itself?
> >
> > Documentation. Coordinate with sysfs maintainer (gregkh).
>
> All sysfs files need to be documented in Documentation/ABI/ Please add
> the documentation there for your new sysfs files.
We need to have an agreement that all of them are needed first though.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Pavel Machek <pavel@ucw.cz>,
"Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>,
linux-kernel@vger.kernel.org, felipe.balbi@nokia.com,
jayakumar.lkml@gmail.com, linux-fbdev@vger.kernel.org,
krzysztof.h1@wp.pl, akpm@linux-foundation.org,
linux-usb@vger.kernel.org, oliver@neukum.org,
linux-input@vger.kernel.org, jkosina@suse.cz
Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.3
Date: Fri, 8 Jan 2010 09:20:51 -0800 [thread overview]
Message-ID: <201001080920.51979.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20100108171329.GA4711@kroah.com>
On Friday 08 January 2010 09:13:29 am Greg KH wrote:
> On Fri, Jan 08, 2010 at 06:04:50PM +0100, Pavel Machek wrote:
> > On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote:
> > > Pavel Machek wrote:
> > > > Hi!
> > > >
> > > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store);
> > > >>
> > > >> What this attribute is for?
> > > >
> > > > Actually, all the new files this added need to be documented.
> > >
> > > Which is better? A hid-g13.txt file added to Documentation/ or comments
> > > in the driver itself?
> >
> > Documentation. Coordinate with sysfs maintainer (gregkh).
>
> All sysfs files need to be documented in Documentation/ABI/ Please add
> the documentation there for your new sysfs files.
We need to have an agreement that all of them are needed first though.
--
Dmitry
next prev parent reply other threads:[~2010-01-08 17:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 16:23 [PATCH] hid: Logitech G13 driver 0.0.3 Rick L. Vinyard Jr.
2010-01-07 16:23 ` Rick L. Vinyard Jr.
2010-01-07 16:23 ` Rick L. Vinyard Jr.
2010-01-07 19:35 ` Pavel Machek
2010-01-07 19:35 ` Pavel Machek
2010-01-07 21:20 ` Rick L. Vinyard, Jr.
2010-01-07 21:20 ` Rick L. Vinyard, Jr.
2010-01-08 2:32 ` Jaya Kumar
2010-01-08 2:32 ` Jaya Kumar
2010-01-08 2:32 ` Jaya Kumar
2010-01-08 5:26 ` Rick L. Vinyard, Jr.
2010-01-08 5:26 ` Rick L. Vinyard, Jr.
2010-01-08 5:26 ` Rick L. Vinyard, Jr.
2010-01-09 13:43 ` Jiri Kosina
2010-01-09 13:43 ` Jiri Kosina
2010-01-09 13:43 ` Jiri Kosina
2010-01-14 18:24 ` Rick L. Vinyard, Jr.
2010-01-14 18:24 ` Rick L. Vinyard, Jr.
2010-01-14 18:24 ` Rick L. Vinyard, Jr.
2010-01-14 20:50 ` Best way to post Logitech G13 driver 0.0.4? Rick L. Vinyard, Jr.
2010-01-14 20:50 ` Rick L. Vinyard, Jr.
2010-01-14 21:03 ` Pavel Machek
2010-01-14 21:03 ` Pavel Machek
2010-01-14 22:05 ` Jiri Kosina
2010-01-14 22:05 ` Jiri Kosina
2010-01-08 8:30 ` [PATCH] hid: Logitech G13 driver 0.0.3 Dmitry Torokhov
2010-01-08 8:30 ` Dmitry Torokhov
2010-01-08 16:36 ` Pavel Machek
2010-01-08 16:36 ` Pavel Machek
2010-01-08 16:50 ` Rick L. Vinyard, Jr.
2010-01-08 16:50 ` Rick L. Vinyard, Jr.
2010-01-08 17:04 ` Pavel Machek
2010-01-08 17:04 ` Pavel Machek
2010-01-08 17:13 ` Greg KH
2010-01-08 17:13 ` Greg KH
2010-01-08 17:20 ` Dmitry Torokhov [this message]
2010-01-08 17:20 ` Dmitry Torokhov
[not found] ` <201001080920.51979.dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-01-08 17:43 ` Rick L. Vinyard, Jr.
2010-01-08 17:43 ` Rick L. Vinyard, Jr.
2010-01-08 17:43 ` Rick L. Vinyard, Jr.
2010-01-08 18:32 ` Rick L. Vinyard, Jr.
2010-01-08 18:32 ` Rick L. Vinyard, Jr.
2010-01-08 20:49 ` Dmitry Torokhov
2010-01-08 20:49 ` Dmitry Torokhov
[not found] ` <20100108204946.GA22950-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-01-08 22:27 ` Rick L. Vinyard, Jr.
2010-01-08 22:27 ` Rick L. Vinyard, Jr.
2010-01-08 22:27 ` Rick L. Vinyard, Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001080920.51979.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=felipe.balbi@nokia.com \
--cc=greg@kroah.com \
--cc=jayakumar.lkml@gmail.com \
--cc=jkosina@suse.cz \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pavel@ucw.cz \
--cc=rvinyard@cs.nmsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.