From: Tony Lindgren <tony@atomide.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [GIT PULL] omap fixes for 2.6.33-rc3
Date: Fri, 8 Jan 2010 14:50:23 -0800 [thread overview]
Message-ID: <20100108225023.GD2879@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001081430210.7821@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> [100108 14:38]:
>
>
> On Fri, 8 Jan 2010, Tony Lindgren wrote:
> >
> > $ git log --pretty=oneline --author=".(none)" --committer=".(none)" v2.6.33-rc1..
>
> Well, that will catch one particular common case of it, but..
>
> > Should we have some check like this in place for all pulls?
>
> .. it would probably make more sense to warn about it earlier in the
> chain, so that people with bad configurations can fix them. By the time
> somebody pulls, it's pretty late in the game.
>
> Sadly, git doesn't do any real sanity checking, and now it's pretty much
> too late. It takes about a year or two for new git versions to percolate
> out, with things like Debian-stable etc, so making git warn about
> suspicious-looking names is not necessarily going to help (and with
> scripting and importing from other SCM's, it may be wrong to warn in
> general).
Yeah..
> It's _fairly_ easy to set up a hook at commit-time to check for random
> thigns, but obviously if the problem is that people haven't configured
> their git setup, then "add a hook" is not going to work. In that sense,
> pull-time may be better, as a way to see it automatically after-the-fact.
>
> Doing a post-merge hook would catch it, and could be used to warn about
> the fact that you merged something odd.
Hmm, sounds like it might make sense to check for that in Stephen's
for-next tree then. Added Stephen to the loop, let's see if what he
thinks.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] omap fixes for 2.6.33-rc3
Date: Fri, 8 Jan 2010 14:50:23 -0800 [thread overview]
Message-ID: <20100108225023.GD2879@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001081430210.7821@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> [100108 14:38]:
>
>
> On Fri, 8 Jan 2010, Tony Lindgren wrote:
> >
> > $ git log --pretty=oneline --author=".(none)" --committer=".(none)" v2.6.33-rc1..
>
> Well, that will catch one particular common case of it, but..
>
> > Should we have some check like this in place for all pulls?
>
> .. it would probably make more sense to warn about it earlier in the
> chain, so that people with bad configurations can fix them. By the time
> somebody pulls, it's pretty late in the game.
>
> Sadly, git doesn't do any real sanity checking, and now it's pretty much
> too late. It takes about a year or two for new git versions to percolate
> out, with things like Debian-stable etc, so making git warn about
> suspicious-looking names is not necessarily going to help (and with
> scripting and importing from other SCM's, it may be wrong to warn in
> general).
Yeah..
> It's _fairly_ easy to set up a hook at commit-time to check for random
> thigns, but obviously if the problem is that people haven't configured
> their git setup, then "add a hook" is not going to work. In that sense,
> pull-time may be better, as a way to see it automatically after-the-fact.
>
> Doing a post-merge hook would catch it, and could be used to warn about
> the fact that you merged something odd.
Hmm, sounds like it might make sense to check for that in Stephen's
for-next tree then. Added Stephen to the loop, let's see if what he
thinks.
Regards,
Tony
next prev parent reply other threads:[~2010-01-08 22:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 18:09 [GIT PULL] omap fixes for 2.6.33-rc3 Tony Lindgren
2010-01-08 18:09 ` Tony Lindgren
2010-01-08 18:19 ` Linus Torvalds
2010-01-08 18:19 ` Linus Torvalds
2010-01-08 18:22 ` Tony Lindgren
2010-01-08 18:22 ` Tony Lindgren
2010-01-08 22:05 ` Paul Walmsley
2010-01-08 22:05 ` Paul Walmsley
2010-01-08 22:27 ` Tony Lindgren
2010-01-08 22:27 ` Tony Lindgren
2010-01-08 22:39 ` Linus Torvalds
2010-01-08 22:39 ` Linus Torvalds
2010-01-08 22:50 ` Tony Lindgren [this message]
2010-01-08 22:50 ` Tony Lindgren
2010-01-09 2:47 ` Stephen Rothwell
2010-01-09 2:47 ` Stephen Rothwell
2010-01-09 17:28 ` Tony Lindgren
2010-01-09 17:28 ` Tony Lindgren
2010-01-08 18:20 ` Tony Lindgren
2010-01-08 18:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108225023.GD2879@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.