All of lore.kernel.org
 help / color / mirror / Atom feed
* + kfifo-fix-kfifo_out_locked-race-bug.patch added to -mm tree
@ 2010-01-08 23:15 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-01-08 23:15 UTC (permalink / raw)
  To: mm-commits; +Cc: stefani, jhovold, zaitcev


The patch titled
     kfifo: fix kfifo_out_locked race bug
has been added to the -mm tree.  Its filename is
     kfifo-fix-kfifo_out_locked-race-bug.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: kfifo: fix kfifo_out_locked race bug
From: Stefani Seibold <stefani@seibold.net>

Fix a wrong optimization in include/linux/kfifo.h which could cause a race
in kfifo_out_locked.

Signed-off-by: Stefani Seibold <stefani@seibold.net>
Reported-by: Johan Hovold <jhovold@gmail.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/kfifo.h |    7 -------
 1 file changed, 7 deletions(-)

diff -puN include/linux/kfifo.h~kfifo-fix-kfifo_out_locked-race-bug include/linux/kfifo.h
--- a/include/linux/kfifo.h~kfifo-fix-kfifo_out_locked-race-bug
+++ a/include/linux/kfifo.h
@@ -228,13 +228,6 @@ static inline __must_check unsigned int 
 
 	ret = kfifo_out(fifo, to, n);
 
-	/*
-	 * optimization: if the FIFO is empty, set the indices to 0
-	 * so we don't wrap the next time
-	 */
-	if (kfifo_is_empty(fifo))
-		kfifo_reset(fifo);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-08 23:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-08 23:15 + kfifo-fix-kfifo_out_locked-race-bug.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.