From: Wu Fengguang <fengguang.wu@intel.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mmotm-2010-01-06-14-34] check high watermark after shrink zone
Date: Sun, 10 Jan 2010 22:25:49 +0800 [thread overview]
Message-ID: <20100110142549.GA14610@localhost> (raw)
In-Reply-To: <20100108141235.ef56b567.minchan.kim@barrios-desktop>
On Fri, Jan 08, 2010 at 02:12:35PM +0900, Minchan Kim wrote:
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.
> all_zone_ok makes kswapd retry not sleeping.
!all_zone_ok :)
> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaningul.
>
> This patch move the check after shrink zone.
This tends to make kswapd do less work in one invocation, with lower
priority. Looks at least not bad to me :) Thanks!
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mmotm-2010-01-06-14-34] check high watermark after shrink zone
Date: Sun, 10 Jan 2010 22:25:49 +0800 [thread overview]
Message-ID: <20100110142549.GA14610@localhost> (raw)
In-Reply-To: <20100108141235.ef56b567.minchan.kim@barrios-desktop>
On Fri, Jan 08, 2010 at 02:12:35PM +0900, Minchan Kim wrote:
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.
> all_zone_ok makes kswapd retry not sleeping.
!all_zone_ok :)
> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaningul.
>
> This patch move the check after shrink zone.
This tends to make kswapd do less work in one invocation, with lower
priority. Looks at least not bad to me :) Thanks!
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-10 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 5:12 [PATCH -mmotm-2010-01-06-14-34] check high watermark after shrink zone Minchan Kim
2010-01-08 5:12 ` Minchan Kim
2010-01-08 5:30 ` KOSAKI Motohiro
2010-01-08 5:30 ` KOSAKI Motohiro
2010-01-10 14:25 ` Wu Fengguang [this message]
2010-01-10 14:25 ` Wu Fengguang
2010-01-12 23:01 ` Andrew Morton
2010-01-12 23:01 ` Andrew Morton
2010-01-12 23:40 ` KOSAKI Motohiro
2010-01-12 23:40 ` KOSAKI Motohiro
2010-01-13 1:51 ` Minchan Kim
2010-01-13 1:51 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110142549.GA14610@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.