From: Christoph Egger <Christoph.Egger@amd.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: build fixes
Date: Tue, 12 Jan 2010 18:31:24 +0100 [thread overview]
Message-ID: <201001121831.25212.Christoph.Egger@amd.com> (raw)
In-Reply-To: <19276.44985.149108.19729@mariner.uk.xensource.com>
On Tuesday 12 January 2010 18:22:01 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] build fixes"):
> > Attached patch fixes Xen build on NetBSD.
>
> Nack.
?
> > +#include <sys/wait.h> /* for pid_t */
>
> This is fine but should read:
> #include <sys/wait.h>
> as there is no point putting
> /* for somethingorother */
> after every #include.
>
> > - if (!isdigit(p[i])) {
> > + if (!isdigit((uint8_t)p[i])) {
>
> This is correct on all platforms. But it should be fixed by some more
> general approach, as it's needed for almost every call to a ctype
> macro.
Any suggestions ?
> > - seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET);
> > + seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);
>
> This is just wrong. It will break on >2G files.
No, lseek64() doesn't exist. lseek() works fine on files > 2GB on NetBSD.
I think, on Linux you need to define LARGEFILES or something like that.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-01-12 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 11:58 build fixes Christoph Egger
2010-01-12 17:22 ` Ian Jackson
2010-01-12 17:31 ` Christoph Egger [this message]
2010-01-12 17:38 ` Keir Fraser
2010-01-12 17:42 ` Patrick Colp
2010-01-12 17:47 ` Christoph Egger
2010-01-12 18:44 ` Keir Fraser
2010-01-12 18:00 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001121831.25212.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.