From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Németh Márton" <nm127@freemail.hu>
Cc: Greg KH <greg@kroah.com>, Julia Lawall <julia@diku.dk>,
Alan Stern <stern@rowland.harvard.edu>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
David Vrabel <david.vrabel@csr.com>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
cocci@diku.dk
Subject: Re: Changelog quality
Date: Thu, 14 Jan 2010 00:26:30 -0800 [thread overview]
Message-ID: <201001140026.31195.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <4B4EAA73.5060103@freemail.hu>
On Wednesday 13 January 2010 09:24:03 pm Németh Márton wrote:
> Greg KH wrote:
> > On Wed, Jan 13, 2010 at 01:04:52PM -0500, Alan Stern wrote:
> >> On Wed, 13 Jan 2010, Greg KH wrote:
> >>>> It would be nice if there was a way to link automatically a git commit
> >>>> to an archived copy of the email message in which it was originally
> >>>> submitted.
> >>>
> >>> Ingo has been doing this on some patches by putting a message-id field
> >>> in the signed-off-by area showing what lkml message a patch came from.
> >>>
> >>> See git commit id 6432e734c99ed685e3cad72f7dcae4c65008fcab in Linus's
> >>> tree as an example of this.
> >>>
> >>> I have no objection if people want to do this for any patches going
> >>> through my tree as well.
> >>
> >> If it has to be included manually by the patch submitter then it isn't
> >> automatic. Not to mention that the submitter would need to know the
> >> email's message-id before the email message was sent!
> >>
> >> Something like this should belong in a maintainer's script.
> >
> > Yeah, that would get messy, as usually a patch happens in a different
> > thread than the original problem occurs, so it would take a lot more
> > work on my part to try to match things up. If I notice it, I will try
> > to in the future.
>
> What about introducing a new tag like 'SmPL-Used:'? The used SmPL could
> be placed somewhere in the web. This would require only one line in
> the changelog: e.g.:
>
> SmPL-Used: http://coccinelle.lip6.fr/sp.php#usb_submit_urb
>
> Usually when an SmPL is created in a general manner it can easily
> match 100+ places. These can be combined in groups which for example
> belong to one maintainter. That was what I did with adding const to
> the different ID tables.
>
Hm, I usually am only marginally interested in how patch was generated,
you may have used a script to 'ed' to generate it for all I care.
I do care however about rationale behind the change and that is what
should go into changelogs.
So if these scripts could go below the "---" separator I'm all for it.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-01-14 8:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 7:49 [PATCH] uwb: make USB device id constant Németh Márton
2010-01-12 16:10 ` David Vrabel
2010-01-12 16:57 ` Németh Márton
2010-01-13 14:59 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Stefan Richter
2010-01-13 15:38 ` Julia Lawall
2010-01-13 17:06 ` Changelog quality Stefan Richter
2010-01-13 17:29 ` Alan Stern
2010-01-13 17:44 ` Greg KH
2010-01-13 18:04 ` Alan Stern
2010-01-13 19:52 ` Greg KH
2010-01-14 5:24 ` Németh Márton
2010-01-14 6:05 ` Julia Lawall
2010-01-14 8:07 ` Stefan Richter
2010-01-14 8:26 ` Dmitry Torokhov [this message]
2010-01-13 19:19 ` Geert Uytterhoeven
2010-01-13 17:49 ` Bartlomiej Zolnierkiewicz
2010-01-13 18:22 ` Stefan Richter
2010-01-15 1:03 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Andy Isaacson
2010-01-15 8:13 ` Stefan Richter
2010-01-15 8:24 ` Changelog quality David Miller
2010-01-15 8:50 ` Stefan Richter
2010-01-15 8:54 ` David Miller
2010-01-15 9:17 ` Stefan Richter
2010-01-15 9:22 ` David Miller
2010-01-15 9:43 ` Julia Lawall
2010-01-15 9:49 ` Pekka Enberg
2010-01-15 10:05 ` Julia Lawall
2010-01-15 11:08 ` Mark Brown
2010-01-15 12:06 ` Julia Lawall
2010-01-15 12:44 ` Pekka Enberg
2010-01-15 13:10 ` Julia Lawall
2010-01-15 12:45 ` Stefan Richter
2010-01-15 12:52 ` Pekka Enberg
2010-01-15 13:39 ` Mark Brown
2010-01-15 16:49 ` SmPL scripts into build environment? (was: Changelog quality) Németh Márton
2010-01-18 10:58 ` SmPL scripts into build environment? Michal Marek
2010-01-18 11:22 ` Julia Lawall
2010-01-15 13:28 ` Changelog quality Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001140026.31195.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=cocci@diku.dk \
--cc=david.vrabel@csr.com \
--cc=greg@kroah.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=stefanr@s5r6.in-berlin.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.