From: "Németh Márton" <nm127@freemail.hu>
To: David Vrabel <david.vrabel@csr.com>
Cc: linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <julia@diku.dk>,
cocci@diku.dk
Subject: Re: [PATCH] uwb: make USB device id constant
Date: Tue, 12 Jan 2010 17:57:57 +0100 [thread overview]
Message-ID: <4B4CAA15.4030200@freemail.hu> (raw)
In-Reply-To: <4B4C9ED9.60905@csr.com>
David Vrabel írta:
> Németh Márton wrote:
>> From: Márton Németh <nm127@freemail.hu>
>>
>> The id_table field of the struct usb_device_id is constant in <linux/usb.h>
>> so it is worth to make the initialization data also constant.
>
> Thanks.
>
>> The semantic match that finds this kind of pattern is as follows:
>> (http://coccinelle.lip6.fr/)
>
> Can you please not include this as part of the changelog in future? You
> may include it after the '---' if you wish.
It is common for patches generated by spatch that they include the SmPL
which was used to generate the patch.
See http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git&a=search&h=HEAD&st=commit&s=%3Csmpl%3E
But you can leave it out, if you wish.
Regards,
Márton Németh
next prev parent reply other threads:[~2010-01-12 16:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 7:49 [PATCH] uwb: make USB device id constant Németh Márton
2010-01-12 16:10 ` David Vrabel
2010-01-12 16:57 ` Németh Márton [this message]
2010-01-13 14:59 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Stefan Richter
2010-01-13 15:38 ` Julia Lawall
2010-01-13 17:06 ` Changelog quality Stefan Richter
2010-01-13 17:29 ` Alan Stern
2010-01-13 17:44 ` Greg KH
2010-01-13 18:04 ` Alan Stern
2010-01-13 19:52 ` Greg KH
2010-01-14 5:24 ` Németh Márton
2010-01-14 6:05 ` Julia Lawall
2010-01-14 8:07 ` Stefan Richter
2010-01-14 8:26 ` Dmitry Torokhov
2010-01-13 19:19 ` Geert Uytterhoeven
2010-01-13 17:49 ` Bartlomiej Zolnierkiewicz
2010-01-13 18:22 ` Stefan Richter
2010-01-15 1:03 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Andy Isaacson
2010-01-15 8:13 ` Stefan Richter
2010-01-15 8:24 ` Changelog quality David Miller
2010-01-15 8:50 ` Stefan Richter
2010-01-15 8:54 ` David Miller
2010-01-15 9:17 ` Stefan Richter
2010-01-15 9:22 ` David Miller
2010-01-15 9:43 ` Julia Lawall
2010-01-15 9:49 ` Pekka Enberg
2010-01-15 10:05 ` Julia Lawall
2010-01-15 11:08 ` Mark Brown
2010-01-15 12:06 ` Julia Lawall
2010-01-15 12:44 ` Pekka Enberg
2010-01-15 13:10 ` Julia Lawall
2010-01-15 12:45 ` Stefan Richter
2010-01-15 12:52 ` Pekka Enberg
2010-01-15 13:39 ` Mark Brown
2010-01-15 16:49 ` SmPL scripts into build environment? (was: Changelog quality) Németh Márton
2010-01-18 10:58 ` SmPL scripts into build environment? Michal Marek
2010-01-18 11:22 ` Julia Lawall
2010-01-15 13:28 ` Changelog quality Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4CAA15.4030200@freemail.hu \
--to=nm127@freemail.hu \
--cc=cocci@diku.dk \
--cc=david.vrabel@csr.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.