From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Wu, Fengguang" <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>, Nick Piggin <npiggin@suse.de>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/8] vfs: fix too big f_pos handling
Date: Thu, 14 Jan 2010 05:13:08 +0000 [thread overview]
Message-ID: <20100114051308.GA14616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100113140955.GA18593@localhost>
On Wed, Jan 13, 2010 at 10:09:56PM +0800, Wu, Fengguang wrote:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Now, rw_verify_area() checsk f_pos is negative or not. And if
> negative, returns -EINVAL.
>
> But, some special files as /dev/(k)mem and /proc/<pid>/mem etc..
> has negative offsets. And we can't do any access via read/write
> to the file(device).
>
> This patch introduce a flag S_VERYBIG and allow negative file
> offsets.
Ehh... FMODE_NEG_OFFSET in file->f_mode, perhaps?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Wu, Fengguang" <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>, Nick Piggin <npiggin@suse.de>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/8] vfs: fix too big f_pos handling
Date: Thu, 14 Jan 2010 05:13:08 +0000 [thread overview]
Message-ID: <20100114051308.GA14616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100113140955.GA18593@localhost>
On Wed, Jan 13, 2010 at 10:09:56PM +0800, Wu, Fengguang wrote:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Now, rw_verify_area() checsk f_pos is negative or not. And if
> negative, returns -EINVAL.
>
> But, some special files as /dev/(k)mem and /proc/<pid>/mem etc..
> has negative offsets. And we can't do any access via read/write
> to the file(device).
>
> This patch introduce a flag S_VERYBIG and allow negative file
> offsets.
Ehh... FMODE_NEG_OFFSET in file->f_mode, perhaps?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-14 5:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 14:09 [PATCH 1/8] vfs: fix too big f_pos handling Wu, Fengguang
2010-01-13 14:09 ` Wu, Fengguang
2010-01-14 5:13 ` Al Viro [this message]
2010-01-14 5:13 ` Al Viro
2010-01-14 5:42 ` KAMEZAWA Hiroyuki
2010-01-14 5:42 ` KAMEZAWA Hiroyuki
2010-01-14 13:56 ` Wu Fengguang
2010-01-14 13:56 ` Wu Fengguang
-- strict thread matches above, loose matches on Subject: below --
2010-01-13 13:53 [PATCH 0/8] devmem/kmem/kcore fixes, cleanups and hwpoison checks Wu Fengguang
2010-01-13 13:53 ` [PATCH 1/8] vfs: fix too big f_pos handling Wu Fengguang
2010-01-13 13:53 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114051308.GA14616@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.