* [lm-sensors] [patch] hwmon/amc6821: double unlock bug
@ 2010-01-14 10:30 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-01-14 10:30 UTC (permalink / raw)
To: Tomaz Mertelj; +Cc: lm-sensors, linux-kernel
The mutex gets unlocked after we goto EXIT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/hwmon/amc6821.c 2010-01-14 13:22:23.000000000 +0300
+++ devel/drivers/hwmon/amc6821.c 2010-01-14 13:22:30.000000000 +0300
@@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
data->fan1_div = 4;
break;
default:
- mutex_unlock(&data->update_lock);
count = -EINVAL;
goto EXIT;
}
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch] hwmon/amc6821: double unlock bug
@ 2010-01-14 10:30 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-01-14 10:30 UTC (permalink / raw)
To: Tomaz Mertelj; +Cc: lm-sensors, linux-kernel
The mutex gets unlocked after we goto EXIT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/hwmon/amc6821.c 2010-01-14 13:22:23.000000000 +0300
+++ devel/drivers/hwmon/amc6821.c 2010-01-14 13:22:30.000000000 +0300
@@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
data->fan1_div = 4;
break;
default:
- mutex_unlock(&data->update_lock);
count = -EINVAL;
goto EXIT;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [patch] hwmon/amc6821: double unlock bug
2010-01-14 10:30 ` Dan Carpenter
@ 2010-01-14 11:49 ` Jean Delvare
-1 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2010-01-14 11:49 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Tomaz Mertelj, linux-kernel, lm-sensors
On Thu, 14 Jan 2010 13:30:20 +0300, Dan Carpenter wrote:
> The mutex gets unlocked after we goto EXIT.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> --- orig/drivers/hwmon/amc6821.c 2010-01-14 13:22:23.000000000 +0300
> +++ devel/drivers/hwmon/amc6821.c 2010-01-14 13:22:30.000000000 +0300
> @@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
> data->fan1_div = 4;
> break;
> default:
> - mutex_unlock(&data->update_lock);
> count = -EINVAL;
> goto EXIT;
> }
Good catch. Applied, thanks.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [patch] hwmon/amc6821: double unlock bug
@ 2010-01-14 11:49 ` Jean Delvare
0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2010-01-14 11:49 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Tomaz Mertelj, linux-kernel, lm-sensors
On Thu, 14 Jan 2010 13:30:20 +0300, Dan Carpenter wrote:
> The mutex gets unlocked after we goto EXIT.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> --- orig/drivers/hwmon/amc6821.c 2010-01-14 13:22:23.000000000 +0300
> +++ devel/drivers/hwmon/amc6821.c 2010-01-14 13:22:30.000000000 +0300
> @@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
> data->fan1_div = 4;
> break;
> default:
> - mutex_unlock(&data->update_lock);
> count = -EINVAL;
> goto EXIT;
> }
Good catch. Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-14 11:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 10:30 [lm-sensors] [patch] hwmon/amc6821: double unlock bug Dan Carpenter
2010-01-14 10:30 ` Dan Carpenter
2010-01-14 11:49 ` [lm-sensors] " Jean Delvare
2010-01-14 11:49 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.