From: Andrew Morton <akpm@linux-foundation.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Zheng, Shaohui" <shaohui.zheng@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] memory-hotplug: add 0x prefix to HEX block_size_bytes
Date: Thu, 14 Jan 2010 15:29:07 -0800 [thread overview]
Message-ID: <20100114152907.953f8d3e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100114115956.GA2512@localhost>
On Thu, 14 Jan 2010 19:59:56 +0800
Wu Fengguang <fengguang.wu@intel.com> wrote:
> CC: Andi Kleen <andi@firstfloor.org>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> drivers/base/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-mm.orig/drivers/base/memory.c 2010-01-14 19:55:40.000000000 +0800
> +++ linux-mm/drivers/base/memory.c 2010-01-14 19:55:47.000000000 +0800
> @@ -311,7 +311,7 @@ static SYSDEV_ATTR(removable, 0444, show
> static ssize_t
> print_block_size(struct class *class, char *buf)
> {
> - return sprintf(buf, "%lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
> + return sprintf(buf, "%#lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
> }
>
> static CLASS_ATTR(block_size_bytes, 0444, print_block_size, NULL);
crappy changelog!
Why this change? Perhaps showing us an example of the before-and-after
output would help us see what is being fixed, and why.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-14 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 11:59 [PATCH] memory-hotplug: add 0x prefix to HEX block_size_bytes Wu Fengguang
2010-01-14 12:04 ` [PATCH] sysdev: fix prototype for memory_sysdev_class show/store functions Wu Fengguang
2010-01-14 12:32 ` Andi Kleen
2010-01-18 13:07 ` Wu Fengguang
2010-01-20 2:23 ` Greg KH
2010-01-14 23:29 ` Andrew Morton [this message]
2010-01-18 13:44 ` [PATCH] memory-hotplug: add 0x prefix to HEX block_size_bytes Wu Fengguang
2010-01-19 0:38 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114152907.953f8d3e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=shaohui.zheng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.