Re: [PATCH] memory-hotplug: add 0x prefix to HEX block_size_bytes

[Wu Fengguang <fengguang.wu@intel.com>]

> > -	return sprintf(buf, "%lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
> > +	return sprintf(buf, "%#lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
 
> crappy changelog!
> 
> Why this change?  Perhaps showing us an example of the before-and-after
> output would help us see what is being fixed, and why.

Sorry for being late (some SMTP problem).

                # cat /sys/devices/system/memory/block_size_bytes
before patch:   8000000
after  patch:   0x8000000

This is a good fix because someone is very likely to mistake 8000000
as a decimal number. 0x8000000 looks much better.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>