From: Paul Mundt <lethal@linux-sh.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-sh@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au,
x86@kernel.org, mingo@redhat.com, tglx@linutronix.de,
monstr@monstr.eu, hpa@zytor.com
Subject: Re: [PATCH] cpuinfo_op: consolidate extern declaration
Date: Thu, 14 Jan 2010 23:46:25 +0000 [thread overview]
Message-ID: <20100114234625.GD25018@linux-sh.org> (raw)
In-Reply-To: <201001141158.09795.hartleys@visionengravers.com>
On Thu, Jan 14, 2010 at 11:58:09AM -0700, H Hartley Sweeten wrote:
> cpuinfo_op: consolidate extern declaration
>
> All the architectures supported by the kernel also support
> /proc/cpuinfo. Only a couple actually declare the seq_operations
> as extern. All the others will produce a sparse warning like:
>
> warning: symbol 'cpuinfo_op' was not declared. Should it be static?
>
> Fix all the warnings and consolidate the declaration by putting it
> in <linux/seq_file.h>.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
>
I guess we know from this list which architectures run sparse ;-)
Acked-by: Paul Mundt <lethal@linux-sh.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-sh@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au,
x86@kernel.org, mingo@redhat.com, tglx@linutronix.de,
monstr@monstr.eu, hpa@zytor.com
Subject: Re: [PATCH] cpuinfo_op: consolidate extern declaration
Date: Fri, 15 Jan 2010 08:46:25 +0900 [thread overview]
Message-ID: <20100114234625.GD25018@linux-sh.org> (raw)
In-Reply-To: <201001141158.09795.hartleys@visionengravers.com>
On Thu, Jan 14, 2010 at 11:58:09AM -0700, H Hartley Sweeten wrote:
> cpuinfo_op: consolidate extern declaration
>
> All the architectures supported by the kernel also support
> /proc/cpuinfo. Only a couple actually declare the seq_operations
> as extern. All the others will produce a sparse warning like:
>
> warning: symbol 'cpuinfo_op' was not declared. Should it be static?
>
> Fix all the warnings and consolidate the declaration by putting it
> in <linux/seq_file.h>.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
>
I guess we know from this list which architectures run sparse ;-)
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2010-01-14 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 18:58 [PATCH] cpuinfo_op: consolidate extern declaration H Hartley Sweeten
2010-01-14 18:58 ` H Hartley Sweeten
2010-01-14 23:46 ` Paul Mundt [this message]
2010-01-14 23:46 ` Paul Mundt
2010-01-15 8:06 ` Michal Simek
2010-01-15 8:06 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114234625.GD25018@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=hartleys@visionengravers.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.