All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Emese Revfy <re.emese@gmail.com>
Cc: linux-kernel@vger.kernel.org, teigland@redhat.com,
	Matt_Domsch@dell.com, maciej.sosnowski@intel.com,
	hjk@linutronix.de, Pekka Enberg <penberg@cs.helsinki.fi>,
	jens.axboe@oracle.com, shemminger@vyatta.com,
	akpm@linux-foundation.org, davem@davemloft.net,
	torvalds@linux-foundation.org, netdev@vger.kernel.org,
	Greg KH <gregkh@suse.de>
Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4
Date: Sun, 17 Jan 2010 18:25:37 +0000	[thread overview]
Message-ID: <20100117182537.GQ19799@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4B5338D6.2050209@gmail.com>

On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:

> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> Acked-by: David Teigland <teigland@redhat.com>
> Acked-by: Matt Domsch <Matt_Domsch@dell.com>
> Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> Acked-by: Hans J. Koch <hjk@linutronix.de>
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> Acked-by: Jens Axboe <jens.axboe@oracle.com>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>

NACKed-by: Al Viro <viro@zeniv.linux.org.uk>

Same reason.

> -        ssize_t (*show)(struct kobject *, struct attribute *, char *);
> -        ssize_t (*store)(struct kobject *, struct attribute *, const char *);
> +        ssize_t (* const show)(struct kobject *, struct attribute *, char *);
> +        ssize_t (* const store)(struct kobject *, struct attribute *, const char *);

  reply	other threads:[~2010-01-17 18:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-17 16:20 [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4 Emese Revfy
2010-01-17 18:25 ` Al Viro [this message]
2010-01-17 18:29   ` Al Viro
2010-01-17 20:15     ` Emese Revfy
2010-01-17 20:15   ` Emese Revfy
2010-01-18  1:35     ` Greg KH
2010-01-19  1:58       ` Emese Revfy
  -- strict thread matches above, loose matches on Subject: below --
2010-01-17 18:23 Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100117182537.GQ19799@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=Matt_Domsch@dell.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.sosnowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=re.emese@gmail.com \
    --cc=shemminger@vyatta.com \
    --cc=teigland@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.