Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4

[Greg KH <gregkh@suse.de>]

On Sun, Jan 17, 2010 at 09:15:49PM +0100, Emese Revfy wrote:
> Al Viro wrote:
> > On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:
> > 
> >> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> >> Acked-by: David Teigland <teigland@redhat.com>
> >> Acked-by: Matt Domsch <Matt_Domsch@dell.com>
> >> Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> >> Acked-by: Hans J. Koch <hjk@linutronix.de>
> >> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> >> Acked-by: Jens Axboe <jens.axboe@oracle.com>
> >> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
> > 
> > NACKed-by: Al Viro <viro@zeniv.linux.org.uk>
> > 
> > Same reason.
> > 
> >> -        ssize_t (*show)(struct kobject *, struct attribute *, char *);
> >> -        ssize_t (*store)(struct kobject *, struct attribute *, const char *);
> >> +        ssize_t (* const show)(struct kobject *, struct attribute *, char *);
> >> +        ssize_t (* const store)(struct kobject *, struct attribute *, const char *);
> > 
> 
> Ok, I removed the field constification, here's the updated patch:

Please resend with proper changelog and other information so that it
could be applied.

thanks,

greg k-h