All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Jeff Dike <jdike@addtoit.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] oom: OOM-Killed process don't invoke pagefault-oom
Date: Mon, 18 Jan 2010 18:29:46 +1100	[thread overview]
Message-ID: <20100118072946.GA10052@laptop> (raw)
In-Reply-To: <20100115085146.6EC0.A69D9226@jp.fujitsu.com>

On Fri, Jan 15, 2010 at 03:21:40PM +0900, KOSAKI Motohiro wrote:
> > Hi,
> > 
> > I don't think this should be required, because the oom killer does not
> > kill a new task if there is already one in memdie state.
> > 
> > If you have any further tweaks to the heuristic (such as a fatal signal
> > pending), then it should probably go in select_bad_process() or
> > somewhere like that.
> 
> I see, I misunderstood. very thanks.

Well, it *might* be a good idea to check for fatal signal pending
similar your patch. Because I think there could be large latency between
the signal and the task moving to exit state if the process is waiting
uninterruptible in the kernel for a while.

But if you do it in select_bad_process() then it would work for all
classes of oom kill.

Thanks,
Nick


WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Jeff Dike <jdike@addtoit.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] oom: OOM-Killed process don't invoke pagefault-oom
Date: Mon, 18 Jan 2010 18:29:46 +1100	[thread overview]
Message-ID: <20100118072946.GA10052@laptop> (raw)
In-Reply-To: <20100115085146.6EC0.A69D9226@jp.fujitsu.com>

On Fri, Jan 15, 2010 at 03:21:40PM +0900, KOSAKI Motohiro wrote:
> > Hi,
> > 
> > I don't think this should be required, because the oom killer does not
> > kill a new task if there is already one in memdie state.
> > 
> > If you have any further tweaks to the heuristic (such as a fatal signal
> > pending), then it should probably go in select_bad_process() or
> > somewhere like that.
> 
> I see, I misunderstood. very thanks.

Well, it *might* be a good idea to check for fatal signal pending
similar your patch. Because I think there could be large latency between
the signal and the task moving to exit state if the process is waiting
uninterruptible in the kernel for a while.

But if you do it in select_bad_process() then it would work for all
classes of oom kill.

Thanks,
Nick

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-01-18  7:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 10:22 [PATCH] oom: OOM-Killed process don't invoke pagefault-oom KOSAKI Motohiro
2010-01-14 10:22 ` KOSAKI Motohiro
2010-01-14 13:02 ` Nick Piggin
2010-01-14 13:02   ` Nick Piggin
2010-01-15  6:21   ` KOSAKI Motohiro
2010-01-15  6:21     ` KOSAKI Motohiro
2010-01-18  7:29     ` Nick Piggin [this message]
2010-01-18  7:29       ` Nick Piggin
2010-01-18  8:21       ` KOSAKI Motohiro
2010-01-18  8:21         ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100118072946.GA10052@laptop \
    --to=npiggin@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=jdike@addtoit.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.