From: Jean Delvare <khali@linux-fr.org>
To: Joe Perches <joe@perches.com>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>,
"Petr Vandrovec" <vandrove@vc.cvut.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Krzysztof Helt" <krzysztof.h1@wp.pl>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c
Date: Mon, 18 Jan 2010 21:11:46 +0000 [thread overview]
Message-ID: <20100118221146.5d81fc0e@hyperion.delvare> (raw)
In-Reply-To: <1263844770.26846.134.camel@Joe-Laptop.home>
On Mon, 18 Jan 2010 11:59:30 -0800, Joe Perches wrote:
> On Mon, 2010-01-18 at 20:27 +0100, Peter Hüwe wrote:
> > the reason behind this change was that spaces and tabs were mixed for
> > indention.
>
> Checkpatch isn't gospel and isn't always right.
>
> There should be room for taste preference here
> and I think whatever Petr V's is should prevail.
>
> > How about this indention? Would this be better?
>
> Well, I don't think so, but others will have different opinions.
I don't see it as an improvement either. Was checkpatch.pl really
complaining about the alignment? Tabs followed by less than 8 spaces is
acceptable and fairly common AFAICT, I can't remember the script
yelling at me when I do it.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Joe Perches <joe@perches.com>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>,
"Petr Vandrovec" <vandrove@vc.cvut.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Krzysztof Helt" <krzysztof.h1@wp.pl>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c
Date: Mon, 18 Jan 2010 21:11:46 +0000 [thread overview]
Message-ID: <20100118221146.5d81fc0e@hyperion.delvare> (raw)
In-Reply-To: <1263844770.26846.134.camel@Joe-Laptop.home>
On Mon, 18 Jan 2010 11:59:30 -0800, Joe Perches wrote:
> On Mon, 2010-01-18 at 20:27 +0100, Peter Hüwe wrote:
> > the reason behind this change was that spaces and tabs were mixed for
> > indention.
>
> Checkpatch isn't gospel and isn't always right.
>
> There should be room for taste preference here
> and I think whatever Petr V's is should prevail.
>
> > How about this indention? Would this be better?
>
> Well, I don't think so, but others will have different opinions.
I don't see it as an improvement either. Was checkpatch.pl really
complaining about the alignment? Tabs followed by less than 8 spaces is
acceptable and fairly common AFAICT, I can't remember the script
yelling at me when I do it.
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Joe Perches <joe@perches.com>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>,
"Petr Vandrovec" <vandrove@vc.cvut.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Krzysztof Helt" <krzysztof.h1@wp.pl>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c
Date: Mon, 18 Jan 2010 22:11:46 +0100 [thread overview]
Message-ID: <20100118221146.5d81fc0e@hyperion.delvare> (raw)
In-Reply-To: <1263844770.26846.134.camel@Joe-Laptop.home>
On Mon, 18 Jan 2010 11:59:30 -0800, Joe Perches wrote:
> On Mon, 2010-01-18 at 20:27 +0100, Peter Hüwe wrote:
> > the reason behind this change was that spaces and tabs were mixed for
> > indention.
>
> Checkpatch isn't gospel and isn't always right.
>
> There should be room for taste preference here
> and I think whatever Petr V's is should prevail.
>
> > How about this indention? Would this be better?
>
> Well, I don't think so, but others will have different opinions.
I don't see it as an improvement either. Was checkpatch.pl really
complaining about the alignment? Tabs followed by less than 8 spaces is
acceptable and fairly common AFAICT, I can't remember the script
yelling at me when I do it.
--
Jean Delvare
next prev parent reply other threads:[~2010-01-18 21:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 18:34 [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c Peter Hüwe
2010-01-18 18:34 ` Peter Hüwe
2010-01-18 19:17 ` Joe Perches
2010-01-18 19:17 ` Joe Perches
2010-01-18 19:17 ` Joe Perches
2010-01-18 19:27 ` Peter Hüwe
2010-01-18 19:27 ` Peter Hüwe
2010-01-18 19:27 ` Peter Hüwe
2010-01-18 19:55 ` [PATCH v2] " Peter Huewe
2010-01-18 19:55 ` Peter Huewe
2010-01-18 19:59 ` [PATCH] " Joe Perches
2010-01-18 19:59 ` Joe Perches
2010-01-18 19:59 ` Joe Perches
2010-01-18 21:11 ` Jean Delvare [this message]
2010-01-18 21:11 ` Jean Delvare
2010-01-18 21:11 ` Jean Delvare
2010-01-18 21:42 ` [PATCH v3] " Peter Hüwe
2010-01-18 21:42 ` Peter Hüwe
2010-01-19 9:39 ` [PATCH v3] video/matrox: Checkpatch cleanups for Jean Delvare
2010-01-19 9:39 ` [PATCH v3] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c Jean Delvare
2010-01-19 9:39 ` [PATCH v3] video/matrox: Checkpatch cleanups for Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118221146.5d81fc0e@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=PeterHuewe@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.