From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com
Subject: Re: [PATCH tip/core/rcu 8/9] idr: apply lockdep-based diagnostics to rcu_dereference() uses
Date: Mon, 18 Jan 2010 16:56:46 -0800 [thread overview]
Message-ID: <20100119005646.GA6196@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100118233604.GE29076@feather>
On Mon, Jan 18, 2010 at 03:36:04PM -0800, Josh Triplett wrote:
> On Thu, Jan 14, 2010 at 05:02:45PM -0800, Paul E. McKenney wrote:
> > From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > Because idr can be used with any of a number of locks or with any
> > flavor of RCU, just disable the lockdep-based diagnostics. If idr
> > needs diagnostics, the check expression will need to be passed into
> > the relevant idr primitives as an additional argument.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> The subject line of this patch seems wrong. Like the preceding patches
> for radix tree and list operations, this *disables* the checking by
> using _raw.
It does indeed use _raw. If we start having enough issues with these
interfaces, this will need to change. At the moment, the obvious change
is to provide multiple interfaces as was done for rcu_dereference().
For example, idr_find(), idr_find_bh(), idr_find_sched(), idr_find_srcu(),
idr_find_rcu(), and idr_find_check().
Probably only a few of these are actually in use, but even so, I decided
to see how rcu_dereference() turned out before pushing up to the
higher-level APIs. My guess would be that the list APIs would be most
pressing, but we will see. ;-)
Thanx, Paul
next prev parent reply other threads:[~2010-01-19 0:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 1:01 [PATCH tip/core/rcu 0/9] rcu: v3 add lockdep-based diagnostics to rcu_dereference() Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 1/9] rcu: introduce lockdep-based checking to RCU read-side primitives Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 2/9] rcu: add lockdep-enabled variants of rcu_dereference() Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 3/9] rcu: disable lockdep checking in RCU list-traversal primitives Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 4/9] net: add checking to rcu_dereference() primitives Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 5/9] sched: use lockdep-based checking on rcu_dereference() Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 6/9] vfs: apply lockdep-based checking to rcu_dereference() uses Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 7/9] radix-tree: disable RCU lockdep checking in radix tree Paul E. McKenney
2010-01-15 1:02 ` [PATCH tip/core/rcu 8/9] idr: apply lockdep-based diagnostics to rcu_dereference() uses Paul E. McKenney
2010-01-18 23:36 ` Josh Triplett
2010-01-19 0:56 ` Paul E. McKenney [this message]
2010-01-15 1:02 ` [PATCH tip/core/rcu 9/9] rcu: documentation update for CONFIG_PROVE_RCU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119005646.GA6196@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.