* [PATCH] ASoC: fix compile breakage - add a missing header include
@ 2010-01-19 7:39 Guennadi Liakhovetski
2010-01-19 7:49 ` Takashi Iwai
2010-01-19 12:36 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2010-01-19 7:39 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
It might well have been reported and / or fixed in some trees, sorry for
the noise, if that's the case.
include/sound/soc-dai.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
index ca24e7f..061f16d 100644
--- a/include/sound/soc-dai.h
+++ b/include/sound/soc-dai.h
@@ -16,6 +16,8 @@
#include <linux/list.h>
+#include <sound/soc.h>
+
struct snd_pcm_substream;
/*
--
1.6.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: fix compile breakage - add a missing header include
2010-01-19 7:39 [PATCH] ASoC: fix compile breakage - add a missing header include Guennadi Liakhovetski
@ 2010-01-19 7:49 ` Takashi Iwai
2010-01-19 7:59 ` Guennadi Liakhovetski
2010-01-19 9:59 ` Mark Brown
2010-01-19 12:36 ` Mark Brown
1 sibling, 2 replies; 6+ messages in thread
From: Takashi Iwai @ 2010-01-19 7:49 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: alsa-devel, Mark Brown
At Tue, 19 Jan 2010 08:39:05 +0100 (CET),
Guennadi Liakhovetski wrote:
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> It might well have been reported and / or fixed in some trees, sorry for
> the noise, if that's the case.
The addition is OK, but could you give compile error messages?
I'm asking it because no error happened in my build tests.
thanks,
Takashi
>
> include/sound/soc-dai.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
> index ca24e7f..061f16d 100644
> --- a/include/sound/soc-dai.h
> +++ b/include/sound/soc-dai.h
> @@ -16,6 +16,8 @@
>
> #include <linux/list.h>
>
> +#include <sound/soc.h>
> +
> struct snd_pcm_substream;
>
> /*
> --
> 1.6.2.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: fix compile breakage - add a missing header include
2010-01-19 7:49 ` Takashi Iwai
@ 2010-01-19 7:59 ` Guennadi Liakhovetski
2010-01-19 9:59 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2010-01-19 7:59 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Mark Brown
On Tue, 19 Jan 2010, Takashi Iwai wrote:
> At Tue, 19 Jan 2010 08:39:05 +0100 (CET),
> Guennadi Liakhovetski wrote:
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> >
> > It might well have been reported and / or fixed in some trees, sorry for
> > the noise, if that's the case.
>
> The addition is OK, but could you give compile error messages?
> I'm asking it because no error happened in my build tests.
Sure:
In file included from sound/soc/sh/siu_pcm.c:33:
include/sound/soc-dai.h:211: error: field 'capture' has incomplete type
include/sound/soc-dai.h:212: error: field 'playback' has incomplete type
sound/soc/sh/siu_pcm.c:710: error: variable 'siu_platform' has initializer but incomplete type
sound/soc/sh/siu_pcm.c:711: error: unknown field 'name' specified in initializer
sound/soc/sh/siu_pcm.c:711: warning: excess elements in struct initializer
sound/soc/sh/siu_pcm.c:711: warning: (near initialization for 'siu_platform')
sound/soc/sh/siu_pcm.c:712: error: unknown field 'pcm_ops' specified in initializer
sound/soc/sh/siu_pcm.c:712: warning: excess elements in struct initializer
sound/soc/sh/siu_pcm.c:712: warning: (near initialization for 'siu_platform')
sound/soc/sh/siu_pcm.c:713: error: unknown field 'pcm_new' specified in initializer
sound/soc/sh/siu_pcm.c:713: warning: excess elements in struct initializer
sound/soc/sh/siu_pcm.c:713: warning: (near initialization for 'siu_platform')
sound/soc/sh/siu_pcm.c:714: error: unknown field 'pcm_free' specified in initializer
sound/soc/sh/siu_pcm.c:714: warning: excess elements in struct initializer
sound/soc/sh/siu_pcm.c:714: warning: (near initialization for 'siu_platform')
make[3]: *** [sound/soc/sh/siu_pcm.o] Error 1
make[2]: *** [sound/soc/sh] Error 2
make[2]: *** Waiting for unfinished jobs....
Thanks
Guennadi
>
>
> thanks,
>
> Takashi
>
> >
> > include/sound/soc-dai.h | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
> > index ca24e7f..061f16d 100644
> > --- a/include/sound/soc-dai.h
> > +++ b/include/sound/soc-dai.h
> > @@ -16,6 +16,8 @@
> >
> > #include <linux/list.h>
> >
> > +#include <sound/soc.h>
> > +
> > struct snd_pcm_substream;
> >
> > /*
> > --
> > 1.6.2.4
> >
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: fix compile breakage - add a missing header include
2010-01-19 7:49 ` Takashi Iwai
2010-01-19 7:59 ` Guennadi Liakhovetski
@ 2010-01-19 9:59 ` Mark Brown
2010-01-19 10:08 ` Guennadi Liakhovetski
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2010-01-19 9:59 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Guennadi Liakhovetski
On Tue, Jan 19, 2010 at 08:49:00AM +0100, Takashi Iwai wrote:
> The addition is OK, but could you give compile error messages?
> I'm asking it because no error happened in my build tests.
Ditto, and please also remember to CC maintainers on patches.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: fix compile breakage - add a missing header include
2010-01-19 9:59 ` Mark Brown
@ 2010-01-19 10:08 ` Guennadi Liakhovetski
0 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2010-01-19 10:08 UTC (permalink / raw)
To: Mark Brown; +Cc: Takashi Iwai, alsa-devel
On Tue, 19 Jan 2010, Mark Brown wrote:
> On Tue, Jan 19, 2010 at 08:49:00AM +0100, Takashi Iwai wrote:
>
> > The addition is OK, but could you give compile error messages?
> > I'm asking it because no error happened in my build tests.
>
> Ditto, and please also remember to CC maintainers on patches.
Right, sorry, took slightly wrong maintainers. As for the build error -
see my earlier post in this thread.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: fix compile breakage - add a missing header include
2010-01-19 7:39 [PATCH] ASoC: fix compile breakage - add a missing header include Guennadi Liakhovetski
2010-01-19 7:49 ` Takashi Iwai
@ 2010-01-19 12:36 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-01-19 12:36 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: Takashi Iwai, alsa-devel
On Tue, Jan 19, 2010 at 08:39:05AM +0100, Guennadi Liakhovetski wrote:
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> It might well have been reported and / or fixed in some trees, sorry for
> the noise, if that's the case.
Not been reported, there's rarely if ever any call to include this
header without also including soc.h.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-19 12:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 7:39 [PATCH] ASoC: fix compile breakage - add a missing header include Guennadi Liakhovetski
2010-01-19 7:49 ` Takashi Iwai
2010-01-19 7:59 ` Guennadi Liakhovetski
2010-01-19 9:59 ` Mark Brown
2010-01-19 10:08 ` Guennadi Liakhovetski
2010-01-19 12:36 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.