From: Alex Chiang <achiang@hp.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
penberg@cs.helsinki.fi, linux-ia64@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: SLUB ia64 linux-next crash bisected to 756dee75
Date: Tue, 19 Jan 2010 21:29:35 +0000 [thread overview]
Message-ID: <20100119212935.GG11010@ldl.fc.hp.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1001191427370.26683@router.home>
* Christoph Lameter <cl@linux-foundation.org>:
> On Tue, 19 Jan 2010, Alex Chiang wrote:
>
> > Well, making progress (maybe?).
>
> Yes I think this is the fix.
>
> > Now we're hitting a BUG_ON().
>
> Thats a kfree of an object not allocated with a slab allocator.
> Recovery is easy in such a case: Dont free the object.
I don't get it.
static int sr_probe(struct device *dev)
{
/* ... */
cd = kzalloc(sizeof(*cd), GFP_KERNEL);
if (!cd)
goto fail;
/* ... */
fail_put:
put_disk(disk);
fail_free:
kfree(cd);
}
The kfree() is balanced with kzalloc(). Unless the stack trace is
lying to us?
/ac
WARNING: multiple messages have this Message-ID (diff)
From: Alex Chiang <achiang@hp.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
penberg@cs.helsinki.fi, linux-ia64@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: SLUB ia64 linux-next crash bisected to 756dee75
Date: Tue, 19 Jan 2010 14:29:35 -0700 [thread overview]
Message-ID: <20100119212935.GG11010@ldl.fc.hp.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1001191427370.26683@router.home>
* Christoph Lameter <cl@linux-foundation.org>:
> On Tue, 19 Jan 2010, Alex Chiang wrote:
>
> > Well, making progress (maybe?).
>
> Yes I think this is the fix.
>
> > Now we're hitting a BUG_ON().
>
> Thats a kfree of an object not allocated with a slab allocator.
> Recovery is easy in such a case: Dont free the object.
I don't get it.
static int sr_probe(struct device *dev)
{
/* ... */
cd = kzalloc(sizeof(*cd), GFP_KERNEL);
if (!cd)
goto fail;
/* ... */
fail_put:
put_disk(disk);
fail_free:
kfree(cd);
}
The kfree() is balanced with kzalloc(). Unless the stack trace is
lying to us?
/ac
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-19 21:29 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 0:29 SLUB ia64 linux-next crash bisected to 756dee75 Alex Chiang
2010-01-13 14:59 ` Christoph Lameter
2010-01-13 14:59 ` Christoph Lameter
2010-01-14 0:53 ` Alex Chiang
2010-01-14 0:53 ` Alex Chiang
2010-01-14 15:01 ` Christoph Lameter
2010-01-14 15:01 ` Christoph Lameter
2010-01-14 18:01 ` Alex Chiang
2010-01-14 18:01 ` Alex Chiang
2010-01-14 15:18 ` Christoph Lameter
2010-01-14 15:18 ` Christoph Lameter
2010-01-14 18:22 ` Alex Chiang
2010-01-14 18:22 ` Alex Chiang
2010-01-14 19:17 ` Pekka Enberg
2010-01-14 19:17 ` Pekka Enberg
2010-01-14 20:32 ` Alex Chiang
2010-01-14 20:32 ` Alex Chiang
2010-01-14 20:58 ` Christoph Lameter
2010-01-14 20:58 ` Christoph Lameter
2010-01-14 21:29 ` Alex Chiang
2010-01-14 21:29 ` Alex Chiang
2010-01-14 21:31 ` Pekka Enberg
2010-01-14 21:31 ` Pekka Enberg
2010-01-14 21:59 ` Christoph Lameter
2010-01-14 21:59 ` Christoph Lameter
2010-01-14 22:01 ` Christoph Lameter
2010-01-14 22:01 ` Christoph Lameter
2010-01-15 20:07 ` Christoph Lameter
2010-01-15 20:07 ` Christoph Lameter
2010-01-15 20:35 ` Lee Schermerhorn
2010-01-15 20:35 ` Lee Schermerhorn
2010-01-15 23:32 ` Christoph Lameter
2010-01-15 23:32 ` Christoph Lameter
2010-01-19 18:53 ` Christoph Lameter
2010-01-19 18:53 ` Christoph Lameter
2010-01-19 20:02 ` Alex Chiang
2010-01-19 20:02 ` Alex Chiang
2010-01-19 20:29 ` Christoph Lameter
2010-01-19 20:29 ` Christoph Lameter
2010-01-19 21:29 ` Alex Chiang [this message]
2010-01-19 21:29 ` Alex Chiang
2010-01-19 21:50 ` Christoph Lameter
2010-01-19 21:50 ` Christoph Lameter
2010-01-20 22:46 ` Alex Chiang
2010-01-20 22:46 ` Alex Chiang
2010-01-21 21:47 ` Alex Chiang
2010-01-21 21:47 ` Alex Chiang
2010-01-21 22:45 ` Christoph Lameter
2010-01-21 22:45 ` Christoph Lameter
2010-01-21 23:05 ` Alex Chiang
2010-01-21 23:05 ` Alex Chiang
2010-01-21 23:43 ` Christoph Lameter
2010-01-21 23:43 ` Christoph Lameter
2010-01-22 0:15 ` Alex Chiang
2010-01-22 0:15 ` Alex Chiang
2010-01-22 14:43 ` Christoph Lameter
2010-01-22 14:43 ` Christoph Lameter
2010-01-22 16:37 ` Pekka Enberg
2010-01-22 16:37 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119212935.GG11010@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=cl@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.