All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
@ 2010-01-22 21:58 Michael Lippautz
  2010-01-22 22:21 ` Khem Raj
  2010-01-23 10:45 ` Koen Kooi
  0 siblings, 2 replies; 9+ messages in thread
From: Michael Lippautz @ 2010-01-22 21:58 UTC (permalink / raw)
  To: openembedded-devel


Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
---
 recipes/gpsd/gpsd.inc     |    9 ++++++---
 recipes/gpsd/gpsd_2.38.bb |    4 +++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
index a917fbe..5efbe2a 100644
--- a/recipes/gpsd/gpsd.inc
+++ b/recipes/gpsd/gpsd.inc
@@ -5,12 +5,14 @@ LICENSE = "GPL"
 DEPENDS = "dbus-glib ncurses python"
 PROVIDES = "virtual/gpsd"
 
+INC_PR = "r0"
+
 EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
                 --x-libraries=${STAGING_LIBDIR} \
                 --enable-dbus \
-                --enable-python"
+"
 
-SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
+SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
            file://gpsd-default \
            file://gps-hardware \
            file://gpsd"
@@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
 export STAGING_INCDIR
 export STAGING_LIBDIR
 
+TARGET_CC_ARCH += "${LDFLAGS}"
+
 do_compile_prepend() {
     export BUILD_SYS="${BUILD_SYS}"
     export HOST_SYS="${HOST_SYS}"
@@ -41,7 +45,6 @@ do_install_prepend() {
 
 do_install_append() {
         install -d ${D}/${sysconfdir}/init.d
-        install -d ${D}/dev
         install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
         install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
         install -d ${D}/${sysconfdir}/default
diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
index 06a5fe7..7c7a477 100644
--- a/recipes/gpsd/gpsd_2.38.bb
+++ b/recipes/gpsd/gpsd_2.38.bb
@@ -1,5 +1,7 @@
 require gpsd.inc
 
-PR = "r2"
+PR = "${INC_PR}.1"
 # make attempts to link gpspacket.so without waiting for all compiler tasks:
 PARALLEL_MAKE = ""
+
+EXTRA_OECONF += " --enable-python "
-- 
1.6.4.4




^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-22 21:58 [PATCH 1/2] gpsd: Prepare recipe and inc for version bump Michael Lippautz
@ 2010-01-22 22:21 ` Khem Raj
  2010-01-23 10:31   ` Michael Lippautz
  2010-01-23 10:45 ` Koen Kooi
  1 sibling, 1 reply; 9+ messages in thread
From: Khem Raj @ 2010-01-22 22:21 UTC (permalink / raw)
  To: openembedded-devel

On (22/01/10 22:58), Michael Lippautz wrote:
> 
> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
> ---
>  recipes/gpsd/gpsd.inc     |    9 ++++++---
>  recipes/gpsd/gpsd_2.38.bb |    4 +++-
>  2 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
> index a917fbe..5efbe2a 100644
> --- a/recipes/gpsd/gpsd.inc
> +++ b/recipes/gpsd/gpsd.inc
> @@ -5,12 +5,14 @@ LICENSE = "GPL"
>  DEPENDS = "dbus-glib ncurses python"
>  PROVIDES = "virtual/gpsd"
>  
> +INC_PR = "r0"
> +

this should be set to r2 or more because that was already revision where
the recipe was at. 

Otherwise ok.

>  EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
>                  --x-libraries=${STAGING_LIBDIR} \
>                  --enable-dbus \
> -                --enable-python"
> +"
>  
> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
>             file://gpsd-default \
>             file://gps-hardware \
>             file://gpsd"
> @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
>  export STAGING_INCDIR
>  export STAGING_LIBDIR
>  
> +TARGET_CC_ARCH += "${LDFLAGS}"
> +
>  do_compile_prepend() {
>      export BUILD_SYS="${BUILD_SYS}"
>      export HOST_SYS="${HOST_SYS}"
> @@ -41,7 +45,6 @@ do_install_prepend() {
>  
>  do_install_append() {
>          install -d ${D}/${sysconfdir}/init.d
> -        install -d ${D}/dev
>          install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
>          install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
>          install -d ${D}/${sysconfdir}/default
> diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
> index 06a5fe7..7c7a477 100644
> --- a/recipes/gpsd/gpsd_2.38.bb
> +++ b/recipes/gpsd/gpsd_2.38.bb
> @@ -1,5 +1,7 @@
>  require gpsd.inc
>  
> -PR = "r2"
> +PR = "${INC_PR}.1"
>  # make attempts to link gpspacket.so without waiting for all compiler tasks:
>  PARALLEL_MAKE = ""
> +
> +EXTRA_OECONF += " --enable-python "
> -- 
> 1.6.4.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-22 22:21 ` Khem Raj
@ 2010-01-23 10:31   ` Michael Lippautz
  2010-01-24 10:38     ` Holger Hans Peter Freyther
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Lippautz @ 2010-01-23 10:31 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
---
 recipes/gpsd/gpsd.inc     |    9 ++++++---
 recipes/gpsd/gpsd_2.38.bb |    4 +++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
index a917fbe..c3e07ec 100644
--- a/recipes/gpsd/gpsd.inc
+++ b/recipes/gpsd/gpsd.inc
@@ -5,12 +5,14 @@ LICENSE = "GPL"
 DEPENDS = "dbus-glib ncurses python"
 PROVIDES = "virtual/gpsd"
 
+INC_PR = "r2"
+
 EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
                 --x-libraries=${STAGING_LIBDIR} \
                 --enable-dbus \
-                --enable-python"
+"
 
-SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
+SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd
\
            file://gpsd-default \
            file://gps-hardware \
            file://gpsd"
@@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
 export STAGING_INCDIR
 export STAGING_LIBDIR
 
+TARGET_CC_ARCH += "${LDFLAGS}"
+
 do_compile_prepend() {
     export BUILD_SYS="${BUILD_SYS}"
     export HOST_SYS="${HOST_SYS}"
@@ -41,7 +45,6 @@ do_install_prepend() {
 
 do_install_append() {
         install -d ${D}/${sysconfdir}/init.d
-        install -d ${D}/dev
         install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
         install -m 0755 ${WORKDIR}/gps-hardware
${D}/${sysconfdir}/init.d/gps-hardware.default
         install -d ${D}/${sysconfdir}/default
diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
index 06a5fe7..7c7a477 100644
--- a/recipes/gpsd/gpsd_2.38.bb
+++ b/recipes/gpsd/gpsd_2.38.bb
@@ -1,5 +1,7 @@
 require gpsd.inc
 
-PR = "r2"
+PR = "${INC_PR}.1"
 # make attempts to link gpspacket.so without waiting for all compiler
tasks:
 PARALLEL_MAKE = ""
+
+EXTRA_OECONF += " --enable-python "
-- 
1.6.4.4

Am Freitag, den 22.01.2010, 14:21 -0800 schrieb Khem Raj:
> On (22/01/10 22:58), Michael Lippautz wrote:
> > 
> > Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
> > ---
> >  recipes/gpsd/gpsd.inc     |    9 ++++++---
> >  recipes/gpsd/gpsd_2.38.bb |    4 +++-
> >  2 files changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
> > index a917fbe..5efbe2a 100644
> > --- a/recipes/gpsd/gpsd.inc
> > +++ b/recipes/gpsd/gpsd.inc
> > @@ -5,12 +5,14 @@ LICENSE = "GPL"
> >  DEPENDS = "dbus-glib ncurses python"
> >  PROVIDES = "virtual/gpsd"
> >  
> > +INC_PR = "r0"
> > +
> 
> this should be set to r2 or more because that was already revision where
> the recipe was at. 
> 
> Otherwise ok.
> 
> >  EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
> >                  --x-libraries=${STAGING_LIBDIR} \
> >                  --enable-dbus \
> > -                --enable-python"
> > +"
> >  
> > -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
> > +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
> >             file://gpsd-default \
> >             file://gps-hardware \
> >             file://gpsd"
> > @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
> >  export STAGING_INCDIR
> >  export STAGING_LIBDIR
> >  
> > +TARGET_CC_ARCH += "${LDFLAGS}"
> > +
> >  do_compile_prepend() {
> >      export BUILD_SYS="${BUILD_SYS}"
> >      export HOST_SYS="${HOST_SYS}"
> > @@ -41,7 +45,6 @@ do_install_prepend() {
> >  
> >  do_install_append() {
> >          install -d ${D}/${sysconfdir}/init.d
> > -        install -d ${D}/dev
> >          install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
> >          install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
> >          install -d ${D}/${sysconfdir}/default
> > diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
> > index 06a5fe7..7c7a477 100644
> > --- a/recipes/gpsd/gpsd_2.38.bb
> > +++ b/recipes/gpsd/gpsd_2.38.bb
> > @@ -1,5 +1,7 @@
> >  require gpsd.inc
> >  
> > -PR = "r2"
> > +PR = "${INC_PR}.1"
> >  # make attempts to link gpspacket.so without waiting for all compiler tasks:
> >  PARALLEL_MAKE = ""
> > +
> > +EXTRA_OECONF += " --enable-python "
> > -- 
> > 1.6.4.4
> > 
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel





^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-22 21:58 [PATCH 1/2] gpsd: Prepare recipe and inc for version bump Michael Lippautz
  2010-01-22 22:21 ` Khem Raj
@ 2010-01-23 10:45 ` Koen Kooi
  2010-01-23 11:08   ` Michael Lippautz
  1 sibling, 1 reply; 9+ messages in thread
From: Koen Kooi @ 2010-01-23 10:45 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Speaking of GPSD, should we make the default config use a control socket
instead of hardcoding ttyS3?

regards,

Koen

On 22-01-10 22:58, Michael Lippautz wrote:
> 
> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
> ---
>  recipes/gpsd/gpsd.inc     |    9 ++++++---
>  recipes/gpsd/gpsd_2.38.bb |    4 +++-
>  2 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
> index a917fbe..5efbe2a 100644
> --- a/recipes/gpsd/gpsd.inc
> +++ b/recipes/gpsd/gpsd.inc
> @@ -5,12 +5,14 @@ LICENSE = "GPL"
>  DEPENDS = "dbus-glib ncurses python"
>  PROVIDES = "virtual/gpsd"
>  
> +INC_PR = "r0"
> +
>  EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
>                  --x-libraries=${STAGING_LIBDIR} \
>                  --enable-dbus \
> -                --enable-python"
> +"
>  
> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
>             file://gpsd-default \
>             file://gps-hardware \
>             file://gpsd"
> @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
>  export STAGING_INCDIR
>  export STAGING_LIBDIR
>  
> +TARGET_CC_ARCH += "${LDFLAGS}"
> +
>  do_compile_prepend() {
>      export BUILD_SYS="${BUILD_SYS}"
>      export HOST_SYS="${HOST_SYS}"
> @@ -41,7 +45,6 @@ do_install_prepend() {
>  
>  do_install_append() {
>          install -d ${D}/${sysconfdir}/init.d
> -        install -d ${D}/dev
>          install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
>          install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
>          install -d ${D}/${sysconfdir}/default
> diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
> index 06a5fe7..7c7a477 100644
> --- a/recipes/gpsd/gpsd_2.38.bb
> +++ b/recipes/gpsd/gpsd_2.38.bb
> @@ -1,5 +1,7 @@
>  require gpsd.inc
>  
> -PR = "r2"
> +PR = "${INC_PR}.1"
>  # make attempts to link gpspacket.so without waiting for all compiler tasks:
>  PARALLEL_MAKE = ""
> +
> +EXTRA_OECONF += " --enable-python "

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLWtMyMkyGM64RGpERAtmDAJ9WqnRXPxe1NX6+HWg4hfPxTYd1bACffpoW
SG0ttXz5eVQUTE1J7X6vF5Q=
=+Wfg
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-23 10:45 ` Koen Kooi
@ 2010-01-23 11:08   ` Michael Lippautz
  2010-01-23 14:07     ` Koen Kooi
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Lippautz @ 2010-01-23 11:08 UTC (permalink / raw)
  To: openembedded-devel

Since a few parts of the .inc are quite confusing I didn't want to
touch it too much.

Ofc we can start gpsd using a control socket.

How should we then solve the problem concerning the different devices?
We would still need an init script that adds gps hardware to gpsd via
the socket and additional packages for different devices providing a
hardware file (containing the path) ?

I am open for suggestions since an I really want to update this.
(Future gpsd will remove the current API to provide additional gps
devices support)

Regards,
Michael

2010/1/23 Koen Kooi <k.kooi@student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Speaking of GPSD, should we make the default config use a control socket
> instead of hardcoding ttyS3?
>
> regards,
>
> Koen
>
> On 22-01-10 22:58, Michael Lippautz wrote:
>>
>> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
>> ---
>>  recipes/gpsd/gpsd.inc     |    9 ++++++---
>>  recipes/gpsd/gpsd_2.38.bb |    4 +++-
>>  2 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
>> index a917fbe..5efbe2a 100644
>> --- a/recipes/gpsd/gpsd.inc
>> +++ b/recipes/gpsd/gpsd.inc
>> @@ -5,12 +5,14 @@ LICENSE = "GPL"
>>  DEPENDS = "dbus-glib ncurses python"
>>  PROVIDES = "virtual/gpsd"
>>
>> +INC_PR = "r0"
>> +
>>  EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
>>                  --x-libraries=${STAGING_LIBDIR} \
>>                  --enable-dbus \
>> -                --enable-python"
>> +"
>>
>> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
>> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
>>             file://gpsd-default \
>>             file://gps-hardware \
>>             file://gpsd"
>> @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
>>  export STAGING_INCDIR
>>  export STAGING_LIBDIR
>>
>> +TARGET_CC_ARCH += "${LDFLAGS}"
>> +
>>  do_compile_prepend() {
>>      export BUILD_SYS="${BUILD_SYS}"
>>      export HOST_SYS="${HOST_SYS}"
>> @@ -41,7 +45,6 @@ do_install_prepend() {
>>
>>  do_install_append() {
>>          install -d ${D}/${sysconfdir}/init.d
>> -        install -d ${D}/dev
>>          install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
>>          install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
>>          install -d ${D}/${sysconfdir}/default
>> diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
>> index 06a5fe7..7c7a477 100644
>> --- a/recipes/gpsd/gpsd_2.38.bb
>> +++ b/recipes/gpsd/gpsd_2.38.bb
>> @@ -1,5 +1,7 @@
>>  require gpsd.inc
>>
>> -PR = "r2"
>> +PR = "${INC_PR}.1"
>>  # make attempts to link gpspacket.so without waiting for all compiler tasks:
>>  PARALLEL_MAKE = ""
>> +
>> +EXTRA_OECONF += " --enable-python "
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFLWtMyMkyGM64RGpERAtmDAJ9WqnRXPxe1NX6+HWg4hfPxTYd1bACffpoW
> SG0ttXz5eVQUTE1J7X6vF5Q=
> =+Wfg
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-23 11:08   ` Michael Lippautz
@ 2010-01-23 14:07     ` Koen Kooi
  2010-01-23 19:48       ` Michael Lippautz
  0 siblings, 1 reply; 9+ messages in thread
From: Koen Kooi @ 2010-01-23 14:07 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 23-01-10 12:08, Michael Lippautz wrote:
> Since a few parts of the .inc are quite confusing I didn't want to
> touch it too much.
> 
> Ofc we can start gpsd using a control socket.
> 
> How should we then solve the problem concerning the different devices?
> We would still need an init script that adds gps hardware to gpsd via
> the socket and additional packages for different devices providing a
> hardware file (containing the path) ?

I have no strong opinion on that, it's just that machine specific
initscripts (vs machine specific /etc/default/foo) are just evil :)

> I am open for suggestions since an I really want to update this.
> (Future gpsd will remove the current API to provide additional gps
> devices support)

My remarks had nothing to do with your patch (which looks fine, btw), it
just triggered a memory about *#(@*(@ gpsd-conf.

regards,

Koen


> Regards,
> Michael
> 
> 2010/1/23 Koen Kooi <k.kooi@student.utwente.nl>:
> Speaking of GPSD, should we make the default config use a control socket
> instead of hardcoding ttyS3?
> 
> regards,
> 
> Koen
> 
> On 22-01-10 22:58, Michael Lippautz wrote:
>>>>
>>>> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
>>>> ---
>>>>  recipes/gpsd/gpsd.inc     |    9 ++++++---
>>>>  recipes/gpsd/gpsd_2.38.bb |    4 +++-
>>>>  2 files changed, 9 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
>>>> index a917fbe..5efbe2a 100644
>>>> --- a/recipes/gpsd/gpsd.inc
>>>> +++ b/recipes/gpsd/gpsd.inc
>>>> @@ -5,12 +5,14 @@ LICENSE = "GPL"
>>>>  DEPENDS = "dbus-glib ncurses python"
>>>>  PROVIDES = "virtual/gpsd"
>>>>
>>>> +INC_PR = "r0"
>>>> +
>>>>  EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
>>>>                  --x-libraries=${STAGING_LIBDIR} \
>>>>                  --enable-dbus \
>>>> -                --enable-python"
>>>> +"
>>>>
>>>> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
>>>> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
>>>>             file://gpsd-default \
>>>>             file://gps-hardware \
>>>>             file://gpsd"
>>>> @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
>>>>  export STAGING_INCDIR
>>>>  export STAGING_LIBDIR
>>>>
>>>> +TARGET_CC_ARCH += "${LDFLAGS}"
>>>> +
>>>>  do_compile_prepend() {
>>>>      export BUILD_SYS="${BUILD_SYS}"
>>>>      export HOST_SYS="${HOST_SYS}"
>>>> @@ -41,7 +45,6 @@ do_install_prepend() {
>>>>
>>>>  do_install_append() {
>>>>          install -d ${D}/${sysconfdir}/init.d
>>>> -        install -d ${D}/dev
>>>>          install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
>>>>          install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
>>>>          install -d ${D}/${sysconfdir}/default
>>>> diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
>>>> index 06a5fe7..7c7a477 100644
>>>> --- a/recipes/gpsd/gpsd_2.38.bb
>>>> +++ b/recipes/gpsd/gpsd_2.38.bb
>>>> @@ -1,5 +1,7 @@
>>>>  require gpsd.inc
>>>>
>>>> -PR = "r2"
>>>> +PR = "${INC_PR}.1"
>>>>  # make attempts to link gpspacket.so without waiting for all compiler tasks:
>>>>  PARALLEL_MAKE = ""
>>>> +
>>>> +EXTRA_OECONF += " --enable-python "
> 
>>
>>
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLWwKZMkyGM64RGpERAi5bAJ9oNZzwy8Jrl03IovVdD4Bqw2tIkQCgsW4+
jq/K97DHKqK4b05yJv+if34=
=33vV
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-23 14:07     ` Koen Kooi
@ 2010-01-23 19:48       ` Michael Lippautz
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Lippautz @ 2010-01-23 19:48 UTC (permalink / raw)
  To: openembedded-devel

So maybe you should not submit the patch...

I would create the recipe as gpsd started up in init.d using a control
socket. But from there on i don't know how machine/gps-device specific
options should be integrated. Should they be packed into a new recipe,
i.e. gpsd-device-....? And if, how if not thorugh defaults or init.d?

regards,
Michael

2010/1/23 Koen Kooi <k.kooi@student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 23-01-10 12:08, Michael Lippautz wrote:
>> Since a few parts of the .inc are quite confusing I didn't want to
>> touch it too much.
>>
>> Ofc we can start gpsd using a control socket.
>>
>> How should we then solve the problem concerning the different devices?
>> We would still need an init script that adds gps hardware to gpsd via
>> the socket and additional packages for different devices providing a
>> hardware file (containing the path) ?
>
> I have no strong opinion on that, it's just that machine specific
> initscripts (vs machine specific /etc/default/foo) are just evil :)
>
>> I am open for suggestions since an I really want to update this.
>> (Future gpsd will remove the current API to provide additional gps
>> devices support)
>
> My remarks had nothing to do with your patch (which looks fine, btw), it
> just triggered a memory about *#(@*(@ gpsd-conf.
>
> regards,
>
> Koen
>
>
>> Regards,
>> Michael
>>
>> 2010/1/23 Koen Kooi <k.kooi@student.utwente.nl>:
>> Speaking of GPSD, should we make the default config use a control socket
>> instead of hardcoding ttyS3?
>>
>> regards,
>>
>> Koen
>>
>> On 22-01-10 22:58, Michael Lippautz wrote:
>>>>>
>>>>> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
>>>>> ---
>>>>>  recipes/gpsd/gpsd.inc     |    9 ++++++---
>>>>>  recipes/gpsd/gpsd_2.38.bb |    4 +++-
>>>>>  2 files changed, 9 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc
>>>>> index a917fbe..5efbe2a 100644
>>>>> --- a/recipes/gpsd/gpsd.inc
>>>>> +++ b/recipes/gpsd/gpsd.inc
>>>>> @@ -5,12 +5,14 @@ LICENSE = "GPL"
>>>>>  DEPENDS = "dbus-glib ncurses python"
>>>>>  PROVIDES = "virtual/gpsd"
>>>>>
>>>>> +INC_PR = "r0"
>>>>> +
>>>>>  EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \
>>>>>                  --x-libraries=${STAGING_LIBDIR} \
>>>>>                  --enable-dbus \
>>>>> -                --enable-python"
>>>>> +"
>>>>>
>>>>> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
>>>>> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \
>>>>>             file://gpsd-default \
>>>>>             file://gps-hardware \
>>>>>             file://gpsd"
>>>>> @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm"
>>>>>  export STAGING_INCDIR
>>>>>  export STAGING_LIBDIR
>>>>>
>>>>> +TARGET_CC_ARCH += "${LDFLAGS}"
>>>>> +
>>>>>  do_compile_prepend() {
>>>>>      export BUILD_SYS="${BUILD_SYS}"
>>>>>      export HOST_SYS="${HOST_SYS}"
>>>>> @@ -41,7 +45,6 @@ do_install_prepend() {
>>>>>
>>>>>  do_install_append() {
>>>>>          install -d ${D}/${sysconfdir}/init.d
>>>>> -        install -d ${D}/dev
>>>>>          install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/
>>>>>          install -m 0755 ${WORKDIR}/gps-hardware ${D}/${sysconfdir}/init.d/gps-hardware.default
>>>>>          install -d ${D}/${sysconfdir}/default
>>>>> diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb
>>>>> index 06a5fe7..7c7a477 100644
>>>>> --- a/recipes/gpsd/gpsd_2.38.bb
>>>>> +++ b/recipes/gpsd/gpsd_2.38.bb
>>>>> @@ -1,5 +1,7 @@
>>>>>  require gpsd.inc
>>>>>
>>>>> -PR = "r2"
>>>>> +PR = "${INC_PR}.1"
>>>>>  # make attempts to link gpspacket.so without waiting for all compiler tasks:
>>>>>  PARALLEL_MAKE = ""
>>>>> +
>>>>> +EXTRA_OECONF += " --enable-python "
>>
>>>
>>>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFLWwKZMkyGM64RGpERAi5bAJ9oNZzwy8Jrl03IovVdD4Bqw2tIkQCgsW4+
> jq/K97DHKqK4b05yJv+if34=
> =33vV
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-23 10:31   ` Michael Lippautz
@ 2010-01-24 10:38     ` Holger Hans Peter Freyther
  2010-01-24 10:56       ` Paul Menzel
  0 siblings, 1 reply; 9+ messages in thread
From: Holger Hans Peter Freyther @ 2010-01-24 10:38 UTC (permalink / raw)
  To: openembedded-devel

On Saturday 23 January 2010 11:31:21 Michael Lippautz wrote:

> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd
> \

Hi,
your mailer has wrapped this line making it impossible to to apply the patch. 
It would be nice if you could send a final patch without line wrapping.

thanks a lot
	zecke



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] gpsd: Prepare recipe and inc for version bump
  2010-01-24 10:38     ` Holger Hans Peter Freyther
@ 2010-01-24 10:56       ` Paul Menzel
  0 siblings, 0 replies; 9+ messages in thread
From: Paul Menzel @ 2010-01-24 10:56 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

Am Sonntag, den 24.01.2010, 11:38 +0100 schrieb Holger Hans Peter Freyther:
> On Saturday 23 January 2010 11:31:21 Michael Lippautz wrote:
> 
> > -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \
> > +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd
> > \
>
> your mailer has wrapped this line making it impossible to to apply the patch. 
> It would be nice if you could send a final patch without line wrapping.

Michael, you could also shorten that line using »…${P}« [1].

        P: The package name and versions separated by a hyphen.
        
        P = "${PN}-${PV}"
        For the strace_4.5.14.bb recipe the P variable would be set to
        "strace-4.5.14".


Thanks,

Paul


[1] http://docs.openembedded.org/usermanual/html/recipes_versioning.html

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2010-01-24 10:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-22 21:58 [PATCH 1/2] gpsd: Prepare recipe and inc for version bump Michael Lippautz
2010-01-22 22:21 ` Khem Raj
2010-01-23 10:31   ` Michael Lippautz
2010-01-24 10:38     ` Holger Hans Peter Freyther
2010-01-24 10:56       ` Paul Menzel
2010-01-23 10:45 ` Koen Kooi
2010-01-23 11:08   ` Michael Lippautz
2010-01-23 14:07     ` Koen Kooi
2010-01-23 19:48       ` Michael Lippautz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.