* [mesa PATCH] nv50: fix uninitialized variable in nv50_revdep_reorder
@ 2010-01-24 18:27 Marcin Slusarz
[not found] ` <20100124182759.GD2908-OI9uyE9O0yo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2010-01-24 18:27 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
"unsafe" is never initialized, but used
(found by valgrind)
---
src/gallium/drivers/nv50/nv50_program.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/gallium/drivers/nv50/nv50_program.c b/src/gallium/drivers/nv50/nv50_program.c
index cfe8b48..6d9ac14 100644
--- a/src/gallium/drivers/nv50/nv50_program.c
+++ b/src/gallium/drivers/nv50/nv50_program.c
@@ -3275,7 +3275,7 @@ prep_inspect_insn(struct nv50_pc *pc, const struct tgsi_full_instruction *insn)
static unsigned
nv50_revdep_reorder(unsigned m[4], unsigned rdep[4])
{
- unsigned i, c, x, unsafe;
+ unsigned i, c, x, unsafe = 0;
for (c = 0; c < 4; c++)
m[c] = c;
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [mesa PATCH] nv50: fix uninitialized variable in nv50_revdep_reorder
[not found] ` <20100124182759.GD2908-OI9uyE9O0yo@public.gmane.org>
@ 2010-01-24 23:48 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2010-01-24 23:48 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Sun, 2010-01-24 at 19:27 +0100, Marcin Slusarz wrote:
> "unsafe" is never initialized, but used
> (found by valgrind)
Pushed, plus the other three patches you pinged on.
Ben.
> ---
> src/gallium/drivers/nv50/nv50_program.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/gallium/drivers/nv50/nv50_program.c b/src/gallium/drivers/nv50/nv50_program.c
> index cfe8b48..6d9ac14 100644
> --- a/src/gallium/drivers/nv50/nv50_program.c
> +++ b/src/gallium/drivers/nv50/nv50_program.c
> @@ -3275,7 +3275,7 @@ prep_inspect_insn(struct nv50_pc *pc, const struct tgsi_full_instruction *insn)
> static unsigned
> nv50_revdep_reorder(unsigned m[4], unsigned rdep[4])
> {
> - unsigned i, c, x, unsafe;
> + unsigned i, c, x, unsafe = 0;
>
> for (c = 0; c < 4; c++)
> m[c] = c;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-24 23:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-24 18:27 [mesa PATCH] nv50: fix uninitialized variable in nv50_revdep_reorder Marcin Slusarz
[not found] ` <20100124182759.GD2908-OI9uyE9O0yo@public.gmane.org>
2010-01-24 23:48 ` Ben Skeggs
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.