From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spinlock: don't use deprecated barriers on ARMv7
Date: Sun, 24 Jan 2010 20:42:33 +0000 [thread overview]
Message-ID: <20100124204233.GA25665@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1263397536-15736-1-git-send-email-rabin@rab.in>
On Wed, Jan 13, 2010 at 09:15:36PM +0530, Rabin Vincent wrote:
> On ARMv7, the use of the cp15 operations for barriers is deprecated in
> favour of the isb, dsb, and dmb instructions. Change the locking
> functions to use the appropriate type of dsb for the architecture being
> built for.
Umm...
> diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
> index 058e7e9..0b371ba 100644
> --- a/arch/arm/include/asm/system.h
> +++ b/arch/arm/include/asm/system.h
> @@ -164,6 +164,14 @@ extern unsigned int user_debug;
> #define set_mb(var, value) do { var = value; smp_mb(); } while (0)
> #define nop() __asm__ __volatile__("mov\tr0,r0\t@ nop\n\t");
>
> +static inline void smp_sev(void)
> +{
> +#if defined(CONFIG_SMP) && defined(CONFIG_CPU_32v6K)
> + dsb();
> + __asm__ __volatile__ ("sev" : : : "memory");
Why are you introducing a compiler memory barrier where there was none
before?
next prev parent reply other threads:[~2010-01-24 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 15:45 [PATCH] spinlock: don't use deprecated barriers on ARMv7 Rabin Vincent
2010-01-24 20:42 ` Russell King - ARM Linux [this message]
2010-01-25 17:50 ` Rabin Vincent
2010-01-25 18:03 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2010-01-11 15:06 Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100124204233.GA25665@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.