From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spinlock: don't use deprecated barriers on ARMv7
Date: Mon, 25 Jan 2010 23:20:29 +0530 [thread overview]
Message-ID: <20100125173808.GA23926@debian> (raw)
In-Reply-To: <20100124204233.GA25665@n2100.arm.linux.org.uk>
On Sun, Jan 24, 2010 at 08:42:33PM +0000, Russell King - ARM Linux wrote:
> > +static inline void smp_sev(void)
> > +{
> > +#if defined(CONFIG_SMP) && defined(CONFIG_CPU_32v6K)
> > + dsb();
> > + __asm__ __volatile__ ("sev" : : : "memory");
>
> Why are you introducing a compiler memory barrier where there was none
> before?
I've removed it (and the additional memory barrier from the dsb()
helper) in the updated patch below. I've also moved the helper into
spinlock.h itself, to avoid unnecessarily cluttering system.h:
next prev parent reply other threads:[~2010-01-25 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 15:45 [PATCH] spinlock: don't use deprecated barriers on ARMv7 Rabin Vincent
2010-01-24 20:42 ` Russell King - ARM Linux
2010-01-25 17:50 ` Rabin Vincent [this message]
2010-01-25 18:03 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2010-01-11 15:06 Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125173808.GA23926@debian \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.