All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Don Mullis <don.mullis@gmail.com>,
	linux-kernel@vger.kernel.org, airlied@redhat.com,
	dedekind@infradead.org
Subject: Re: [PATCH 1/2] lib: more scalable list_sort()
Date: Sun, 24 Jan 2010 21:59:06 +0100	[thread overview]
Message-ID: <20100124205906.GC29555@one.firstfloor.org> (raw)
In-Reply-To: <20100123160537.GG25842@discord.disaster>

> Similarly, adding cond_resched() to list_sort means you can stop
> worrying about the scheduling latency impact of sorting long lists.
> I fail to see why you're making such a big deal out of this.....

It's not easy to add it to a low level library function like list_sort()
because you would need to ensure that all callers are allowed to sleep.

Or even if all callers currently allow it future ones might not.

So it would need a new flag or so if needed, completely changing 
the interface.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2010-01-24 20:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-21  4:51 [PATCH 1/2] lib: more scalable list_sort() Don Mullis
2010-01-21  5:17 ` [PATCH 2/2] lib: revise list_sort() comment Don Mullis
2010-01-21 19:11   ` Olaf Titz
2010-01-22  4:54     ` Don Mullis
2010-01-21  9:22 ` [PATCH 1/2] lib: more scalable list_sort() Artem Bityutskiy
2010-01-21  9:54   ` Dave Chinner
2010-01-21 11:44     ` Artem Bityutskiy
2010-01-21 16:34       ` Don Mullis
2010-01-21 17:59 ` Andi Kleen
2010-01-22  3:17   ` Don Mullis
2010-01-22 10:43     ` Andi Kleen
2010-01-22 12:29       ` Artem Bityutskiy
2010-01-22 17:55         ` Don Mullis
2010-01-23  8:28       ` Dave Chinner
2010-01-23 11:35         ` Andi Kleen
2010-01-23 16:05           ` Dave Chinner
2010-01-24 20:59             ` Andi Kleen [this message]
2010-01-24 21:10               ` Artem Bityutskiy
2010-01-24 22:38                 ` Don Mullis
2010-01-25  3:41               ` Dave Chinner
2010-08-04 14:04 ` Artem Bityutskiy
2010-08-07  7:50   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100124205906.GC29555@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=airlied@redhat.com \
    --cc=david@fromorbit.com \
    --cc=dedekind@infradead.org \
    --cc=don.mullis@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.