From: Don Mullis <don.mullis@gmail.com>
To: dedekind@infradead.org
Cc: Andi Kleen <andi@firstfloor.org>,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, airlied@redhat.com
Subject: Re: [PATCH 1/2] lib: more scalable list_sort()
Date: Sun, 24 Jan 2010 14:38:15 -0800 [thread overview]
Message-ID: <87ljfn9lig.fsf@gmail.com> (raw)
In-Reply-To: <1264367435.2401.40.camel@localhost.localdomain> (Artem Bityutskiy's message of "Sun, 24 Jan 2010 23:10:35 +0200")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> Don made IMO a good proposal for the caller to add cond_reshed() in its
> 'cmp()' callback, if needed. Shouldn't that work fine?
In the list_sort() implementation I posted, there was an O(n) loop that
contained no calls back to cmp(). The V2 implementation I'm testing
right now fixes that -- all inner loops will call back to cmp(). It's
also a bit faster, though ~100 bytes bigger.
If there's any other objection to pushing responsibility for calling
cond_resched() back to the client, via the cmp() routine, please, let's
hear it.
next prev parent reply other threads:[~2010-01-24 22:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 4:51 [PATCH 1/2] lib: more scalable list_sort() Don Mullis
2010-01-21 5:17 ` [PATCH 2/2] lib: revise list_sort() comment Don Mullis
2010-01-21 19:11 ` Olaf Titz
2010-01-22 4:54 ` Don Mullis
2010-01-21 9:22 ` [PATCH 1/2] lib: more scalable list_sort() Artem Bityutskiy
2010-01-21 9:54 ` Dave Chinner
2010-01-21 11:44 ` Artem Bityutskiy
2010-01-21 16:34 ` Don Mullis
2010-01-21 17:59 ` Andi Kleen
2010-01-22 3:17 ` Don Mullis
2010-01-22 10:43 ` Andi Kleen
2010-01-22 12:29 ` Artem Bityutskiy
2010-01-22 17:55 ` Don Mullis
2010-01-23 8:28 ` Dave Chinner
2010-01-23 11:35 ` Andi Kleen
2010-01-23 16:05 ` Dave Chinner
2010-01-24 20:59 ` Andi Kleen
2010-01-24 21:10 ` Artem Bityutskiy
2010-01-24 22:38 ` Don Mullis [this message]
2010-01-25 3:41 ` Dave Chinner
2010-08-04 14:04 ` Artem Bityutskiy
2010-08-07 7:50 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljfn9lig.fsf@gmail.com \
--to=don.mullis@gmail.com \
--cc=airlied@redhat.com \
--cc=andi@firstfloor.org \
--cc=david@fromorbit.com \
--cc=dedekind@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.