* include/scsi/scsi.h: type mismatch in userspace
[not found] ` <20100121170158.GB13617@suse.de>
@ 2010-01-26 10:09 ` krike
2010-02-18 6:44 ` krike
1 sibling, 0 replies; 2+ messages in thread
From: krike @ 2010-01-26 10:09 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Hello.
I think that there is mistake in linux/2.6.32.4/include/scsi/scsi.h:
the type defination of u8 should be type of __u8 on userspace
(struct scsi_varlen_cdb_hdr).
I founded this problem when I try compile the util-linux-ng-2.17.
This should cause problems many other packages also that includes scsi.h
>
> Please let the Linux SCSI developers know about this, they are the ones
> responsible for fixing it. Once they have done so in the upstream tree,
> can I add it to the -stable tree.
>
> thanks,
>
> greg k-h
Best regards: Kristian Rainio <krike@sci.fi>
[-- Attachment #2: linux-2.6.32.5-scsi_h.patch --]
[-- Type: text/plain, Size: 679 bytes --]
Patch by Kristian Rainio
Little fix.
--- linux-2.6.32/include/scsi/scsi.h.orig 2010-01-23 12:39:06.970791908 +0200
+++ linux-2.6.32/include/scsi/scsi.h 2010-01-23 12:39:25.427462244 +0200
@@ -145,10 +145,10 @@
/* defined in T10 SCSI Primary Commands-2 (SPC2) */
struct scsi_varlen_cdb_hdr {
- u8 opcode; /* opcode always == VARIABLE_LENGTH_CMD */
- u8 control;
- u8 misc[5];
- u8 additional_cdb_length; /* total cdb length - 8 */
+ __u8 opcode; /* opcode always == VARIABLE_LENGTH_CMD */
+ __u8 control;
+ __u8 misc[5];
+ __u8 additional_cdb_length; /* total cdb length - 8 */
__be16 service_action;
/* service specific data follows */
};
^ permalink raw reply [flat|nested] 2+ messages in thread* include/scsi/scsi.h: type mismatch in userspace
[not found] ` <20100121170158.GB13617@suse.de>
2010-01-26 10:09 ` include/scsi/scsi.h: type mismatch in userspace krike
@ 2010-02-18 6:44 ` krike
1 sibling, 0 replies; 2+ messages in thread
From: krike @ 2010-02-18 6:44 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Hello.
I think that there is mistake in linux/2.6.32.4/include/scsi/scsi.h:
the type defination of u8 should be type of __u8 on userspace
(struct scsi_varlen_cdb_hdr).
I founded this problem when I try compile the util-linux-ng-2.17.
This should cause problems many other packages also that includes scsi.h
>
> Please let the Linux SCSI developers know about this, they are the ones
> responsible for fixing it. Once they have done so in the upstream tree,
> can I add it to the -stable tree.
>
> thanks,
>
> greg k-h
Best regards: Kristian Rainio <krike@sci.fi>
[-- Attachment #2: linux-2.6.32.5-scsi_h.patch --]
[-- Type: text/plain, Size: 679 bytes --]
Patch by Kristian Rainio
Little fix.
--- linux-2.6.32/include/scsi/scsi.h.orig 2010-01-23 12:39:06.970791908 +0200
+++ linux-2.6.32/include/scsi/scsi.h 2010-01-23 12:39:25.427462244 +0200
@@ -145,10 +145,10 @@
/* defined in T10 SCSI Primary Commands-2 (SPC2) */
struct scsi_varlen_cdb_hdr {
- u8 opcode; /* opcode always == VARIABLE_LENGTH_CMD */
- u8 control;
- u8 misc[5];
- u8 additional_cdb_length; /* total cdb length - 8 */
+ __u8 opcode; /* opcode always == VARIABLE_LENGTH_CMD */
+ __u8 control;
+ __u8 misc[5];
+ __u8 additional_cdb_length; /* total cdb length - 8 */
__be16 service_action;
/* service specific data follows */
};
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-18 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100121090042.GA2083@satellite>
[not found] ` <20100121170158.GB13617@suse.de>
2010-01-26 10:09 ` include/scsi/scsi.h: type mismatch in userspace krike
2010-02-18 6:44 ` krike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.