From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org, lrg@slimlogic.co.uk,
linux-samsung-soc@vger.kernel.org,
Jassi Brar <jassi.brar@samsung.com>
Subject: Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver
Date: Tue, 26 Jan 2010 12:04:02 +0000 [thread overview]
Message-ID: <20100126120402.GO15759@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6791001260357p62b5c10dpfa2a5ddcae0704dd@mail.gmail.com>
On Tue, Jan 26, 2010 at 08:57:56PM +0900, jassi brar wrote:
> On Tue, Jan 26, 2010 at 8:09 PM, Mark Brown
> > If they both work equally well please just go ahead and remove the old
> > driver. Keeping the old driver around if it doesn't work is likely to
> > result in any fixups going into that.
> ok, will submit a patch for that too.
> Btw, I don't have ln2440sbc and don't know how would it take the change,
> though I sincerely think it should be just fine.
CC the original author on the patch updating it, if they don't reply
then a build test is fine - I'd also expect it'll work fine (though
thinking about it you'll need to add the platform data for the GPIO
configuration to the 2443 instance of the struct device, I'm not sure if
that was there or not?).
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver
Date: Tue, 26 Jan 2010 12:04:02 +0000 [thread overview]
Message-ID: <20100126120402.GO15759@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6791001260357p62b5c10dpfa2a5ddcae0704dd@mail.gmail.com>
On Tue, Jan 26, 2010 at 08:57:56PM +0900, jassi brar wrote:
> On Tue, Jan 26, 2010 at 8:09 PM, Mark Brown
> > If they both work equally well please just go ahead and remove the old
> > driver. ?Keeping the old driver around if it doesn't work is likely to
> > result in any fixups going into that.
> ok, will submit a patch for that too.
> Btw, I don't have ln2440sbc and don't know how would it take the change,
> though I sincerely think it should be just fine.
CC the original author on the patch updating it, if they don't reply
then a build test is fine - I'd also expect it'll work fine (though
thinking about it you'll need to add the platform data for the GPIO
configuration to the 2443 instance of the struct device, I'm not sure if
that was there or not?).
next prev parent reply other threads:[~2010-01-26 12:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 5:51 [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources jassisinghbrar
2010-01-26 5:51 ` jassisinghbrar at gmail.com
2010-01-26 5:51 ` [PATCH 2/3] ASoC: AC97: S3C: Add controller driver jassisinghbrar
2010-01-26 5:51 ` jassisinghbrar at gmail.com
2010-01-26 5:51 ` [PATCH 3/3] ARM: SMDK64XX: Enable AC97 device jassisinghbrar
2010-01-26 5:51 ` jassisinghbrar at gmail.com
2010-01-26 10:19 ` Mark Brown
2010-01-26 10:19 ` Mark Brown
2010-01-26 10:52 ` jassi brar
2010-01-26 10:52 ` jassi brar
2010-01-26 10:59 ` Mark Brown
2010-01-26 10:59 ` Mark Brown
2010-01-26 7:32 ` [PATCH 2/3] ASoC: AC97: S3C: Add controller driver jassi brar
2010-01-26 7:32 ` jassi brar
2010-01-26 10:53 ` Mark Brown
2010-01-26 10:53 ` Mark Brown
2010-01-26 11:49 ` jassi brar
2010-01-26 11:49 ` jassi brar
2010-01-26 10:23 ` Ben Dooks
2010-01-26 10:23 ` Ben Dooks
2010-01-26 11:03 ` jassi brar
2010-01-26 11:03 ` jassi brar
2010-01-26 11:09 ` Mark Brown
2010-01-26 11:09 ` Mark Brown
2010-01-26 11:57 ` jassi brar
2010-01-26 11:57 ` jassi brar
2010-01-26 12:04 ` Mark Brown [this message]
2010-01-26 12:04 ` Mark Brown
2010-01-27 2:45 ` jassi brar
2010-01-27 2:45 ` jassi brar
2010-01-27 10:25 ` Mark Brown
2010-01-27 10:25 ` Mark Brown
2010-01-26 10:47 ` Mark Brown
2010-01-26 10:47 ` Mark Brown
2010-01-26 11:17 ` jassi brar
2010-01-26 11:17 ` jassi brar
2010-01-26 11:52 ` Mark Brown
2010-01-26 11:52 ` Mark Brown
2010-01-26 12:11 ` jassi brar
2010-01-26 12:11 ` jassi brar
2010-01-26 13:00 ` Mark Brown
2010-01-26 13:00 ` Mark Brown
2010-01-26 10:12 ` [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources Mark Brown
2010-01-26 10:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126120402.GO15759@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.