All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
	linux-samsung-soc@vger.kernel.org,
	Jassi Brar <jassi.brar@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
Date: Wed, 27 Jan 2010 08:24:47 +0000	[thread overview]
Message-ID: <20100127082447.GL9153@trinity.fluff.org> (raw)
In-Reply-To: <1b68c6791001270015o4d5f42b8k858b959816c9b7c9@mail.gmail.com>

On Wed, Jan 27, 2010 at 05:15:28PM +0900, jassi brar wrote:
> On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar@gmail.com wrote:
> >> From: Jassi Brar <jassi.brar@samsung.com>
> >>
> >> GPIO_E-[5,9] pin functionality was defined incorrectly.
> >> The patch corrects and adds missing pins.
> >
> > Ok, should I apply this to the fixes tree and send to linus?
> Honestly speaking, I don't know. Please do as you see due.
> Maybe Mark Brown, as an affected maintainer, has some opinion?
> thanks

Ok, couple of questions:

1) Is it currently causing an working driver to fail?
2) Will it break anything currently in the kernel if merged now?

I'll await Mark's comments.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
Date: Wed, 27 Jan 2010 08:24:47 +0000	[thread overview]
Message-ID: <20100127082447.GL9153@trinity.fluff.org> (raw)
In-Reply-To: <1b68c6791001270015o4d5f42b8k858b959816c9b7c9@mail.gmail.com>

On Wed, Jan 27, 2010 at 05:15:28PM +0900, jassi brar wrote:
> On Wed, Jan 27, 2010 at 5:11 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
> >> From: Jassi Brar <jassi.brar@samsung.com>
> >>
> >> GPIO_E-[5,9] pin functionality was defined incorrectly.
> >> The patch corrects and adds missing pins.
> >
> > Ok, should I apply this to the fixes tree and send to linus?
> Honestly speaking, I don't know. Please do as you see due.
> Maybe Mark Brown, as an affected maintainer, has some opinion?
> thanks

Ok, couple of questions:

1) Is it currently causing an working driver to fail?
2) Will it break anything currently in the kernel if merged now?

I'll await Mark's comments.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  reply	other threads:[~2010-01-27  8:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  5:57 [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines jassisinghbrar
2010-01-27  5:57 ` jassisinghbrar at gmail.com
2010-01-27  8:11 ` Ben Dooks
2010-01-27  8:11   ` Ben Dooks
2010-01-27  8:15   ` jassi brar
2010-01-27  8:15     ` jassi brar
2010-01-27  8:24     ` Ben Dooks [this message]
2010-01-27  8:24       ` Ben Dooks
2010-01-27  8:28       ` jassi brar
2010-01-27  8:28         ` jassi brar
2010-01-27 10:29     ` Mark Brown
2010-01-27 10:29       ` Mark Brown
2010-01-27 10:37       ` jassi brar
2010-01-27 10:37         ` jassi brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100127082447.GL9153@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=jassi.brar@samsung.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.