From: Oleg Nesterov <oleg@redhat.com>
To: akpm@linux-foundation.org
Cc: jmoskovc@redhat.com, nhorman@tuxdriver.com, neilb@suse.de,
benh@kernel.crashing.org, gregkh@suse.de, takedakn@nttdata.co.jp,
linux-kernel@vger.kernel.org, spock@gentoo.org, mingo@redhat.com,
viro@zeniv.linux.org.uk, mfasheh@suse.com, menage@google.com,
t.sailer@alumni.ethz.ch, shemminger@linux-foundation.org,
abelay@mit.edu, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] + exec-allow-core_pipe-recursion-check-to-look-for-a-value-of-1-rather -than-0.patch added to -mm tree
Date: Wed, 27 Jan 2010 18:58:52 +0100 [thread overview]
Message-ID: <20100127175852.GA7511@redhat.com> (raw)
In-Reply-To: <20100127174706.GA6333@redhat.com>
On 01/27, Oleg Nesterov wrote:
>
> Currently only d_coredump() needs this new feature, but please note
> that ____call_usermodehelper() was already "uglified" for the coredumping
> over the pipe.
>
> If we add sub_info->finit(), then probably we should move the code
> under "if (sub_info->stdin)" from ____call_usermodehelper() to
> core_pipe_setup() ?
And, perhaps, we should not change call_usermodehelper() and all its
callers? If the caller needs ->finit() it can customize subprocess_info
like call_usermodehelper_pipe() already does?
To clarify, I don't have a "strong" opinion, I am just asking.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, nhorman@tuxdriver.com,
abelay@mit.edu, benh@kernel.crashing.org,
drbd-dev@lists.linbit.com, gregkh@suse.de, jmoskovc@redhat.com,
menage@google.com, mfasheh@suse.com, mingo@redhat.com,
neilb@suse.de, shemminger@linux-foundation.org, spock@gentoo.org,
t.sailer@alumni.ethz.ch, takedakn@nttdata.co.jp,
viro@zeniv.linux.org.uk
Subject: Re: + exec-allow-core_pipe-recursion-check-to-look-for-a-value-of-1-rather -than-0.patch added to -mm tree
Date: Wed, 27 Jan 2010 18:58:52 +0100 [thread overview]
Message-ID: <20100127175852.GA7511@redhat.com> (raw)
In-Reply-To: <20100127174706.GA6333@redhat.com>
On 01/27, Oleg Nesterov wrote:
>
> Currently only d_coredump() needs this new feature, but please note
> that ____call_usermodehelper() was already "uglified" for the coredumping
> over the pipe.
>
> If we add sub_info->finit(), then probably we should move the code
> under "if (sub_info->stdin)" from ____call_usermodehelper() to
> core_pipe_setup() ?
And, perhaps, we should not change call_usermodehelper() and all its
callers? If the caller needs ->finit() it can customize subprocess_info
like call_usermodehelper_pipe() already does?
To clarify, I don't have a "strong" opinion, I am just asking.
Oleg.
next prev parent reply other threads:[~2010-01-27 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 23:54 + exec-allow-core_pipe-recursion-check-to-look-for-a-value-of-1-rather-than-0.patch added to -mm tree akpm
2010-01-26 23:54 ` [Drbd-dev] " akpm
2010-01-27 17:47 ` [Drbd-dev] + exec-allow-core_pipe-recursion-check-to-look-for-a-value-of-1-rather -than-0.patch " Oleg Nesterov
2010-01-27 17:47 ` Oleg Nesterov
2010-01-27 17:58 ` Oleg Nesterov [this message]
2010-01-27 17:58 ` Oleg Nesterov
2010-01-27 21:22 ` [Drbd-dev] " Neil Horman
2010-01-27 21:22 ` Neil Horman
2010-01-27 21:34 ` [Drbd-dev] " Andrew Morton
2010-01-27 21:34 ` Andrew Morton
2010-01-27 23:08 ` nhorman
2010-01-27 21:25 ` [Drbd-dev] " Neil Horman
2010-01-27 21:25 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127175852.GA7511@redhat.com \
--to=oleg@redhat.com \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=drbd-dev@lists.linbit.com \
--cc=gregkh@suse.de \
--cc=jmoskovc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mfasheh@suse.com \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@linux-foundation.org \
--cc=spock@gentoo.org \
--cc=t.sailer@alumni.ethz.ch \
--cc=takedakn@nttdata.co.jp \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.