From: Andrew Morton <akpm@linux-foundation.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] imxfb: correct location of callbacks in suspend and
Date: Thu, 28 Jan 2010 08:19:57 +0000 [thread overview]
Message-ID: <20100128001957.408936b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100128074101.GA13756@pengutronix.de>
On Thu, 28 Jan 2010 08:41:01 +0100 Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
> > What were the runtime effects of this bug?
> For me it was that in the original imxfb_info *fbi backlight_power was
> NULL but in imxfb_suspend it was 4 resulting in an oops as imxfb_suspend
> calls imxfb_disable_controller(fbi) which in turn has
>
> if (fbi->backlight_power)
> fbi->backlight_power(0);
OK, thanks, that was important info.
I rescheduled the patch for 2.6.33 and marked it for 2.6.32.x backporting.
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imxfb: correct location of callbacks in suspend and resume
Date: Thu, 28 Jan 2010 00:19:57 -0800 [thread overview]
Message-ID: <20100128001957.408936b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100128074101.GA13756@pengutronix.de>
On Thu, 28 Jan 2010 08:41:01 +0100 Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
> > What were the runtime effects of this bug?
> For me it was that in the original imxfb_info *fbi backlight_power was
> NULL but in imxfb_suspend it was 4 resulting in an oops as imxfb_suspend
> calls imxfb_disable_controller(fbi) which in turn has
>
> if (fbi->backlight_power)
> fbi->backlight_power(0);
OK, thanks, that was important info.
I rescheduled the patch for 2.6.33 and marked it for 2.6.32.x backporting.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
trivial@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] imxfb: correct location of callbacks in suspend and resume
Date: Thu, 28 Jan 2010 00:19:57 -0800 [thread overview]
Message-ID: <20100128001957.408936b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100128074101.GA13756@pengutronix.de>
On Thu, 28 Jan 2010 08:41:01 +0100 Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
> > What were the runtime effects of this bug?
> For me it was that in the original imxfb_info *fbi backlight_power was
> NULL but in imxfb_suspend it was 4 resulting in an oops as imxfb_suspend
> calls imxfb_disable_controller(fbi) which in turn has
>
> if (fbi->backlight_power)
> fbi->backlight_power(0);
OK, thanks, that was important info.
I rescheduled the patch for 2.6.33 and marked it for 2.6.32.x backporting.
next prev parent reply other threads:[~2010-01-28 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 16:21 [PATCH] imxfb: correct location of callbacks in suspend and resume
2010-01-11 16:21 ` Uwe Kleine-König
2010-01-11 17:59 ` [PATCH] imxfb: correct location of callbacks in suspend and Sascha Hauer
2010-01-11 17:59 ` [PATCH] imxfb: correct location of callbacks in suspend and resume Sascha Hauer
2010-01-25 15:37 `
2010-01-25 15:37 ` Uwe Kleine-König
2010-01-25 15:37 ` Uwe Kleine-König
2010-01-27 23:48 ` [PATCH] imxfb: correct location of callbacks in suspend and Andrew Morton
2010-01-27 23:48 ` [PATCH] imxfb: correct location of callbacks in suspend and resume Andrew Morton
2010-01-27 23:48 ` Andrew Morton
2010-01-28 7:41 ` [PATCH] imxfb: correct location of callbacks in suspend and
2010-01-28 7:41 ` [PATCH] imxfb: correct location of callbacks in suspend and resume Uwe Kleine-König
2010-01-28 7:41 ` Uwe Kleine-König
2010-01-28 8:19 ` Andrew Morton [this message]
2010-01-28 8:19 ` Andrew Morton
2010-01-28 8:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128001957.408936b2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.