All of lore.kernel.org
 help / color / mirror / Atom feed
From: lethal@linux-sh.org (Paul Mundt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/06] sh-sci: Preliminary SuperH Mobile ARM support
Date: Fri, 29 Jan 2010 11:52:42 +0900	[thread overview]
Message-ID: <20100129025242.GC7396@linux-sh.org> (raw)
In-Reply-To: <20100128124131.8982.21545.sendpatchset@rxone.opensource.se>

On Thu, Jan 28, 2010 at 09:41:31PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add preliminary SuperH Mobile ARM support to the sh-sci
> driver. Enough to get serial console working. Needs more
> work. Is really disconnected from the ARM support code
> but is included here for completeness.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  drivers/serial/Kconfig  |    2 +-
>  drivers/serial/sh-sci.h |   23 ++++++++++++++++++-----
>  2 files changed, 19 insertions(+), 6 deletions(-)
> 
> --- 0001/drivers/serial/Kconfig
> +++ work/drivers/serial/Kconfig	2010-01-21 19:55:26.000000000 +0900
> @@ -996,7 +996,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
>  
>  config SERIAL_SH_SCI
>  	tristate "SuperH SCI(F) serial port support"
> -	depends on HAVE_CLK && (SUPERH || H8300)
> +	depends on HAVE_CLK && (SUPERH || H8300 || ARCH_SHMOBILE)
>  	select SERIAL_CORE
>  
>  config SERIAL_SH_SCI_NR_UARTS
> --- 0001/drivers/serial/sh-sci.h
> +++ work/drivers/serial/sh-sci.h	2010-01-21 19:57:10.000000000 +0900
> @@ -174,6 +174,10 @@
>  # define SCSPTR3 0xffc60020		/* 16 bit SCIF */
>  # define SCIF_ORER 0x0001		/* Overrun error bit */
>  # define SCSCR_INIT(port)	0x38	/* TIE=0,RIE=0,TE=1,RE=1,REIE=1 */
> +#elif defined(CONFIG_ARCH_SHMOBILE)
> +# define SCSCR_INIT(port)	0x0030
> +# define SCIF_ONLY
> +# define SCIF_ORER		0x0200
>  #else
>  # error CPU subtype not defined
>  #endif
>        defined(CONFIG_CPU_SUBTYPE_SH7724)

SCIF_ONLY should be killed off, nothing is checking for it these days. I
thought they were all gone already, but it looks like SH7757 snuck one
back in, too..

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux@arm.linux.org.uk, eric.y.miao@gmail.com, tony@atomide.com,
	linux-kernel@vger.kernel.org, khilman@deeprootsystems.com,
	ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/06] sh-sci: Preliminary SuperH Mobile ARM support
Date: Fri, 29 Jan 2010 11:52:42 +0900	[thread overview]
Message-ID: <20100129025242.GC7396@linux-sh.org> (raw)
In-Reply-To: <20100128124131.8982.21545.sendpatchset@rxone.opensource.se>

On Thu, Jan 28, 2010 at 09:41:31PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add preliminary SuperH Mobile ARM support to the sh-sci
> driver. Enough to get serial console working. Needs more
> work. Is really disconnected from the ARM support code
> but is included here for completeness.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  drivers/serial/Kconfig  |    2 +-
>  drivers/serial/sh-sci.h |   23 ++++++++++++++++++-----
>  2 files changed, 19 insertions(+), 6 deletions(-)
> 
> --- 0001/drivers/serial/Kconfig
> +++ work/drivers/serial/Kconfig	2010-01-21 19:55:26.000000000 +0900
> @@ -996,7 +996,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
>  
>  config SERIAL_SH_SCI
>  	tristate "SuperH SCI(F) serial port support"
> -	depends on HAVE_CLK && (SUPERH || H8300)
> +	depends on HAVE_CLK && (SUPERH || H8300 || ARCH_SHMOBILE)
>  	select SERIAL_CORE
>  
>  config SERIAL_SH_SCI_NR_UARTS
> --- 0001/drivers/serial/sh-sci.h
> +++ work/drivers/serial/sh-sci.h	2010-01-21 19:57:10.000000000 +0900
> @@ -174,6 +174,10 @@
>  # define SCSPTR3 0xffc60020		/* 16 bit SCIF */
>  # define SCIF_ORER 0x0001		/* Overrun error bit */
>  # define SCSCR_INIT(port)	0x38	/* TIE=0,RIE=0,TE=1,RE=1,REIE=1 */
> +#elif defined(CONFIG_ARCH_SHMOBILE)
> +# define SCSCR_INIT(port)	0x0030
> +# define SCIF_ONLY
> +# define SCIF_ORER		0x0200
>  #else
>  # error CPU subtype not defined
>  #endif
>        defined(CONFIG_CPU_SUBTYPE_SH7724)

SCIF_ONLY should be killed off, nothing is checking for it these days. I
thought they were all gone already, but it looks like SH7757 snuck one
back in, too..

  reply	other threads:[~2010-01-29  2:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 12:40 [PATCH 00/06] ARM: Initial SuperH Mobile ARM support Magnus Damm
2010-01-28 12:40 ` Magnus Damm
2010-01-28 12:40 ` [PATCH 01/06] ARM: SuperH Mobile ARM, sh7367 and G3EVM support Magnus Damm
2010-01-28 12:40   ` Magnus Damm
2010-01-28 22:08   ` Russell King - ARM Linux
2010-01-28 22:08     ` Russell King - ARM Linux
2010-01-29 11:26     ` Magnus Damm
2010-01-29 11:26       ` Magnus Damm
2010-02-01 14:10   ` Pavel Machek
2010-02-01 14:10     ` Pavel Machek
2010-02-01 14:26     ` Paul Mundt
2010-02-01 14:26       ` Paul Mundt
2010-02-01 16:19       ` Linus Walleij
2010-02-01 16:19         ` Linus Walleij
2010-02-02  0:12         ` Paul Mundt
2010-02-02  0:12           ` Paul Mundt
2010-01-28 12:40 ` [PATCH 02/06] ARM: Add sh7377 and G4EVM support Magnus Damm
2010-01-28 12:40   ` Magnus Damm
2010-01-28 12:41 ` [PATCH 03/06] ARM: Add sh7372 and AP4EVB support Magnus Damm
2010-01-28 12:41   ` Magnus Damm
2010-01-28 22:19   ` Russell King - ARM Linux
2010-01-28 22:19     ` Russell King - ARM Linux
2010-01-28 12:41 ` [PATCH 04/06] sh: Build drivers/sh for SuperH Mobile ARM Magnus Damm
2010-01-28 12:41   ` Magnus Damm
2010-01-28 12:41 ` [PATCH 05/06] sh: Let INTC set IRQF_VALID on ARM platforms Magnus Damm
2010-01-28 12:41   ` Magnus Damm
2010-01-29  2:50   ` Paul Mundt
2010-01-29  2:50     ` Paul Mundt
2010-01-28 12:41 ` [PATCH 06/06] sh-sci: Preliminary SuperH Mobile ARM support Magnus Damm
2010-01-28 12:41   ` Magnus Damm
2010-01-29  2:52   ` Paul Mundt [this message]
2010-01-29  2:52     ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129025242.GC7396@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.