From: Wu Fengguang <fengguang.wu@intel.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, y-goto@jp.fujitsu.com,
haveblue@us.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
ak@linux.intel.com, hpa@kernel.org, haicheng.li@intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [Patch - Resend v4] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel
Date: Mon, 1 Feb 2010 12:41:24 +0800 [thread overview]
Message-ID: <20100201044124.GA29097@localhost> (raw)
In-Reply-To: <20100201041253.GA1028@shaohui>
Shaohui,
Some style nitpicks..
> #ifdef CONFIG_MEMORY_HOTPLUG
> +/**
Should use /* here.
> + * After memory hotplug, the variable max_pfn, max_low_pfn and high_memory will
> + * be affected, it will be updated in this function.
> + */
> +static inline void __meminit update_end_of_memory_vars(u64 start,
The "inline" and "__meminit" are both redundant here.
> + max_low_pfn = max_pfn = end_pfn;
One assignment per line is preferred.
Thanks,
Fengguang
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, y-goto@jp.fujitsu.com,
haveblue@us.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
ak@linux.intel.com, hpa@kernel.org, haicheng.li@intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [Patch - Resend v4] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel
Date: Mon, 1 Feb 2010 12:41:24 +0800 [thread overview]
Message-ID: <20100201044124.GA29097@localhost> (raw)
In-Reply-To: <20100201041253.GA1028@shaohui>
Shaohui,
Some style nitpicks..
> #ifdef CONFIG_MEMORY_HOTPLUG
> +/**
Should use /* here.
> + * After memory hotplug, the variable max_pfn, max_low_pfn and high_memory will
> + * be affected, it will be updated in this function.
> + */
> +static inline void __meminit update_end_of_memory_vars(u64 start,
The "inline" and "__meminit" are both redundant here.
> + max_low_pfn = max_pfn = end_pfn;
One assignment per line is preferred.
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-01 4:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 4:12 [Patch - Resend v4] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel Shaohui Zheng
2010-02-01 4:41 ` Wu Fengguang [this message]
2010-02-01 4:41 ` Wu Fengguang
2010-02-01 12:22 ` Shaohui Zheng
2010-02-01 12:22 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201044124.GA29097@localhost \
--to=fengguang.wu@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=haicheng.li@intel.com \
--cc=haveblue@us.ibm.com \
--cc=hpa@kernel.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohui.zheng@linux.intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.