From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Naphtali Sprei <nsprei@redhat.com>,
qemu-devel@nongnu.org, Sheng Yang <sheng@linux.intel.com>
Subject: Re: [Qemu-devel] Re: [PATCH] block: Enable fall-back to read-only for backing file
Date: Mon, 1 Feb 2010 10:06:49 +0100 [thread overview]
Message-ID: <20100201090649.GA20918@lst.de> (raw)
In-Reply-To: <4B6694C8.4010703@redhat.com>
On Mon, Feb 01, 2010 at 09:46:00AM +0100, Kevin Wolf wrote:
> > Is it better to always open the backing file with read-only mode ? this will be more consistent/predictable ?
>
> I would love to open them read-only unconditionally, but we can't. It
> would break the commit monitor command. I think the read-only fallback
> is appropriate for backing files.
The clean way would be to require an explicit BACKING_WRITEABLE flag
if we want to commit to it. But I suspect it's too late to refit that
now.
next prev parent reply other threads:[~2010-02-01 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 16:49 [Qemu-devel] [PATCH] block: Enable fall-back to read-only for backing file Naphtali Sprei
2010-02-01 8:46 ` [Qemu-devel] " Kevin Wolf
2010-02-01 9:06 ` Christoph Hellwig [this message]
2010-02-01 9:25 ` Alexander Graf
2010-02-01 9:27 ` Christoph Hellwig
2010-02-01 10:05 ` Alexander Graf
2010-02-01 12:32 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201090649.GA20918@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=nsprei@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.