From: Kevin Wolf <kwolf@redhat.com>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: qemu-devel@nongnu.org, Sheng Yang <sheng@linux.intel.com>
Subject: [Qemu-devel] Re: [PATCH] block: Enable fall-back to read-only for backing file
Date: Mon, 01 Feb 2010 09:46:00 +0100 [thread overview]
Message-ID: <4B6694C8.4010703@redhat.com> (raw)
In-Reply-To: <4B65B4B7.2030700@redhat.com>
Am 31.01.2010 17:49, schrieb Naphtali Sprei:
> There's a problem when trying to use an image file based on a read-only image file.
> Before this patch, qemu fails to open the base image and stop.
> With this patch, qemu tries to open the backing file with same permissions as the "top" file,
> but if it fails, qemu tries to open it with read-only permissions. If succeeded it goes on.
>
> This fall-back works both for an image file based on a read-only file
> and also for a read-only file opened with the snapshot attribute/mode (where the real file is the backing file
> for the snapshot file).
>
> Is it better to always open the backing file with read-only mode ? this will be more consistent/predictable ?
I would love to open them read-only unconditionally, but we can't. It
would break the commit monitor command. I think the read-only fallback
is appropriate for backing files.
Kevin
next prev parent reply other threads:[~2010-02-01 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 16:49 [Qemu-devel] [PATCH] block: Enable fall-back to read-only for backing file Naphtali Sprei
2010-02-01 8:46 ` Kevin Wolf [this message]
2010-02-01 9:06 ` [Qemu-devel] " Christoph Hellwig
2010-02-01 9:25 ` Alexander Graf
2010-02-01 9:27 ` Christoph Hellwig
2010-02-01 10:05 ` Alexander Graf
2010-02-01 12:32 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6694C8.4010703@redhat.com \
--to=kwolf@redhat.com \
--cc=nsprei@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.