From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
ysato@users.sourceforge.jp, takata@linux-m32r.org,
geert@linux-m68k.org, zippel@linux-m68k.org, gerg@uclinux.org,
ralf@linux-mips.org, benh@kernel.crashing.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
lethal@linux-sh.org, davem@davemloft.net, jdike@addtoit.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 3/6] generic sys_ipc wrapper
Date: Mon, 1 Feb 2010 23:42:19 +0000 [thread overview]
Message-ID: <20100201234219.GG21693@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20100201185544.GC11045@lst.de>
On Mon, Feb 01, 2010 at 07:55:44PM +0100, Christoph Hellwig wrote:
> Add a generic implementation of the ipc demultiplexer syscall. Except for
> s390 and sparc64 all implementations of the sys_ipc are nearly identical.
>
> There are slight differences in the types of the parameters, where mips
> and powerpc as the only 64-bit architectures with sys_ipc use unsigned long
> for the "third" argument as it gets casted to a pointer later, while it
> traditionally is an "int" like most other paramters. frv goes even further
> and uses unsigned long for all parameters execept for "ptr" which is a pointer
> type everywhere. The change from int to unsigned long for "third" and back
> to "int" for the others on frv should be fine due to the in-register calling
> conventions for syscalls (we already had a similar issue with the generic
> sys_ptrace), but I'd prefer to have the arch maintainers looks over this
> in details.
From an ARM perspective, it looks like nothing actually changes, so...
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
WARNING: multiple messages have this Message-ID (diff)
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
ysato@users.sourceforge.jp, takata@linux-m32r.org,
geert@linux-m68k.org, zippel@linux-m68k.org, gerg@uclinux.org,
ralf@linux-mips.org, benh@kernel.crashing.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
lethal@linux-sh.org, davem@davemloft.net, jdike@addtoit.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 3/6] generic sys_ipc wrapper
Date: Mon, 1 Feb 2010 23:42:19 +0000 [thread overview]
Message-ID: <20100201234219.GG21693@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20100201185544.GC11045@lst.de>
On Mon, Feb 01, 2010 at 07:55:44PM +0100, Christoph Hellwig wrote:
> Add a generic implementation of the ipc demultiplexer syscall. Except for
> s390 and sparc64 all implementations of the sys_ipc are nearly identical.
>
> There are slight differences in the types of the parameters, where mips
> and powerpc as the only 64-bit architectures with sys_ipc use unsigned long
> for the "third" argument as it gets casted to a pointer later, while it
> traditionally is an "int" like most other paramters. frv goes even further
> and uses unsigned long for all parameters execept for "ptr" which is a pointer
> type everywhere. The change from int to unsigned long for "third" and back
> to "int" for the others on frv should be fine due to the in-register calling
> conventions for syscalls (we already had a similar issue with the generic
> sys_ptrace), but I'd prefer to have the arch maintainers looks over this
> in details.
>From an ARM perspective, it looks like nothing actually changes, so...
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2010-02-01 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 18:55 [PATCH 3/6] generic sys_ipc wrapper Christoph Hellwig
2010-02-01 22:25 ` H. Peter Anvin
2010-02-01 23:42 ` Russell King [this message]
2010-02-01 23:42 ` Russell King
2010-02-02 1:04 ` Greg Ungerer
2010-02-02 1:36 ` Paul Mundt
2010-02-08 14:34 ` David Howells
2010-02-08 15:22 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201234219.GG21693@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=jesper.nilsson@axis.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.