All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] Add radio access atom and driver API
@ 2010-02-02 22:38 Aki Niemi
  2010-02-02 22:38 ` [PATCH 2/3] Add PN_GSS code points and debugging Aki Niemi
  2010-02-03  0:04 ` [PATCH 1/3] Add radio access atom and driver API Denis Kenzior
  0 siblings, 2 replies; 11+ messages in thread
From: Aki Niemi @ 2010-02-02 22:38 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 14252 bytes --]

This atom provides access to the modem's radio access properties. It
currently includes a single rw property, namely the radio access
selection mode setting.

This allows the user to query and select the used radio access
technology preference. In dual mode, either 2G or 3G is used depending
on reception. 2G only mode or 3G only mode force selection of the
respective access only.

In the future, this atom could be extended, if necessary, to handle
other radio access related modem features such as CELL_DCH status,
UTRAN channel, or frequency band.
---
 Makefile.am            |    6 +-
 include/radio-access.h |   72 ++++++++++
 src/ofono.h            |    2 +
 src/radio-access.c     |  354 ++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 432 insertions(+), 2 deletions(-)
 create mode 100644 include/radio-access.h
 create mode 100644 src/radio-access.c

diff --git a/Makefile.am b/Makefile.am
index 33339df..a18e4b9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -11,7 +11,8 @@ include_HEADERS = include/log.h include/plugin.h include/history.h \
 			include/sms.h include/sim.h include/message-waiting.h \
 			include/netreg.h include/voicecall.h include/devinfo.h \
 			include/cbs.h include/call-volume.h \
-			include/gprs.h include/gprs-context.h
+			include/gprs.h include/gprs-context.h \
+			include/radio-access.h
 
 nodist_include_HEADERS = include/version.h
 
@@ -224,7 +225,8 @@ src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) \
 			src/phonebook.c src/history.c src/message-waiting.c \
 			src/simutil.h src/simutil.c src/storage.h \
 			src/storage.c src/cbs.c src/watch.c src/call-volume.c \
-			src/gprs.c src/idmap.h src/idmap.c
+			src/gprs.c src/idmap.h src/idmap.c \
+			src/radio-access.c
 
 src_ofonod_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@ -ldl
 
diff --git a/include/radio-access.h b/include/radio-access.h
new file mode 100644
index 0000000..6677573
--- /dev/null
+++ b/include/radio-access.h
@@ -0,0 +1,72 @@
+/*
+ *
+ *  oFono - Open Source Telephony
+ *
+ *  Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ */
+
+#ifndef __OFONO_RADIO_ACCESS_H
+#define __OFONO_RADIO_ACCESS_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <ofono/types.h>
+
+struct ofono_radio_access;
+
+typedef void (*ofono_radio_access_mode_set_cb_t)(const struct ofono_error *error,
+							void *data);
+typedef void (*ofono_radio_access_mode_query_cb_t)(const struct ofono_error *error,
+							int mode, void *data);
+
+struct ofono_radio_access_driver {
+	const char *name;
+	int (*probe)(struct ofono_radio_access *radio_access,
+			unsigned int vendor,
+			void *data);
+	void (*remove)(struct ofono_radio_access *radio_access);
+	void (*query_mode)(struct ofono_radio_access *radio_access,
+				ofono_radio_access_mode_query_cb_t cb, void *data);
+	void (*set_mode)(struct ofono_radio_access *radio_access, int mode,
+				ofono_radio_access_mode_set_cb_t cb, void *data);
+};
+
+void ofono_radio_access_mode_notify(struct ofono_radio_access *radio_access,
+					int mode);
+
+int ofono_radio_access_driver_register(const struct ofono_radio_access_driver *d);
+void ofono_radio_access_driver_unregister(const struct ofono_radio_access_driver *d);
+
+struct ofono_radio_access *ofono_radio_access_create(struct ofono_modem *modem,
+						unsigned int vendor,
+						const char *driver,
+						void *data);
+
+void ofono_radio_access_register(struct ofono_radio_access *radio_access);
+void ofono_radio_access_remove(struct ofono_radio_access *radio_access);
+
+void ofono_radio_access_set_data(struct ofono_radio_access *radio_access,
+					void *data);
+void *ofono_radio_access_get_data(struct ofono_radio_access *radio_access);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __OFONO_RADIO_ACCESS_H */
diff --git a/src/ofono.h b/src/ofono.h
index 379f413..c519eef 100644
--- a/src/ofono.h
+++ b/src/ofono.h
@@ -113,6 +113,7 @@ enum ofono_atom_type {
 	OFONO_ATOM_TYPES_CALL_VOLUME = 15,
 	OFONO_ATOM_TYPE_GPRS = 16,
 	OFONO_ATOM_TYPE_GPRS_CONTEXT = 17,
+	OFONO_ATOM_TYPE_RADIO_ACCESS = 18,
 };
 
 enum ofono_atom_watch_condition {
@@ -168,6 +169,7 @@ void __ofono_atom_free(struct ofono_atom *atom);
 #include <ofono/voicecall.h>
 #include <ofono/gprs.h>
 #include <ofono/gprs-context.h>
+#include <ofono/radio-access.h>
 
 #include <ofono/sim.h>
 
diff --git a/src/radio-access.c b/src/radio-access.c
new file mode 100644
index 0000000..ba34c71
--- /dev/null
+++ b/src/radio-access.c
@@ -0,0 +1,354 @@
+/*
+ *
+ *  oFono - Open Source Telephony
+ *
+ *  Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <string.h>
+#include <stdio.h>
+#include <errno.h>
+
+#include <glib.h>
+#include <gdbus.h>
+
+#include "ofono.h"
+#include "common.h"
+
+#define RADIO_ACCESS_INTERFACE "org.ofono.RadioAccess"
+#define RADIO_ACCESS_INTERFACE "org.ofono.RadioAccess"
+
+static GSList *g_drivers = NULL;
+
+enum radio_access_mode {
+	RADIO_ACCESS_MODE_DUAL = 0,
+	RADIO_ACCESS_MODE_2G = 1,
+	RADIO_ACCESS_MODE_3G = 2
+};
+
+struct ofono_radio_access {
+	DBusMessage *pending;
+	int mode;
+	int pending_mode;
+	const struct ofono_radio_access_driver *driver;
+	void *driver_data;
+	struct ofono_atom *atom;
+};
+
+static const char *radio_access_mode_to_string(int mode)
+{
+	switch (mode) {
+	case RADIO_ACCESS_MODE_DUAL:
+		return "2g+3g";
+
+	case RADIO_ACCESS_MODE_2G:
+		return "2g";
+
+	case RADIO_ACCESS_MODE_3G:
+		return "3g";
+
+	default:
+		return "unknown";
+	}
+}
+
+static int string_to_radio_access_mode(const char *mode)
+{
+	if (g_strcmp0(mode, "2g+3g") == 0)
+		return RADIO_ACCESS_MODE_DUAL;
+
+	if (g_strcmp0(mode, "2g") == 0)
+		return RADIO_ACCESS_MODE_2G;
+
+	if (g_strcmp0(mode, "3g") == 0)
+		return RADIO_ACCESS_MODE_3G;
+
+	return -1;
+}
+
+static void ra_mode_query_callback(const struct ofono_error *error, int mode,
+					void *data)
+{
+	struct ofono_radio_access *ra = data;
+
+	if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
+		ofono_debug("Error during radio access mode query");
+		return;
+	}
+
+	ofono_radio_access_mode_notify(ra, mode);
+}
+
+static void ra_mode_set_callback(const struct ofono_error *error, void *data)
+{
+	struct ofono_radio_access *ra = data;
+	DBusMessage *reply;
+
+	if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
+		ofono_debug("Error setting radio access mode");
+		ra->pending_mode = ra->mode;
+		reply = __ofono_error_failed(ra->pending);
+		__ofono_dbus_pending_reply(&ra->pending, reply);
+		return;
+	}
+
+	reply = dbus_message_new_method_return(ra->pending);
+	__ofono_dbus_pending_reply(&ra->pending, reply);
+
+	ofono_radio_access_mode_notify(ra, ra->pending_mode);
+}
+
+static DBusMessage *ra_get_properties(DBusConnection *conn, DBusMessage *msg,
+					void *data)
+{
+	struct ofono_radio_access *ra = data;
+	DBusMessage *reply;
+	DBusMessageIter iter;
+	DBusMessageIter dict;
+
+	const char *mode = radio_access_mode_to_string(ra->mode);
+
+	reply = dbus_message_new_method_return(msg);
+	if (!reply)
+		return NULL;
+
+	dbus_message_iter_init_append(reply, &iter);
+
+	dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY,
+					OFONO_PROPERTIES_ARRAY_SIGNATURE,
+					&dict);
+
+	ofono_dbus_dict_append(&dict, "Mode", DBUS_TYPE_STRING, &mode);
+
+	dbus_message_iter_close_container(&iter, &dict);
+
+	return reply;
+}
+
+static DBusMessage *ra_set_property(DBusConnection *conn, DBusMessage *msg,
+					void *data)
+{
+	struct ofono_radio_access *ra = data;
+	DBusMessageIter iter;
+	DBusMessageIter var;
+	const char *property;
+
+	if (ra->pending)
+		return __ofono_error_busy(msg);
+
+	if (!dbus_message_iter_init(msg, &iter))
+		return __ofono_error_invalid_args(msg);
+
+	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING)
+		return __ofono_error_invalid_args(msg);
+
+	dbus_message_iter_get_basic(&iter, &property);
+	dbus_message_iter_next(&iter);
+
+	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT)
+		return __ofono_error_invalid_args(msg);
+
+	dbus_message_iter_recurse(&iter, &var);
+
+	if (g_strcmp0(property, "Mode") == 0) {
+		const char *value;
+		int mode = -1;
+
+		if (!ra->driver->set_mode)
+			return __ofono_error_not_implemented(msg);
+
+		if (dbus_message_iter_get_arg_type(&var) != DBUS_TYPE_STRING)
+			return __ofono_error_invalid_args(msg);
+
+		dbus_message_iter_get_basic(&var, &value);
+		mode = string_to_radio_access_mode(value);
+
+		if (ra->mode == mode)
+			return dbus_message_new_method_return(msg);
+
+		ra->pending = dbus_message_ref(msg);
+		ra->pending_mode = mode;
+
+		ra->driver->set_mode(ra, mode, ra_mode_set_callback, ra);
+
+		return NULL;
+	}
+
+	return __ofono_error_invalid_args(msg);
+}
+
+static GDBusMethodTable ra_methods[] = {
+	{ "GetProperties",	"",	"a{sv}",	ra_get_properties,
+							G_DBUS_METHOD_FLAG_ASYNC },
+
+	{ "SetProperty",	"sv",	"",		ra_set_property,
+							G_DBUS_METHOD_FLAG_ASYNC },
+	{ }
+};
+
+static GDBusSignalTable ra_signals[] = {
+	{ "PropertyChanged",	"sv" },
+	{ }
+};
+
+void ofono_radio_access_mode_notify(struct ofono_radio_access *ra, int mode)
+{
+	DBusConnection *conn = ofono_dbus_get_connection();
+
+	if (ra->mode == mode)
+		return;
+
+	ra->mode = mode;
+
+	if (mode != -1) {
+		const char *path = __ofono_atom_get_path(ra->atom);
+		const char *str_mode = radio_access_mode_to_string(mode);
+
+		ofono_dbus_signal_property_changed(conn, path,
+						RADIO_ACCESS_INTERFACE,
+						"Mode", DBUS_TYPE_STRING,
+						&str_mode);
+	}
+}
+
+int ofono_radio_access_driver_register(const struct ofono_radio_access_driver *d)
+{
+	DBG("driver: %p, name: %s", d, d->name);
+
+	if (!d || !d->probe)
+		return -EINVAL;
+
+	g_drivers = g_slist_prepend(g_drivers, (void *)d);
+
+	return 0;
+}
+
+void ofono_radio_access_driver_unregister(const struct ofono_radio_access_driver *d)
+{
+	DBG("driver: %p, name: %s", d, d->name);
+
+	if (!d)
+		return;
+
+	g_drivers = g_slist_remove(g_drivers, (void *)d);
+}
+
+static void radio_access_unregister(struct ofono_atom *atom)
+{
+	struct ofono_radio_access *ra = __ofono_atom_get_data(atom);
+	const char *path = __ofono_atom_get_path(ra->atom);
+	DBusConnection *conn = ofono_dbus_get_connection();
+	struct ofono_modem *modem = __ofono_atom_get_modem(ra->atom);
+
+	ofono_modem_remove_interface(modem, RADIO_ACCESS_INTERFACE);
+	g_dbus_unregister_interface(conn, path, RADIO_ACCESS_INTERFACE);
+}
+
+static void radio_access_remove(struct ofono_atom *atom)
+{
+	struct ofono_radio_access *ra = __ofono_atom_get_data(atom);
+
+	DBG("atom: %p", atom);
+
+	if (!ra)
+		return;
+
+	if (ra->driver && ra->driver->remove)
+		ra->driver->remove(ra);
+
+	g_free(ra);
+}
+
+struct ofono_radio_access *ofono_radio_access_create(struct ofono_modem *modem,
+							unsigned int vendor,
+							const char *driver,
+							void *data)
+{
+	struct ofono_radio_access *ra;
+	GSList *l;
+
+	if (!driver)
+		return NULL;
+
+	ra = g_try_new0(struct ofono_radio_access, 1);
+	if (!ra)
+		return NULL;
+
+	ra->mode = -1;
+
+	ra->atom = __ofono_modem_add_atom(modem, OFONO_ATOM_TYPE_RADIO_ACCESS,
+						radio_access_remove, ra);
+
+	for (l = g_drivers; l; l = l->next) {
+		const struct ofono_radio_access_driver *drv = l->data;
+
+		if (g_strcmp0(drv->name, driver) != 0)
+			continue;
+
+		if (drv->probe(ra, vendor, data) < 0)
+			continue;
+
+		ra->driver = drv;
+		break;
+	}
+
+	return ra;
+}
+
+void ofono_radio_access_register(struct ofono_radio_access *ra)
+{
+	DBusConnection *conn = ofono_dbus_get_connection();
+	struct ofono_modem *modem = __ofono_atom_get_modem(ra->atom);
+	const char *path = __ofono_atom_get_path(ra->atom);
+
+	if (!g_dbus_register_interface(conn, path,
+					RADIO_ACCESS_INTERFACE,
+					ra_methods, ra_signals, NULL, ra,
+					NULL)) {
+		ofono_error("Could not create %s interface",
+				RADIO_ACCESS_INTERFACE);
+
+		return;
+	}
+
+	ofono_modem_add_interface(modem, RADIO_ACCESS_INTERFACE);
+
+	if (ra->driver->query_mode)
+		ra->driver->query_mode(ra, ra_mode_query_callback, ra);
+
+	__ofono_atom_register(ra->atom, radio_access_unregister);
+}
+
+void ofono_radio_access_remove(struct ofono_radio_access *ra)
+{
+	__ofono_atom_free(ra->atom);
+}
+
+void ofono_radio_access_set_data(struct ofono_radio_access *ra,
+					void *data)
+{
+	ra->driver_data = data;
+}
+
+void *ofono_radio_access_get_data(struct ofono_radio_access *ra)
+{
+	return ra->driver_data;
+}
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Add radio access interface, take 2
@ 2010-02-03 15:32 Aki Niemi
  2010-02-03 15:32 ` [PATCH 1/3] Add radio access atom and driver API Aki Niemi
  0 siblings, 1 reply; 11+ messages in thread
From: Aki Niemi @ 2010-02-03 15:32 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi,

I've updated this set of patches based on feedback. The atom now
exposes two properties: selection mode and link state. Comments
welcome!

Cheers,
Aki


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-02-03 17:03 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-02 22:38 [PATCH 1/3] Add radio access atom and driver API Aki Niemi
2010-02-02 22:38 ` [PATCH 2/3] Add PN_GSS code points and debugging Aki Niemi
2010-02-02 22:38   ` [PATCH 3/3] Add isimodem radio access driver Aki Niemi
2010-02-03  0:04 ` [PATCH 1/3] Add radio access atom and driver API Denis Kenzior
2010-02-03  2:35   ` Bastian, Waldo
2010-02-03  4:02     ` Denis Kenzior
2010-02-03  5:06       ` Bastian, Waldo
2010-02-03  9:30       ` Aki Niemi
2010-02-03  9:21   ` Aki Niemi
2010-02-03 17:03     ` Denis Kenzior
  -- strict thread matches above, loose matches on Subject: below --
2010-02-03 15:32 Add radio access interface, take 2 Aki Niemi
2010-02-03 15:32 ` [PATCH 1/3] Add radio access atom and driver API Aki Niemi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.