All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: David Rientjes <rientjes@google.com>
Cc: balbir@linux.vnet.ibm.com, riel@redhat.com, l.lunak@suse.cz,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
	npiggin@suse.de, jkosina@suse.cz
Subject: Re: Improving OOM killer
Date: Wed, 3 Feb 2010 20:29:31 +0100	[thread overview]
Message-ID: <201002032029.34145.elendil@planet.nl> (raw)
In-Reply-To: <alpine.DEB.2.00.1002031021190.14088@chino.kir.corp.google.com>

David Rientjes wrote:
> /*
> * /proc/pid/oom_adj ranges from -1000 to +1000 to either
> * completely disable oom killing or always prefer it.
> */
> points += p->signal->oom_adj;
> 

Wouldn't that cause a rather huge compatibility issue given that the 
current oom_adj works in a totally different way:

! 3.1 /proc/<pid>/oom_adj - Adjust the oom-killer score
! ------------------------------------------------------
! This file can be used to adjust the score used to select which processes
! should be killed in an  out-of-memory  situation.  Giving it a high score
! will increase the likelihood of this process being killed by the
! oom-killer.  Valid values are in the range -16 to +15, plus the special
! value -17, which disables oom-killing altogether for this process.

?

Cheers,
FJP

WARNING: multiple messages have this Message-ID (diff)
From: Frans Pop <elendil@planet.nl>
To: David Rientjes <rientjes@google.com>
Cc: balbir@linux.vnet.ibm.com, riel@redhat.com, l.lunak@suse.cz,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
	npiggin@suse.de, jkosina@suse.cz
Subject: Re: Improving OOM killer
Date: Wed, 3 Feb 2010 20:29:31 +0100	[thread overview]
Message-ID: <201002032029.34145.elendil@planet.nl> (raw)
In-Reply-To: <alpine.DEB.2.00.1002031021190.14088@chino.kir.corp.google.com>

David Rientjes wrote:
> /*
> * /proc/pid/oom_adj ranges from -1000 to +1000 to either
> * completely disable oom killing or always prefer it.
> */
> points += p->signal->oom_adj;
> 

Wouldn't that cause a rather huge compatibility issue given that the 
current oom_adj works in a totally different way:

! 3.1 /proc/<pid>/oom_adj - Adjust the oom-killer score
! ------------------------------------------------------
! This file can be used to adjust the score used to select which processes
! should be killed in an  out-of-memory  situation.  Giving it a high score
! will increase the likelihood of this process being killed by the
! oom-killer.  Valid values are in the range -16 to +15, plus the special
! value -17, which disables oom-killing altogether for this process.

?

Cheers,
FJP

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-02-03 19:43 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 22:02 Improving OOM killer Lubos Lunak
2010-02-01 22:02 ` Lubos Lunak
2010-02-01 23:53 ` David Rientjes
2010-02-01 23:53   ` David Rientjes
2010-02-02 21:10   ` Lubos Lunak
2010-02-02 21:10     ` Lubos Lunak
2010-02-03  1:41     ` David Rientjes
2010-02-03  1:41       ` David Rientjes
2010-02-03  1:52       ` KAMEZAWA Hiroyuki
2010-02-03  1:52         ` KAMEZAWA Hiroyuki
2010-02-03  2:12         ` David Rientjes
2010-02-03  2:12           ` David Rientjes
2010-02-03  2:12           ` KAMEZAWA Hiroyuki
2010-02-03  2:12             ` KAMEZAWA Hiroyuki
2010-02-03  2:36             ` [patch] sysctl: clean up vm related variable declarations David Rientjes
2010-02-03  2:36               ` David Rientjes
2010-02-03  8:07               ` KOSAKI Motohiro
2010-02-03  8:07                 ` KOSAKI Motohiro
2010-02-03  8:17               ` Balbir Singh
2010-02-03  8:17                 ` Balbir Singh
2010-02-03 22:54       ` Improving OOM killer Lubos Lunak
2010-02-03 22:54         ` Lubos Lunak
2010-02-04  0:00         ` David Rientjes
2010-02-04  0:00           ` David Rientjes
2010-02-03  7:50 ` KOSAKI Motohiro
2010-02-03  7:50   ` KOSAKI Motohiro
2010-02-03  9:40   ` David Rientjes
2010-02-03  9:40     ` David Rientjes
2010-02-03  8:57 ` Balbir Singh
2010-02-03  8:57   ` Balbir Singh
2010-02-03 12:10   ` Lubos Lunak
2010-02-03 12:10     ` Lubos Lunak
2010-02-03 12:25     ` Balbir Singh
2010-02-03 12:25       ` Balbir Singh
2010-02-03 15:00       ` Minchan Kim
2010-02-03 15:00         ` Minchan Kim
2010-02-03 16:06         ` Minchan Kim
2010-02-03 16:06           ` Minchan Kim
2010-02-03 21:22       ` Lubos Lunak
2010-02-03 21:22         ` Lubos Lunak
2010-02-03 14:49 ` Rik van Riel
2010-02-03 14:49   ` Rik van Riel
2010-02-03 17:01   ` Balbir Singh
2010-02-03 17:01     ` Balbir Singh
2010-02-03 18:58     ` David Rientjes
2010-02-03 18:58       ` David Rientjes
2010-02-03 19:29       ` Frans Pop [this message]
2010-02-03 19:29         ` Frans Pop
2010-02-03 19:52         ` David Rientjes
2010-02-03 19:52           ` David Rientjes
2010-02-03 20:12           ` Frans Pop
2010-02-03 20:12             ` Frans Pop
2010-02-03 20:26             ` David Rientjes
2010-02-03 20:26               ` David Rientjes
2010-02-03 22:55       ` Lubos Lunak
2010-02-03 22:55         ` Lubos Lunak
2010-02-04  0:05         ` David Rientjes
2010-02-04  0:05           ` David Rientjes
2010-02-04  0:18           ` Rik van Riel
2010-02-04  0:18             ` Rik van Riel
2010-02-04 21:48             ` David Rientjes
2010-02-04 21:48               ` David Rientjes
2010-02-04 22:06               ` Rik van Riel
2010-02-04 22:06                 ` Rik van Riel
2010-02-04 22:14                 ` David Rientjes
2010-02-04 22:14                   ` David Rientjes
2010-02-10 20:54                   ` Lubos Lunak
2010-02-10 20:54                     ` Lubos Lunak
2010-02-10 21:10                     ` Rik van Riel
2010-02-10 21:10                       ` Rik van Riel
2010-02-10 21:29                       ` Lubos Lunak
2010-02-10 21:29                         ` Lubos Lunak
2010-02-10 22:18                       ` Alan Cox
2010-02-10 22:18                         ` Alan Cox
2010-02-10 22:31                         ` David Rientjes
2010-02-10 22:31                           ` David Rientjes
2010-02-11  9:50                         ` Lubos Lunak
2010-02-11  9:50                           ` Lubos Lunak
2010-02-04 22:31               ` Frans Pop
2010-02-04 22:31                 ` Frans Pop
2010-02-04 22:53                 ` David Rientjes
2010-02-04 22:53                   ` David Rientjes
2010-02-04  7:58           ` Lubos Lunak
2010-02-04  7:58             ` Lubos Lunak
2010-02-04 21:34             ` David Rientjes
2010-02-04 21:34               ` David Rientjes
2010-02-10 20:54               ` Lubos Lunak
2010-02-10 20:54                 ` Lubos Lunak
2010-02-10 21:09                 ` Rik van Riel
2010-02-10 21:09                   ` Rik van Riel
2010-02-10 21:34                   ` Lubos Lunak
2010-02-10 21:34                     ` Lubos Lunak
2010-02-10 22:25                 ` David Rientjes
2010-02-10 22:25                   ` David Rientjes
2010-02-11 10:16                   ` Lubos Lunak
2010-02-11 10:16                     ` Lubos Lunak
2010-02-11 21:17                     ` David Rientjes
2010-02-11 21:17                       ` David Rientjes
2010-02-04  9:50           ` Jiri Kosina
2010-02-04  9:50             ` Jiri Kosina
2010-02-04 21:39             ` David Rientjes
2010-02-04 21:39               ` David Rientjes
2010-02-05  7:35               ` Oliver Neukum
2010-02-05  7:35                 ` Oliver Neukum
2010-02-10  3:10                 ` David Rientjes
2010-02-10  3:10                   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002032029.34145.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=jkosina@suse.cz \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=l.lunak@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.