[PATCH 1/3] hfp: create modem for new devices paired on runtime

[PATCH 1/3] hfp: create modem for new devices paired on runtime

[Gustavo F. Padovan]

[-- Attachment #1: Type: text/plain, Size: 4149 bytes --]

It listens the Paired property to create a modem to the recently paired
devices. It also renames added_watch to adapter_watch, a more proper
name.
---
 plugins/hfp.c |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++----
 1 files changed, 59 insertions(+), 5 deletions(-)

diff --git a/plugins/hfp.c b/plugins/hfp.c
index 981b05b..cd43af7 100644
--- a/plugins/hfp.c
+++ b/plugins/hfp.c
@@ -66,6 +66,7 @@ static const char *cmer_prefix[] = { "+CMER:", NULL };
 static const char *chld_prefix[] = { "+CHLD:", NULL };
 
 static DBusConnection *connection;
+static GHashTable *uuid_hash = NULL;
 
 static void hfp_debug(const char *str, void *user_data)
 {
@@ -410,6 +411,9 @@ static DBusMessage *hfp_agent_release(DBusConnection *conn,
 					DBusMessage *msg, void *data)
 {
 	struct ofono_modem *modem = data;
+	const char * path;
+
+	path = dbus_message_get_path(msg);
 
 	ofono_modem_remove(modem);
 
@@ -427,6 +431,10 @@ static int hfp_create_modem(const char *device)
 {
 	struct ofono_modem *modem;
 	struct hfp_data *data;
+	const char *path;
+
+	if (g_hash_table_lookup(uuid_hash, device))
+		return -EALREADY;
 
 	ofono_info("Using device: %s", device);
 
@@ -451,6 +459,9 @@ static int hfp_create_modem(const char *device)
 	ofono_modem_set_data(modem, data);
 	ofono_modem_register(modem);
 
+	path = ofono_modem_get_path(modem);
+	g_hash_table_insert(uuid_hash, g_strdup(device), g_strdup(path));
+
 	return 0;
 
 free:
@@ -624,6 +635,33 @@ static gboolean adapter_added(DBusConnection *connection, DBusMessage *message,
 	return TRUE;
 }
 
+static gboolean uuid_emitted(DBusConnection *connection, DBusMessage *message,
+				void *user_data)
+{
+	const char *device, *property;
+	DBusMessageIter iter;
+
+	dbus_message_iter_init(message, &iter);
+
+	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING)
+		return FALSE;
+
+	dbus_message_iter_get_basic(&iter, &property);
+	if (g_str_equal(property, "UUIDs") == FALSE)
+		return TRUE;
+
+	if (!dbus_message_iter_next(&iter))
+		return FALSE;
+
+	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT)
+		return FALSE;
+
+	device = dbus_message_get_path(message);
+	parse_uuids(&iter, device);
+
+	return TRUE;
+}
+
 static void list_adapters_cb(DBusPendingCall *call, gpointer user_data)
 {
 	DBusError err;
@@ -725,6 +763,8 @@ static void hfp_remove(struct ofono_modem *modem)
 
 	hfp_unregister_ofono_handsfree(modem);
 
+	g_hash_table_remove(uuid_hash, data->handsfree_path);
+
 	g_free(data->handsfree_path);
 	g_free(data);
 
@@ -798,7 +838,8 @@ static struct ofono_modem_driver hfp_driver = {
 	.post_sim	= hfp_post_sim,
 };
 
-static guint added_watch;
+static guint adapter_watch;
+static guint uuid_watch;
 
 static int hfp_init(void)
 {
@@ -809,12 +850,21 @@ static int hfp_init(void)
 
 	connection = ofono_dbus_get_connection();
 
-	added_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
+	adapter_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
 						BLUEZ_MANAGER_INTERFACE,
 						"AdapterAdded",
 						adapter_added, NULL, NULL);
 
-	if (added_watch == 0) {
+	uuid_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
+						BLUEZ_DEVICE_INTERFACE,
+						"PropertyChanged",
+						uuid_emitted, NULL, NULL);
+
+
+	uuid_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
+			g_free, g_free);
+
+	if (adapter_watch == 0 || uuid_watch == 0) {
 		err = -EIO;
 		goto remove;
 	}
@@ -828,7 +878,9 @@ static int hfp_init(void)
 	return 0;
 
 remove:
-	g_dbus_remove_watch(connection, added_watch);
+	g_dbus_remove_watch(connection, adapter_watch);
+	g_dbus_remove_watch(connection, uuid_watch);
+	g_hash_table_destroy(uuid_hash);
 
 	dbus_connection_unref(connection);
 
@@ -837,7 +889,9 @@ remove:
 
 static void hfp_exit(void)
 {
-	g_dbus_remove_watch(connection, added_watch);
+	g_dbus_remove_watch(connection, adapter_watch);
+	g_dbus_remove_watch(connection, uuid_watch);
+	g_hash_table_destroy(uuid_hash);
 
 	ofono_modem_driver_unregister(&hfp_driver);
 }
-- 
1.6.4.4

[PATCH 2/3] hfp: Don't call UnregisterAgent if a Release was received

[Gustavo F. Padovan]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Prevent to call UnregisterAgent on an already unregistered agent.
---
 plugins/hfp.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/plugins/hfp.c b/plugins/hfp.c
index cd43af7..4202ddf 100644
--- a/plugins/hfp.c
+++ b/plugins/hfp.c
@@ -760,8 +760,11 @@ static int hfp_probe(struct ofono_modem *modem)
 static void hfp_remove(struct ofono_modem *modem)
 {
 	struct hfp_data *data = ofono_modem_get_data(modem);
+	const char *obj_path = ofono_modem_get_path(modem);
 
-	hfp_unregister_ofono_handsfree(modem);
+	if (g_dbus_unregister_interface(connection, obj_path,
+					HFP_AGENT_INTERFACE))
+		hfp_unregister_ofono_handsfree(modem);
 
 	g_hash_table_remove(uuid_hash, data->handsfree_path);
 
@@ -804,10 +807,14 @@ static int hfp_disconnect_ofono_handsfree(struct ofono_modem *modem)
 
 static int hfp_disable(struct ofono_modem *modem)
 {
+	const char *obj_path = ofono_modem_get_path(modem);
+
 	DBG("%p", modem);
 
 	clear_data(modem);
 
+	g_dbus_unregister_interface(connection, obj_path, HFP_AGENT_INTERFACE);
+
 	hfp_disconnect_ofono_handsfree(modem);
 	return 0;
 }
-- 
1.6.4.4

[PATCH 3/3] hfp: wait Disconnect reply to power down the modem

[Gustavo F. Padovan]

[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]

---
 plugins/hfp.c |   26 ++++++++++++++++++++++++--
 1 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/plugins/hfp.c b/plugins/hfp.c
index 4202ddf..4f6da06 100644
--- a/plugins/hfp.c
+++ b/plugins/hfp.c
@@ -796,13 +796,34 @@ static int hfp_enable(struct ofono_modem *modem)
 	return -EINPROGRESS;
 }
 
+static void hfp_power_down(DBusPendingCall *call, gpointer user_data)
+{
+	struct ofono_modem *modem = user_data;
+	DBusMessage *reply;
+	DBusError derr;
+
+	reply = dbus_pending_call_steal_reply(call);
+
+	dbus_error_init(&derr);
+	if (dbus_set_error_from_message(&derr, reply)) {
+		ofono_debug("Disconnect reply: %s", derr.message);
+		dbus_error_free(&derr);
+		goto done;
+	}
+
+	ofono_modem_set_powered(modem, FALSE);
+
+done:
+	dbus_message_unref(reply);
+}
+
 static int hfp_disconnect_ofono_handsfree(struct ofono_modem *modem)
 {
 	struct hfp_data *data = ofono_modem_get_data(modem);
 
 	return send_method_call(BLUEZ_SERVICE, data->handsfree_path,
 				BLUEZ_GATEWAY_INTERFACE, "Disconnect",
-				NULL, NULL, DBUS_TYPE_INVALID);
+				hfp_power_down, modem, DBUS_TYPE_INVALID);
 }
 
 static int hfp_disable(struct ofono_modem *modem)
@@ -816,7 +837,8 @@ static int hfp_disable(struct ofono_modem *modem)
 	g_dbus_unregister_interface(connection, obj_path, HFP_AGENT_INTERFACE);
 
 	hfp_disconnect_ofono_handsfree(modem);
-	return 0;
+
+	return -EINPROGRESS;
 }
 
 static void hfp_pre_sim(struct ofono_modem *modem)
-- 
1.6.4.4

Re: [PATCH 1/3] hfp: create modem for new devices paired on runtime

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 4505 bytes --]

Hi Gustavo,

> It listens the Paired property to create a modem to the recently paired
> devices. It also renames added_watch to adapter_watch, a more proper
> name.
> ---
>  plugins/hfp.c |   64
>  ++++++++++++++++++++++++++++++++++++++++++++++++++++---- 1 files 
changed,
>  59 insertions(+), 5 deletions(-)
> 
> diff --git a/plugins/hfp.c b/plugins/hfp.c
> index 981b05b..cd43af7 100644
> --- a/plugins/hfp.c
> +++ b/plugins/hfp.c
> @@ -66,6 +66,7 @@ static const char *cmer_prefix[] = { "+CMER:", NULL };
>  static const char *chld_prefix[] = { "+CHLD:", NULL };
> 
>  static DBusConnection *connection;
> +static GHashTable *uuid_hash = NULL;
> 
>  static void hfp_debug(const char *str, void *user_data)
>  {
> @@ -410,6 +411,9 @@ static DBusMessage *hfp_agent_release(DBusConnection
>  *conn, DBusMessage *msg, void *data)
>  {
>  	struct ofono_modem *modem = data;
> +	const char * path;
> +
> +	path = dbus_message_get_path(msg);

Whats this part for?

> 
>  	ofono_modem_remove(modem);
> 
> @@ -427,6 +431,10 @@ static int hfp_create_modem(const char *device)
>  {
>  	struct ofono_modem *modem;
>  	struct hfp_data *data;
> +	const char *path;
> +
> +	if (g_hash_table_lookup(uuid_hash, device))
> +		return -EALREADY;

I suggest we move this check to parse_uuids.

> 
>  	ofono_info("Using device: %s", device);
> 
> @@ -451,6 +459,9 @@ static int hfp_create_modem(const char *device)
>  	ofono_modem_set_data(modem, data);
>  	ofono_modem_register(modem);
> 
> +	path = ofono_modem_get_path(modem);
> +	g_hash_table_insert(uuid_hash, g_strdup(device), g_strdup(path));
> +
>  	return 0;
> 
>  free:
> @@ -624,6 +635,33 @@ static gboolean adapter_added(DBusConnection
>  *connection, DBusMessage *message, return TRUE;
>  }
> 
> +static gboolean uuid_emitted(DBusConnection *connection, DBusMessage
>  *message, +				void *user_data)
> +{
> +	const char *device, *property;
> +	DBusMessageIter iter;
> +
> +	dbus_message_iter_init(message, &iter);
> +
> +	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING)
> +		return FALSE;
> +
> +	dbus_message_iter_get_basic(&iter, &property);
> +	if (g_str_equal(property, "UUIDs") == FALSE)
> +		return TRUE;
> +
> +	if (!dbus_message_iter_next(&iter))
> +		return FALSE;
> +
> +	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT)
> +		return FALSE;
> +
> +	device = dbus_message_get_path(message);
> +	parse_uuids(&iter, device);
> +
> +	return TRUE;
> +}
> +
>  static void list_adapters_cb(DBusPendingCall *call, gpointer user_data)
>  {
>  	DBusError err;
> @@ -725,6 +763,8 @@ static void hfp_remove(struct ofono_modem *modem)
> 
>  	hfp_unregister_ofono_handsfree(modem);
> 
> +	g_hash_table_remove(uuid_hash, data->handsfree_path);
> +
>  	g_free(data->handsfree_path);
>  	g_free(data);
> 
> @@ -798,7 +838,8 @@ static struct ofono_modem_driver hfp_driver = {
>  	.post_sim	= hfp_post_sim,
>  };
> 
> -static guint added_watch;
> +static guint adapter_watch;
> +static guint uuid_watch;
> 
>  static int hfp_init(void)
>  {
> @@ -809,12 +850,21 @@ static int hfp_init(void)
> 
>  	connection = ofono_dbus_get_connection();
> 
> -	added_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
> +	adapter_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
>  						BLUEZ_MANAGER_INTERFACE,
>  						"AdapterAdded",
>  						adapter_added, NULL, NULL);
> 
> -	if (added_watch == 0) {
> +	uuid_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
> +						BLUEZ_DEVICE_INTERFACE,
> +						"PropertyChanged",
> +						uuid_emitted, NULL, NULL);
> +
> +
> +	uuid_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
> +			g_free, g_free);
> +
> +	if (adapter_watch == 0 || uuid_watch == 0) {
>  		err = -EIO;
>  		goto remove;
>  	}
> @@ -828,7 +878,9 @@ static int hfp_init(void)
>  	return 0;
> 
>  remove:
> -	g_dbus_remove_watch(connection, added_watch);
> +	g_dbus_remove_watch(connection, adapter_watch);
> +	g_dbus_remove_watch(connection, uuid_watch);
> +	g_hash_table_destroy(uuid_hash);
> 
>  	dbus_connection_unref(connection);
> 
> @@ -837,7 +889,9 @@ remove:
> 
>  static void hfp_exit(void)
>  {
> -	g_dbus_remove_watch(connection, added_watch);
> +	g_dbus_remove_watch(connection, adapter_watch);
> +	g_dbus_remove_watch(connection, uuid_watch);
> +	g_hash_table_destroy(uuid_hash);
> 
>  	ofono_modem_driver_unregister(&hfp_driver);
>  }
> 

Re: [PATCH 2/3] hfp: Don't call UnregisterAgent if a Release was received

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

Hi Gustavo,

> Prevent to call UnregisterAgent on an already unregistered agent.
> ---
>  plugins/hfp.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/plugins/hfp.c b/plugins/hfp.c
> index cd43af7..4202ddf 100644
> --- a/plugins/hfp.c
> +++ b/plugins/hfp.c
> @@ -760,8 +760,11 @@ static int hfp_probe(struct ofono_modem *modem)
>  static void hfp_remove(struct ofono_modem *modem)
>  {
>  	struct hfp_data *data = ofono_modem_get_data(modem);
> +	const char *obj_path = ofono_modem_get_path(modem);
> 
> -	hfp_unregister_ofono_handsfree(modem);
> +	if (g_dbus_unregister_interface(connection, obj_path,
> +					HFP_AGENT_INTERFACE))
> +		hfp_unregister_ofono_handsfree(modem);
> 
>  	g_hash_table_remove(uuid_hash, data->handsfree_path);
> 
> @@ -804,10 +807,14 @@ static int hfp_disconnect_ofono_handsfree(struct
>  ofono_modem *modem)
> 
>  static int hfp_disable(struct ofono_modem *modem)
>  {
> +	const char *obj_path = ofono_modem_get_path(modem);
> +
>  	DBG("%p", modem);
> 
>  	clear_data(modem);
> 
> +	g_dbus_unregister_interface(connection, obj_path, HFP_AGENT_INTERFACE);
> +

Shouldn't this part be in agent_release?

>  	hfp_disconnect_ofono_handsfree(modem);
>  	return 0;
>  }
> 

Regards,
-Denis

[PATCH 1/3] hfp: create modem for new devices paired on runtime

[Gustavo F. Padovan]

[-- Attachment #1: Type: text/plain, Size: 4186 bytes --]

It listens the Paired property to create a modem to the recently paired
devices. It also renames added_watch to adapter_watch, a more proper
name.
---
 plugins/hfp.c |   62 ++++++++++++++++++++++++++++++++++++++++++++++++++++----
 1 files changed, 57 insertions(+), 5 deletions(-)

diff --git a/plugins/hfp.c b/plugins/hfp.c
index 981b05b..3e41342 100644
--- a/plugins/hfp.c
+++ b/plugins/hfp.c
@@ -66,6 +66,7 @@ static const char *cmer_prefix[] = { "+CMER:", NULL };
 static const char *chld_prefix[] = { "+CHLD:", NULL };
 
 static DBusConnection *connection;
+static GHashTable *uuid_hash = NULL;
 
 static void hfp_debug(const char *str, void *user_data)
 {
@@ -427,6 +428,7 @@ static int hfp_create_modem(const char *device)
 {
 	struct ofono_modem *modem;
 	struct hfp_data *data;
+	const char *path;
 
 	ofono_info("Using device: %s", device);
 
@@ -451,6 +453,9 @@ static int hfp_create_modem(const char *device)
 	ofono_modem_set_data(modem, data);
 	ofono_modem_register(modem);
 
+	path = ofono_modem_get_path(modem);
+	g_hash_table_insert(uuid_hash, g_strdup(device), g_strdup(path));
+
 	return 0;
 
 free:
@@ -465,6 +470,9 @@ static void parse_uuids(DBusMessageIter *i, const char *device)
 	DBusMessageIter variant, ai;
 	const char *value;
 
+	if (g_hash_table_lookup(uuid_hash, device))
+		return;
+
 	dbus_message_iter_recurse(i, &variant);
 	dbus_message_iter_recurse(&variant, &ai);
 
@@ -624,6 +632,33 @@ static gboolean adapter_added(DBusConnection *connection, DBusMessage *message,
 	return TRUE;
 }
 
+static gboolean uuid_emitted(DBusConnection *connection, DBusMessage *message,
+				void *user_data)
+{
+	const char *device, *property;
+	DBusMessageIter iter;
+
+	dbus_message_iter_init(message, &iter);
+
+	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING)
+		return FALSE;
+
+	dbus_message_iter_get_basic(&iter, &property);
+	if (g_str_equal(property, "UUIDs") == FALSE)
+		return TRUE;
+
+	if (!dbus_message_iter_next(&iter))
+		return FALSE;
+
+	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT)
+		return FALSE;
+
+	device = dbus_message_get_path(message);
+	parse_uuids(&iter, device);
+
+	return TRUE;
+}
+
 static void list_adapters_cb(DBusPendingCall *call, gpointer user_data)
 {
 	DBusError err;
@@ -725,6 +760,8 @@ static void hfp_remove(struct ofono_modem *modem)
 
 	hfp_unregister_ofono_handsfree(modem);
 
+	g_hash_table_remove(uuid_hash, data->handsfree_path);
+
 	g_free(data->handsfree_path);
 	g_free(data);
 
@@ -798,7 +835,8 @@ static struct ofono_modem_driver hfp_driver = {
 	.post_sim	= hfp_post_sim,
 };
 
-static guint added_watch;
+static guint adapter_watch;
+static guint uuid_watch;
 
 static int hfp_init(void)
 {
@@ -809,12 +847,21 @@ static int hfp_init(void)
 
 	connection = ofono_dbus_get_connection();
 
-	added_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
+	adapter_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
 						BLUEZ_MANAGER_INTERFACE,
 						"AdapterAdded",
 						adapter_added, NULL, NULL);
 
-	if (added_watch == 0) {
+	uuid_watch = g_dbus_add_signal_watch(connection, NULL, NULL,
+						BLUEZ_DEVICE_INTERFACE,
+						"PropertyChanged",
+						uuid_emitted, NULL, NULL);
+
+
+	uuid_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
+			g_free, g_free);
+
+	if (adapter_watch == 0 || uuid_watch == 0) {
 		err = -EIO;
 		goto remove;
 	}
@@ -828,7 +875,9 @@ static int hfp_init(void)
 	return 0;
 
 remove:
-	g_dbus_remove_watch(connection, added_watch);
+	g_dbus_remove_watch(connection, adapter_watch);
+	g_dbus_remove_watch(connection, uuid_watch);
+	g_hash_table_destroy(uuid_hash);
 
 	dbus_connection_unref(connection);
 
@@ -837,9 +886,12 @@ remove:
 
 static void hfp_exit(void)
 {
-	g_dbus_remove_watch(connection, added_watch);
+	g_dbus_remove_watch(connection, adapter_watch);
+	g_dbus_remove_watch(connection, uuid_watch);
 
 	ofono_modem_driver_unregister(&hfp_driver);
+
+	g_hash_table_destroy(uuid_hash);
 }
 
 OFONO_PLUGIN_DEFINE(hfp, "Hands-Free Profile Plugins", VERSION,
-- 
1.6.4.4

Re: [PATCH 1/3] hfp: create modem for new devices paired on runtime

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

Hi Gustavo,

> It listens the Paired property to create a modem to the recently paired
> devices. It also renames added_watch to adapter_watch, a more proper
> name.
> ---

Patch has been applied, thanks.

Regards,
-Denis

Re: [PATCH 1/3] hfp: create modem for new devices paired on runtime

[=?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]


On Sat, 14 Jan 2012 18:00:55 -0200, "Gustavo F. Padovan"
<padovan@profusion.mobi> wrote:
> It listens the Paired property to create a modem to the recently paired
> devices. It also renames added_watch to adapter_watch, a more proper
> name.

Care to fix your system time and date? TIA.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis