All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes
Date: Thu, 4 Feb 2010 10:00:15 -0800	[thread overview]
Message-ID: <20100204180015.GC18548@spearce.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1002041243570.1681@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> wrote:
> >  --max-pack-size=<n>::
> > -	Maximum size of each output packfile, expressed in MiB.
> > -	The default is 4096 (4 GiB) as that is the maximum allowed
> > +	Maximum size of each output packfile.
> > +	The default is 4 GiB as that is the maximum allowed
> >  	packfile size (due to file format limitations). Some
> >  	importers may wish to lower this, such as to ensure the
> >  	resulting packfiles fit on CDs.
> 
> What file format limitation is alluded to here?  It has been a while 
> since the 4GB limit on pack file format has been removed.

The pack index v1 32 bit offset thing.  Which you fixed.

> If this is a 
> limitation of fast-import only then maybe this should be explained more 
> explicitly.

Damn.  It is.  fast-import can't write a v2 index.  Ugh.

-- 
Shawn.

  reply	other threads:[~2010-02-04 18:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-04  3:48 [PATCH 1/3] fix multiple issues with t5300 Nicolas Pitre
2010-02-04  3:48 ` [PATCH 2/3] pack-objects: fix pack generation when using pack_size_limit Nicolas Pitre
2010-02-04  3:48 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes Nicolas Pitre
2010-02-04  4:00   ` Shawn O. Pearce
2010-02-04  4:38     ` Junio C Hamano
2010-02-04 17:11       ` Junio C Hamano
2010-02-04 17:24         ` Shawn O. Pearce
2010-02-04 17:58           ` Nicolas Pitre
2010-02-04 17:59             ` Shawn O. Pearce
2010-02-04 19:10               ` [PATCH] fast-import: count --max-pack-size " Junio C Hamano
2010-02-04 19:13                 ` Shawn O. Pearce
2010-02-04 20:03                 ` Ilari Liusvaara
2010-02-04 17:49         ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count " Nicolas Pitre
2010-02-04 18:00           ` Shawn O. Pearce [this message]
2010-02-04 18:11             ` Nicolas Pitre
2010-02-04 21:20               ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100204180015.GC18548@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.