From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Nicolas Pitre <nico@fluxnic.net>,
git@vger.kernel.org
Subject: Re: [PATCH] fast-import: count --max-pack-size in bytes
Date: Thu, 4 Feb 2010 22:03:07 +0200 [thread overview]
Message-ID: <20100204200306.GA11700@Knoppix> (raw)
In-Reply-To: <7v4olwbyvf.fsf_-_@alter.siamese.dyndns.org>
On Thu, Feb 04, 2010 at 11:10:44AM -0800, Junio C Hamano wrote:
> Similar in spirit to 07cf0f2 (make --max-pack-size argument to 'git
> pack-object' count in bytes, 2010-02-03) which made the option by the same
> name to pack-objects, this counts the pack size limit in bytes.
>
> In order not to cause havoc with people used to the previous megabyte
> scale an integer smaller than 8092 is interpreted in megabytes but the
Typo? Shouldn't it be 8192?
> user gets a warning. Also a minimum size of 1 MiB is enforced to avoid an
> explosion of pack files.
-Ilari
next prev parent reply other threads:[~2010-02-04 20:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 3:48 [PATCH 1/3] fix multiple issues with t5300 Nicolas Pitre
2010-02-04 3:48 ` [PATCH 2/3] pack-objects: fix pack generation when using pack_size_limit Nicolas Pitre
2010-02-04 3:48 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes Nicolas Pitre
2010-02-04 4:00 ` Shawn O. Pearce
2010-02-04 4:38 ` Junio C Hamano
2010-02-04 17:11 ` Junio C Hamano
2010-02-04 17:24 ` Shawn O. Pearce
2010-02-04 17:58 ` Nicolas Pitre
2010-02-04 17:59 ` Shawn O. Pearce
2010-02-04 19:10 ` [PATCH] fast-import: count --max-pack-size " Junio C Hamano
2010-02-04 19:13 ` Shawn O. Pearce
2010-02-04 20:03 ` Ilari Liusvaara [this message]
2010-02-04 17:49 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count " Nicolas Pitre
2010-02-04 18:00 ` Shawn O. Pearce
2010-02-04 18:11 ` Nicolas Pitre
2010-02-04 21:20 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204200306.GA11700@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@fluxnic.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.