From: Andi Kleen <andi@firstfloor.org>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
submit@firstfloor.org, linux-kernel@vger.kernel.org,
haicheng.li@intel.com, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org
Subject: Re: [PATCH] [3/4] SLAB: Separate node initialization into separate function
Date: Sat, 6 Feb 2010 08:27:46 +0100 [thread overview]
Message-ID: <20100206072746.GP29555@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1002051324370.2376@chino.kir.corp.google.com>
> As Christoph mentioned, this patch is out of order with the previous one
Ok.
> in the series; slab_node_prepare() is called in that previous patch by a
> memory hotplug callback without holding cache_chain_mutex (it's taken by
> the cpu hotplug callback prior to calling cpuup_prepare() currently). So
> slab_node_prepare() should note that we require the mutex and the memory
> hotplug callback should take it in the previous patch.
AFAIK the code is correct. If you feel the need for additional
documentation feel free to send patches yourself.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
submit@firstfloor.org, linux-kernel@vger.kernel.org,
haicheng.li@intel.com, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org
Subject: Re: [PATCH] [3/4] SLAB: Separate node initialization into separate function
Date: Sat, 6 Feb 2010 08:27:46 +0100 [thread overview]
Message-ID: <20100206072746.GP29555@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1002051324370.2376@chino.kir.corp.google.com>
> As Christoph mentioned, this patch is out of order with the previous one
Ok.
> in the series; slab_node_prepare() is called in that previous patch by a
> memory hotplug callback without holding cache_chain_mutex (it's taken by
> the cpu hotplug callback prior to calling cpuup_prepare() currently). So
> slab_node_prepare() should note that we require the mutex and the memory
> hotplug callback should take it in the previous patch.
AFAIK the code is correct. If you feel the need for additional
documentation feel free to send patches yourself.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-06 7:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 21:39 [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues Andi Kleen
2010-02-03 21:39 ` Andi Kleen
2010-02-03 21:39 ` [PATCH] [1/4] SLAB: Handle node-not-up case in fallback_alloc() Andi Kleen
2010-02-03 21:39 ` Andi Kleen
2010-02-05 21:06 ` David Rientjes
2010-02-05 21:06 ` David Rientjes
2010-02-06 7:25 ` Andi Kleen
2010-02-06 7:25 ` Andi Kleen
2010-02-06 9:53 ` David Rientjes
2010-02-06 9:53 ` David Rientjes
2010-02-06 15:56 ` Andi Kleen
2010-02-06 15:56 ` Andi Kleen
2010-02-06 22:31 ` David Rientjes
2010-02-06 22:31 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [2/4] SLAB: Set up the l3 lists for the memory of freshly added memory Andi Kleen
2010-02-03 21:39 ` Andi Kleen
2010-02-05 19:12 ` Christoph Lameter
2010-02-05 19:12 ` Christoph Lameter
2010-02-05 21:17 ` David Rientjes
2010-02-05 21:17 ` David Rientjes
2010-02-06 7:26 ` Andi Kleen
2010-02-06 7:26 ` Andi Kleen
2010-02-06 9:47 ` David Rientjes
2010-02-06 9:47 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [3/4] SLAB: Separate node initialization into separate function Andi Kleen
2010-02-03 21:39 ` Andi Kleen
2010-02-05 19:15 ` Christoph Lameter
2010-02-05 19:15 ` Christoph Lameter
2010-02-05 21:29 ` David Rientjes
2010-02-05 21:29 ` David Rientjes
2010-02-06 7:27 ` Andi Kleen [this message]
2010-02-06 7:27 ` Andi Kleen
2010-02-06 9:55 ` David Rientjes
2010-02-06 9:55 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Andi Kleen
2010-02-03 21:39 ` Andi Kleen
2010-02-05 19:16 ` Christoph Lameter
2010-02-05 19:16 ` Christoph Lameter
2010-02-05 8:27 ` [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues Pekka Enberg
2010-02-05 8:27 ` Pekka Enberg
2010-02-05 19:19 ` Christoph Lameter
2010-02-05 19:19 ` Christoph Lameter
2010-02-05 20:22 ` Andi Kleen
2010-02-05 20:22 ` Andi Kleen
2010-02-05 20:55 ` Christoph Lameter
2010-02-05 20:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100206072746.GP29555@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=haicheng.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=submit@firstfloor.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.