From: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Maarten Maathuis <madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL
Date: Sun, 7 Feb 2010 10:54:04 +0100 [thread overview]
Message-ID: <20100207095404.GA2870@joi.lan> (raw)
In-Reply-To: <1265505080-7099-1-git-send-email-madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Sun, Feb 07, 2010 at 02:11:20AM +0100, Maarten Maathuis wrote:
> - 'joi' on irc pointed out that this triggers a BUG_ON, because kzalloc could
> sleep.
> - The irq handler should restore the value NV03_PFIFO_CACHES, but still it's
> better if this stuff doesn't happen in the middle of fifo create context. I see
> no reason in spin locking pgraph create context, it isn't activated at that
> stage.
> - Move and rename the lock after some discussion with 'joi', even better naming
> suggestions are appreciated.
>
> Signed-off-by: Maarten Maathuis <madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
(joi==/me)
Tested-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
next prev parent reply other threads:[~2010-02-07 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 1:11 [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL Maarten Maathuis
[not found] ` <1265505080-7099-1-git-send-email-madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-07 9:54 ` Marcin Slusarz [this message]
2010-02-08 10:30 ` Pekka Paalanen
[not found] ` <20100208123059.7e8154bf-cxYvVS3buNOdIgDiPM52R8c4bpwCjbIv@public.gmane.org>
2010-02-08 11:02 ` Maarten Maathuis
[not found] ` <6d4bc9fc1002080302v2f6d6010i2880fc4a8d1523a8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-08 11:45 ` Pekka Paalanen
-- strict thread matches above, loose matches on Subject: below --
2010-02-08 17:38 Maarten Maathuis
[not found] ` <1265650698-4773-1-git-send-email-madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-08 17:39 ` Maarten Maathuis
[not found] ` <6d4bc9fc1002080939r2f3066b8k2e4541391628acc9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-09 18:54 ` Maarten Maathuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100207095404.GA2870@joi.lan \
--to=marcin.slusarz-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.