From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: Suppress locking initialisation failure messages when --ignorelockingfailure is used
Date: Mon, 8 Feb 2010 11:25:39 -0500 [thread overview]
Message-ID: <20100208162538.GA25318@redhat.com> (raw)
In-Reply-To: <4B702E6F.7050901@redhat.com>
On Mon, Feb 08 2010 at 10:31am -0500,
Milan Broz <mbroz@redhat.com> wrote:
> On 02/08/2010 04:09 PM, Mike Snitzer wrote:
> >>> Shouldn't rc.sysinit's "vgchange -a y --ignorelockingfailure" come
> >>> _after_ root's rw remount?
> >>
> >> Exactly. It should also start volume monitoring etc.
> >>
> >> Note that monitoring need rw access (at least for status log to syslog,
> >> but also if it triggers some change, it will require real lock - to perform
> >> repair, snapshot resize or other action; metadata backups etc).
> >
> > The monitoring gets started, by the "lvm2-monitor" service, after
> > rc.sysinit. So we should be fine there.
>
> I was just not sure if "vgchange -a y" here tries to start monitoring or not.
> If so, what happens? (lvm2-monitor init rc skript then will just restart it?)
> Is it what we want?
Gah, good point! Though with current rc.sysinit, because of read-only
root, I believe monitoring will fail to start because of locking
failure. But I can't clearly recall; will need to trace it.
Changing rc.sysinit's "vgchange -a y" to be after the root's remount rw
would effectively eliminate the need for the "lvm2-monitor" initscript
(for startup). This could be a good thing.
But any removal of lvm2-monitor is secondary; as there is potentially
some value in having a script to start/stop monitoring. Until it is
removed/disabled, at a minimum, we expose ourselves to redundant polling
at boot (e.g. snapshot-merge completion polling). That is, IFF we move
rc.sysinit's "vgchange -a y" to be after remount rw.
I'm still not seeing a reason why LVM volumes are getting activated
before root's remount rw. I think we should change that. Then we're
left having to decide on LVM monitoring (disable that service?).
Mike
prev parent reply other threads:[~2010-02-08 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 13:17 [PATCH] Suppress locking initialisation failure messages when --ignorelockingfailure is used Peter Rajnoha
2010-02-08 13:32 ` Milan Broz
2010-02-08 13:46 ` Mike Snitzer
2010-02-08 14:36 ` Peter Rajnoha
2010-02-08 14:55 ` Mike Snitzer
2010-02-08 15:01 ` Peter Rajnoha
2010-02-08 15:04 ` Milan Broz
2010-02-08 15:09 ` Mike Snitzer
2010-02-08 15:31 ` Milan Broz
2010-02-08 16:25 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208162538.GA25318@redhat.com \
--to=snitzer@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.