All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: Suppress locking initialisation failure messages when --ignorelockingfailure is used
Date: Mon, 08 Feb 2010 16:04:20 +0100	[thread overview]
Message-ID: <4B7027F4.6090307@redhat.com> (raw)
In-Reply-To: <20100208145515.GB20595@redhat.com>

On 02/08/2010 03:55 PM, Mike Snitzer wrote:
> On Mon, Feb 08 2010 at  9:36am -0500,
> Peter Rajnoha <prajnoha@redhat.com> wrote:
> 
>> On 02/08/2010 02:46 PM, Mike Snitzer wrote:
>>>
>>> Dracut is rw but we (dracut's lvm hooks) impose read-only locking
>>> through dracut's lvm.conf.  This was done so no metadata updates could
>>> occur within the initramfs environment.
>>
>> Yes, dracut environment is rw but the root fs itself is mounted ro first.
>> The "vgchange -a y --ignorelockingfailure" (that is called after the pivotroot)
>> is run just before the rw remount happens (..looking at Fedora/RHEL6 rc.sysinit).
>>
>> We didn't notice that directly before, because init_locking silently "failed"
>> (but returned with OK status from init_locking fn, since --ignorelockingfailure is set).
> 
> Shouldn't rc.sysinit's "vgchange -a y --ignorelockingfailure" come
> _after_ root's rw remount?

Exactly. It should also start volume monitoring etc.

Note that monitoring need rw access (at least for status log to syslog,
but also if it triggers some change, it will require real lock - to perform
repair, snapshot resize or other action; metadata backups etc).

I think that the sequence is broken and we should not paper over it by disabling
the error message.

Milan



  parent reply	other threads:[~2010-02-08 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08 13:17 [PATCH] Suppress locking initialisation failure messages when --ignorelockingfailure is used Peter Rajnoha
2010-02-08 13:32 ` Milan Broz
2010-02-08 13:46   ` Mike Snitzer
2010-02-08 14:36     ` Peter Rajnoha
2010-02-08 14:55       ` Mike Snitzer
2010-02-08 15:01         ` Peter Rajnoha
2010-02-08 15:04         ` Milan Broz [this message]
2010-02-08 15:09           ` Mike Snitzer
2010-02-08 15:31             ` Milan Broz
2010-02-08 16:25               ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7027F4.6090307@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.